1330232 - Blocked media was resumed with sound when user click "mute tab" in the pop-up menu

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Alastor Wu [:alwu]]

STR.
1. open https://www.youtube.com/watch?v=aYzSAw0fQ1Y in background tab
2. click right click on the tab to see the pop-up menu
3. click "mute tab"

Expect.
4. Tab is muted and resumed

Actual.
4. Tab isn't muted and resumed

Comment 1

[Alastor Wu [:alwu]]

After discussed with UX, we would show the "play tab" in the pop-up menu instead of "mute tab".

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1330232 - show the label of 'play tab' in the pop-up menu.

If the tab is blocked, we should show "play tab" in the pop-up menu instead of "mute tab".

Review commit: https://reviewboard.mozilla.org/r/105368/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/105368/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8827762 [details]
Bug 1330232 - show the label of 'play tab' in the pop-up menu.

https://reviewboard.mozilla.org/r/105368/#review106708

::: browser/locales/en-US/chrome/browser/browser.properties:708
(Diff revision 1)
>  muteTab.label = Mute Tab
>  muteTab.accesskey = M
>  unmuteTab.label = Unmute Tab
>  unmuteTab.accesskey = M
> +playTab.label = Play Tab
> +playTab.accesskey = M

Can we use a key that is in "Play Tab"?

Comment 4

[Alastor Wu [:alwu]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #3)
> Can we use a key that is in "Play Tab"?

Hi, Jared,
Do you mean how do we use that key? or you're asking other thing?
When you open the pop-up menu, then you can press key "M" to open that tab.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

I mean that "M" is not a character present in "Play Tab". Could we use "P", "l", "a", "y", or any other letter here instead of "M"?

Comment 6

[Alastor Wu [:alwu]]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5)
> I mean that "M" is not a character present in "Play Tab". Could we use "P",
> "l", "a", "y", or any other letter here instead of "M"?

Sure! I'll replace "M" with "P".

Comment 7

[Alastor Wu [:alwu]]

Comment on attachment 8827762 [details]
Bug 1330232 - show the label of 'play tab' in the pop-up menu.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/105368/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c847fb6dba8e
show the label of 'play tab' in the pop-up menu. r=jaws

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c847fb6dba8e

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Alastor, if I understand correctly, this is a new regression. Do you want to uplift this to 52? Thanks

Comment 11

[Blake Wu [:bwu][:blakewu]]

Currently, block-autoplay-in-the-background is only enabled in nightly per Bug 1331317.

Comment 12

[Alastor Wu [:alwu]]

The feature isn't opened on FF52 (bug 1331317), and we might enable it in the 53+.
We don't need to uplift the change to 52.

Comment 13

[Simona Badau, Desktop QA]

Reproduced the initial issue using Nightly 53.0a1 (Build ID: 20170117030218) on Windows 10 x64.

I can confirm the fix using the latest Nightly 54.0a1 - "Play Tab" is now displayed in the pop-up menu instead of "mute tab". Verified on Windows 10 x64, Mac OS X 10.11 and Ubuntu 16.04 x64.

But, "P" key is used also for Pin Tab, not just for Play Tab(an extra Enter key has to be hit to get the same functionality as other shortcuts key have).

Alastor, is this the wanted behavior?

Comment 14

[Alastor Wu [:alwu]]

Thank Simona!
I didn't consider the access key conflict, and I opened bug1336309 to solve this issue.

Comment 15

[Simona Badau, Desktop QA]

Based on Comment 13, setting the status-firefox54: to verified.

Since the Block playback feature is disabled on the latest Firefox Developer Edition 53.0a2, I'm also setting the status-firefox53: to disabled.