Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Modify the access key for "unmute tab" option

VERIFIED FIXED in Firefox 54

Status

()

Firefox
Tabbed Browser
VERIFIED FIXED
6 months ago
3 months ago

People

(Reporter: alwu, Assigned: alwu)

Tracking

47 Branch
Firefox 54
Points:
---

Firefox Tracking Flags

(firefox54 verified)

Details

(Whiteboard: [testday-20170428])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Fork from bug1336309 comment2, unmuteTab used "M" as access key, but "M" is not the first character of "unmute". We should change to "U" or "m".
Comment hidden (mozreview-request)

Comment 2

6 months ago
mozreview-review
Comment on attachment 8833837 [details]
Bug 1336869 - modify the access key for 'unmute tab'.

https://reviewboard.mozilla.org/r/109960/#review111130
Attachment #8833837 - Flags: review?(jaws) → review+

Comment 3

6 months ago
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ccbbb9aabf6
modify the access key for 'unmute tab'. r=jaws
Funny story, we have a test which makes sure you didn't change that (or, really, that you didn't change that without telling it about the change).

Backed out in https://hg.mozilla.org/integration/autoland/rev/28f5dd107842 for https://treeherder.mozilla.org/logviewer.html#?job_id=74999878&repo=autoland
Comment hidden (mozreview-request)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=28987f3694b079c03de703e0abb291200263f589

Comment 7

6 months ago
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a31cace18fc6
modify the access key for 'unmute tab'. r=jaws

Comment 8

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a31cace18fc6
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54

Comment 9

5 months ago
https://bugzilla.mozilla.org/show_bug.cgi?id=1334883

Comment 10

5 months ago
Bug Verified [bugday-20170302]
Verified in Firefox 54 beta 3 testday (https://public.etherpad-mozilla.org/p/testday-20170428).
Status: RESOLVED → VERIFIED
status-firefox54: fixed → verified
Whiteboard: [testday-20170428]
You need to log in before you can comment on or make changes to this bug.