1337131 - Enable restarting the GPU process when it dies

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

I don't think there's any reason not to do this now - restarting has worked since the initial rollout, but we held off to minimize the test surface of the initial release.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: bug1331761.patch

This sets the maximum number of restarts to 3 (the default is 0).

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: bug1337131.patch

Err, wrong patch.

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8834135 [details] [diff] [review]
bug1337131.patch

Review of attachment 8834135 [details] [diff] [review]:
-----------------------------------------------------------------

Where will we collect the telemetry for the GPU process startup time on restarts?  One reason I can see for not doing this is if we have a very long GPU process startup time - it would lead to much longer pause from the user's point of view.  Perhaps we need the "start SW compositor while waiting" with more urgency now?  Better information on how far apart the restarts are would also help (telemetry again.)  Perhaps it's worth leaving this nightly only until we sort these out?

Also, do we have a bug for the follow up on a slightly more complex heuristic that takes into account frequency, and perhaps also disables the GPU process permanently until version/driver change?

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

(In reply to Milan Sreckovic [:milan] from comment #3)
> Comment on attachment 8834135 [details] [diff] [review]
> bug1337131.patch
> 
> Review of attachment 8834135 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Where will we collect the telemetry for the GPU process startup time on
> restarts?  One reason I can see for not doing this is if we have a very long
> GPU process startup time - it would lead to much longer pause from the
> user's point of view.  Perhaps we need the "start SW compositor while
> waiting" with more urgency now?  Better information on how far apart the
> restarts are would also help (telemetry again.)  Perhaps it's worth leaving
> this nightly only until we sort these out?

That's a good point. We do have the timeout, which is currently set to 3s. Is it good enough to rely on that, and maybe have a way to test that it works?

> Also, do we have a bug for the follow up on a slightly more complex
> heuristic that takes into account frequency, and perhaps also disables the
> GPU process permanently until version/driver change?

No, I will file that shortly.

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

See bug 1337149 for heuristics.

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

Non-urgent ni? for thoughts on comment #4.

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to David Anderson [:dvander] from comment #4)
> ...
> 
> That's a good point. We do have the timeout, which is currently set to 3s.
> Is it good enough to rely on that, and maybe have a way to test that it
> works?

I'd say that is good enough, especially for restarts.

Comment 8

[Milan Sreckovic [:milan] (needinfo for best results)]

If this didn't land yet (or I suppose even if it did), can we have it stay on nightly and only ride 55? There were some issues discovered when softvision was testing with this option set to 3 and forced GPU process kills; want to make sure we have a chance to address those.

Comment 9

[David Anderson [:dvander] - inactive, e-mail if emergency]

Sure, this did not land yet. I'll hold off. Could those issues be filed & block this bug?

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f553a59096ad
Enable restarting the GPU process when it dies. (bug 1337131, r=milan)

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f553a59096ad