1337518 - Remove PCrashReporter use from GMP

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect)

Description

[David Anderson [:dvander] - inactive, e-mail if emergency]

The GPU process introduced a new crash reporting protocol in bug 1278717. We can use that here too.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: patch

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8834600 [details] [diff] [review]
patch

Review of attachment 8834600 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/gmp/GMPParent.cpp
@@ +513,5 @@
> +    if (!GetCrashID(dumpID)) {
> +      NS_WARNING("GMP crash without crash report");
> +      dumpID = mName;
> +      dumpID += '-';
> +      AppendUTF8toUTF16(mVersion, dumpID);

This doesn't seem right to me. Why would this work?

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

I've no idea, to be honest. It  was pre-existing.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Oh, I didn't realized it moved from elsewhere.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/32b6fb32be09
Replace GMP use of PCrashReporter with shmem-based annotations. (bug 1337518, r=billm)

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/32b6fb32be09