Closed Bug 1337518 Opened 4 years ago Closed 4 years ago

Remove PCrashReporter use from GMP

Categories

(Core :: Audio/Video: GMP, defect)

Product:
Core
Component:
Audio/Video: GMP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: dvander, Assigned: dvander)

References

Details

Attachments

(1 file)

patch
16.32 KB, patch
billm
: review+
Details | Diff | Splinter Review 
The GPU process introduced a new crash reporting protocol in bug 1278717. We can use that here too.
Attached patch patch — — Splinter Review
Attachment #8834600 - Flags: review?(wmccloskey)
Comment on attachment 8834600 [details] [diff] [review]
patch

Review of attachment 8834600 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/gmp/GMPParent.cpp
@@ +513,5 @@
> +    if (!GetCrashID(dumpID)) {
> +      NS_WARNING("GMP crash without crash report");
> +      dumpID = mName;
> +      dumpID += '-';
> +      AppendUTF8toUTF16(mVersion, dumpID);

This doesn't seem right to me. Why would this work?
Attachment #8834600 - Flags: review?(wmccloskey) → review+
I've no idea, to be honest. It  was pre-existing.
Oh, I didn't realized it moved from elsewhere.
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/32b6fb32be09
Replace GMP use of PCrashReporter with shmem-based annotations. (bug 1337518, r=billm)
https://hg.mozilla.org/mozilla-central/rev/32b6fb32be09
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Depends on: 1340258
You need to log in before you can comment on or make changes to this bug.