133754 - nsWindowWatcher.cpp uses AssignWithConversion

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

AssignWithConversion is used in nsWindowWatcher.cpp; it should, instead, use
NS_ConvertUTF8toUCS2.

Comment 1

[Adam Lock]

-> danm

Comment 2

[Adam Lock]

.

Comment 3

[Philip K. Warren]

This is causing the "Reset Master Password" functionality to not work in
translated versions which translate the InternalToken string in
pipnss.properties to a string which contains non-ASCII characters. In
mozilla/security/manager/pki/resources/content/pref-masterpass.js,
internal_token.tokenName is passed via window.open to
mozilla/security/manager/pki/resources/content/resetpassword.js. In
resetpassword.js, the tokenName is then passed to findTokenByName. In our
internal testing, we found that the tokenName parameter was being corrupted via
the AssignWithConversion call in nsWindowWatcher::OpenWindowJS. After changing
the usage of AssignWithConversion to NS_ConvertUTF8toUCS2, the problem was fixed.

This problem can be reproduced in the French translated version of Netscape 7.

Comment 4

[Philip K. Warren]

Attachment: AssignWithConversion -> NS_ConvertUTF8toUCS2

Comment 5

[Frank Tang]

How can we be so sure that aName has to be UTF-8
AssignWithConversion is definitely wrong. But I am not sure treat it as UTF8 is
right neither. 
We should look at the api. Why we use char* here instead of PRUnichar* for aName?

Comment 6

[Frank Tang]

reassign this to simon montagu.
Simon. Please work with danm about this issue. 

Comment 7

[Michele Carlson]

cc. rchen

Comment 8

[Mike Kaply [:mkaply]]

If you look at the code that calls this function, it shows the UTF8 stuff.

Here is the call from nsGlobalWindow:

http://lxr.mozilla.org/seamonkey/source/dom/src/base/nsGlobalWindow.cpp#4295

name is explicitly set with ToNewUTF8String

The other calls I can find call ww->OpenWindow with "_blank" explicitly as the name

Comment 9

[Simon Montagu :smontagu]

Comment on attachment 101456 [details] [diff] [review]
AssignWithConversion -> NS_ConvertUTF8toUCS2

It would have been nicer to change the API to use a Unicode string rather than
doing a double conversion, but since the interface is frozen, this seems to be
the way to go.
r=smontagu

Comment 10

[Carine Held]

This is a problem too in the JA 11/05 build. I can not use the Reset Password
button.

Comment 11

[Michele Carlson]

adding nsbeta1+

Comment 12

[Ying-Lin Xia]

Any update on this one?

Comment 13

[Alec Flett]

Comment on attachment 101456 [details] [diff] [review]
AssignWithConversion -> NS_ConvertUTF8toUCS2

Ok, just make sure this is really UTF8 here! (are you sure it isn't the native
charset?)

Comment 14

[Simon Montagu :smontagu]

>just make sure this is really UTF8 here!

See comment 8 

Comment 15

[Philip K. Warren]

Checked in:

Checking in nsWindowWatcher.cpp;
/cvsroot/mozilla/embedding/components/windowwatcher/src/nsWindowWatcher.cpp,v 
<--  nsWindowWatcher.cpp
new revision: 1.69; previous revision: 1.68
done