133803 - publish images in a subdirectory causes absolute urls (to wrong url)

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[michael wendell]

This was origally bug 131218, but the images are now being uploaded, so this is
to cover what wasn't fixed.

If you try to upload an image to a subdirectory on an FTP server, the HTML page
does not point to the correct place.

Steps to Reproduce:
1. Restart NS and launch Composer
2. Create a simple page with two lines of text and one image
3. Click on File - Publish As
4. Fill in all the appropriate information for your FTP server
5. Make sure to check the boxes to "Include images and other files" and "Use
this site subdirectory" Type the name of an image directory
6. Click Publish

Actual results:
I get the message "user anonymous unknown" when uploading, but if I check the
FTP server, both the HTML page and the image were uploaded to their correct
directories.  Then I check the HTML source of the page, and
find out that the URL for the image is now listed as the full FTP url of the
image without the username and password.

Expected results:
I would expect that the image would upload, and that the URL in the HTML source
would be relative, something to the effect of /images/image.jpg

Comment 1

[Kathleen :Brade]

ok, there are really two issues here.  This bug will focus on the absolute url
(they are supposed to be made relative).  I'll take this bug.

The issue of the "user anonymous unknown" dialog should be filed as a separate
bug (hopefully Charley can fix that).  The problem (I think) is that we are
setting the document's url to just the ftp url instead of the ftp url with the
login in it (I'd skip pw since I don't think users want their password showing
up in odd places like in a printout).

DSL Michael--do you mind filing another bug?

Comment 2

[michael wendell]

bug 133823 filed.

Comment 3

[Charles Manske]

See comments in bug 133823. I don't think there is a good solution for login
failure problem on the Composer side, except to require that the use always edit
the HTTP verion of the file, not the FTP url.

Comment 4

[Kathleen :Brade]

Attachment: generate relative url

Comment 5

[Adam Lock]

Comment on attachment 76742 [details] [diff] [review]
generate relative url

r=adamlock

Comment 6

[kinmoz]

Comment on attachment 76742 [details] [diff] [review]
generate relative url

sr=[e-mail]

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 76742 [details] [diff] [review]
generate relative url

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 8

[Kathleen :Brade]

fix checked in

Comment 9

[michael wendell]

Well, with the 04-02 trunk build, Composer isn't making the image links
absolute, but the links are still not coming out right.  

New bug 134940 to cover the new issue.

Marking VERIFIED.