1338287 - Make nsIDocument::DocumentFlashClassification accessible from privileged JS

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Robin Steuber (they/them) [:bytesized]]

We want the pings to be able to access the document flash classification.

Comment 1

[Robin Steuber (they/them) [:bytesized]]

Attachment: Bug 1338287 - Make nsIDocument::DocumentFlashClassification accessible from privileged JS

Review commit: https://reviewboard.mozilla.org/r/112194/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112194/

Comment 2

[Robin Steuber (they/them) [:bytesized]]

Comment on attachment 8836881 [details]
Bug 1338287 - Make nsIDocument::DocumentFlashClassification accessible from privileged JS

Can you take a look at this and make sure that this is what you had in mind? You can see sample usage in browser_flash_block_lists.js.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8836881 [details]
Bug 1338287 - Make nsIDocument::DocumentFlashClassification accessible from privileged JS

https://reviewboard.mozilla.org/r/112194/#review113518

r=me

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8836881 [details]
Bug 1338287 - Make nsIDocument::DocumentFlashClassification accessible from privileged JS

(In reply to Kirk Steuber [:bytesized] from comment #2)
> Can you take a look at this and make sure that this is what you had in mind?
> You can see sample usage in browser_flash_block_lists.js.

Yep, this is perfect

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3eebe9f81fc9
Make nsIDocument::DocumentFlashClassification accessible from privileged JS r=bz

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3eebe9f81fc9

Comment 7

[Robin Steuber (they/them) [:bytesized]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ee137beb7ae

Comment 8

[Robin Steuber (they/them) [:bytesized]]

Comment on attachment 8836881 [details]
Bug 1338287 - Make nsIDocument::DocumentFlashClassification accessible from privileged JS

Approval Request Comment
[Feature/Bug causing the regression]: This feature is needed for the Shield study to be run on Release 52 (bug 1335232), which we'll use to study the effect of making flash click-to-play by default.
[User impact if declined]: Can't run the study as intended
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Not for this feature independently. We'll do QE on the study as a whole to make sure all pieces work as expected
[List of other uplifts needed for the feature/fix]: Bug 1318768, Bug 1323220, Bug 1325255, Bug 1322204, Bug 1325651, Bug 1319571, Bug 1321377, Bug 1307604, Bug 1323064, Bug 1335549, Bug 1333303, Bug 1333483, Bug 1336714, Bug 1338287
[Is the change risky?]: No
[Why is the change risky/not risky?]: Makes existing code accessible from privileged Javascript 
[String changes made/needed]: none

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 8836881 [details]
Bug 1338287 - Make nsIDocument::DocumentFlashClassification accessible from privileged JS

this was deemed too risky for beta

Comment 10

[Robin Steuber (they/them) [:bytesized]]

@lizzard As I said on IRC, I would like this uplifted to Beta 53. Since it was denied for Beta 52, I cannot make the request myself, so if you could help me out I would appreciate it. Thanks!

Comment 11

[Benjamin Smedberg]

Comment on attachment 8836881 [details]
Bug 1338287 - Make nsIDocument::DocumentFlashClassification accessible from privileged JS

resetting approval flag

Comment 12

[Robin Steuber (they/them) [:bytesized]]

I should note that the bugs listed in Comment 8 as "List of other uplifts needed for the feature/fix" were required for uplift to Firefox 52. They are already in Firefox 53, so they do not need to be uplifted to it.

Comment 13

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8836881 [details]
Bug 1338287 - Make nsIDocument::DocumentFlashClassification accessible from privileged JS

Last bit of cleanup before we ship the Flash study in 53.

Comment 14

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

[Tracking Requested - why for this release]:

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/df36e8af5a74