Make nsIDocument::DocumentFlashClassification accessible from privileged JS

RESOLVED FIXED in Firefox 53

Status

()

Core
Plug-ins
RESOLVED FIXED
4 months ago
2 months ago

People

(Reporter: bytesized, Assigned: bytesized)

Tracking

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(firefox53+ fixed, firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

4 months ago
We want the pings to be able to access the document flash classification.
Comment hidden (mozreview-request)
(Assignee)

Updated

3 months ago
Assignee: nobody → ksteuber
(Assignee)

Comment 2

3 months ago
Comment on attachment 8836881 [details]
Bug 1338287 - Make nsIDocument::DocumentFlashClassification accessible from privileged JS

Can you take a look at this and make sure that this is what you had in mind? You can see sample usage in browser_flash_block_lists.js.
Attachment #8836881 - Flags: feedback?(felipc)
(Assignee)

Updated

3 months ago
Attachment #8836881 - Flags: review?(bzbarsky)
Comment on attachment 8836881 [details]
Bug 1338287 - Make nsIDocument::DocumentFlashClassification accessible from privileged JS

https://reviewboard.mozilla.org/r/112194/#review113518

r=me
Attachment #8836881 - Flags: review?(bzbarsky) → review+
Comment on attachment 8836881 [details]
Bug 1338287 - Make nsIDocument::DocumentFlashClassification accessible from privileged JS

(In reply to Kirk Steuber [:bytesized] from comment #2)
> Can you take a look at this and make sure that this is what you had in mind?
> You can see sample usage in browser_flash_block_lists.js.

Yep, this is perfect
Attachment #8836881 - Flags: feedback?(felipc) → feedback+

Comment 5

3 months ago
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3eebe9f81fc9
Make nsIDocument::DocumentFlashClassification accessible from privileged JS r=bz
https://hg.mozilla.org/mozilla-central/rev/3eebe9f81fc9
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
(Assignee)

Comment 7

3 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ee137beb7ae
(Assignee)

Comment 8

3 months ago
Comment on attachment 8836881 [details]
Bug 1338287 - Make nsIDocument::DocumentFlashClassification accessible from privileged JS

Approval Request Comment
[Feature/Bug causing the regression]: This feature is needed for the Shield study to be run on Release 52 (bug 1335232), which we'll use to study the effect of making flash click-to-play by default.
[User impact if declined]: Can't run the study as intended
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Not for this feature independently. We'll do QE on the study as a whole to make sure all pieces work as expected
[List of other uplifts needed for the feature/fix]: Bug 1318768, Bug 1323220, Bug 1325255, Bug 1322204, Bug 1325651, Bug 1319571, Bug 1321377, Bug 1307604, Bug 1323064, Bug 1335549, Bug 1333303, Bug 1333483, Bug 1336714, Bug 1338287
[Is the change risky?]: No
[Why is the change risky/not risky?]: Makes existing code accessible from privileged Javascript 
[String changes made/needed]: none
Attachment #8836881 - Flags: approval-mozilla-release?
Attachment #8836881 - Flags: approval-mozilla-beta?
Comment on attachment 8836881 [details]
Bug 1338287 - Make nsIDocument::DocumentFlashClassification accessible from privileged JS

this was deemed too risky for beta
Attachment #8836881 - Flags: approval-mozilla-release?
Attachment #8836881 - Flags: approval-mozilla-beta?
Attachment #8836881 - Flags: approval-mozilla-beta-
(Assignee)

Comment 10

2 months ago
@lizzard As I said on IRC, I would like this uplifted to Beta 53. Since it was denied for Beta 52, I cannot make the request myself, so if you could help me out I would appreciate it. Thanks!
Flags: needinfo?(lhenry)
Comment on attachment 8836881 [details]
Bug 1338287 - Make nsIDocument::DocumentFlashClassification accessible from privileged JS

resetting approval flag
Attachment #8836881 - Flags: approval-mozilla-beta- → approval-mozilla-beta?
Flags: needinfo?(lhenry)
status-firefox53: --- → affected
(Assignee)

Comment 12

2 months ago
I should note that the bugs listed in Comment 8 as "List of other uplifts needed for the feature/fix" were required for uplift to Firefox 52. They are already in Firefox 53, so they do not need to be uplifted to it.
Comment on attachment 8836881 [details]
Bug 1338287 - Make nsIDocument::DocumentFlashClassification accessible from privileged JS

Last bit of cleanup before we ship the Flash study in 53.
Attachment #8836881 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
[Tracking Requested - why for this release]:
tracking-firefox53: --- → +

Comment 15

2 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/df36e8af5a74
status-firefox53: affected → fixed
You need to log in before you can comment on or make changes to this bug.