Closed
Bug 1319571
Opened 7 years ago
Closed 7 years ago
Change the output format nsUrlClassifierDBService::ClassifyLocalWithTables from comma separated string to array
Categories
(Toolkit :: Safe Browsing, defect)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
mozilla53
People
(Reporter: bytesized, Assigned: bytesized)
References
Details
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
francois
:
review+
gchang
:
approval-mozilla-aurora-
jcristau
:
approval-mozilla-beta-
|
Details |
Currently, the output of nsUrlClassifierDBService::ClassifyLocalWithTables is converted from an array to a comma separated list. This is difficult to consume without converting it back to an array.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ksteuber
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8813438 -
Flags: review?(francois)
Assignee | ||
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=43824bc81938a89f739c5e7f12f032d4285b16b2
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8813438 [details] Bug 1319571 - Change the output format of nsUrlClassifierDBService::ClassifyLocalWithTables from comma separated string to an array of strings https://reviewboard.mozilla.org/r/94830/#review95126
Attachment #8813438 -
Flags: review?(francois) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 4•7 years ago
|
||
It looks like there is another consumer of this function now. I need to change the patch to fix that consumer as well.
Keywords: checkin-needed
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Comment 5•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=915731292405
Assignee | ||
Comment 6•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=82714be30cf6
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8813438 -
Flags: review+ → review?(francois)
Assignee | ||
Comment 8•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8bf8094940d
Comment hidden (mozreview-request) |
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8813438 [details] Bug 1319571 - Change the output format of nsUrlClassifierDBService::ClassifyLocalWithTables from comma separated string to an array of strings https://reviewboard.mozilla.org/r/94830/#review96588 ::: netwerk/base/nsIURIClassifier.idl:72 (Diff revision 3) > * containing the given tables. This does not make network requests. > - * The result is a comma-separated string of tables that match. > + * The result is an array of table names that match. > + */ > + [noscript] StringArrayRef classifyLocalWithTables(in nsIURI aURI, in ACString aTables); > + /** > + * Same as above, but returns a comma separated list of table names. Maybe we should add a comment saying that it's just for tests: * This is an internal interface used only for testing purposes.
Attachment #8813438 -
Flags: review?(francois) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 12•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/673b0b18d599 Change the output format of nsUrlClassifierDBService::ClassifyLocalWithTables from comma separated string to an array of strings r=francois
Keywords: checkin-needed
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/673b0b18d599
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Assignee | ||
Comment 14•7 years ago
|
||
Comment on attachment 8813438 [details] Bug 1319571 - Change the output format of nsUrlClassifierDBService::ClassifyLocalWithTables from comma separated string to an array of strings Approval Request Comment [Feature/Bug causing the regression]: This feature is needed for the Shield study to be run on Release 52 (bug 1335232), which we'll use to study the effect of making flash click-to-play by default. [User impact if declined]: Can't run the study as intended [Is this code covered by automated tests?]: Yes [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: Not for this feature independently. We'll do QE on the study as a whole to make sure all pieces work as expected [List of other uplifts needed for the feature/fix]: Bug 1318768, Bug 1323220, Bug 1325255, Bug 1322204, Bug 1325651, Bug 1319571, Bug 1321377, Bug 1307604, Bug 1323064, Bug 1335549, Bug 1333303, Bug 1333483, Bug 1336714, Bug 1338287 [Is the change risky?]: Minimal risk [Why is the change risky/not risky?]: Changes an function definition with very few consumers. [String changes made/needed]: none
Attachment #8813438 -
Flags: approval-mozilla-beta?
Attachment #8813438 -
Flags: approval-mozilla-aurora?
Updated•7 years ago
|
status-firefox52:
--- → affected
Comment 15•7 years ago
|
||
Comment on attachment 8813438 [details] Bug 1319571 - Change the output format of nsUrlClassifierDBService::ClassifyLocalWithTables from comma separated string to an array of strings It's been in FF53 already. Aurora53-.
Attachment #8813438 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Comment 16•7 years ago
|
||
Comment on attachment 8813438 [details] Bug 1319571 - Change the output format of nsUrlClassifierDBService::ClassifyLocalWithTables from comma separated string to an array of strings this was deemed too risky for beta
Attachment #8813438 -
Flags: approval-mozilla-beta? → approval-mozilla-beta-
You need to log in
before you can comment on or make changes to this bug.
Description
•