1339920 - [Wayland] menus can be (partially) displayed outside of screen

Status: RESOLVED DUPLICATE of bug 1423598

(Core :: Widget: Gtk, defect, P2)

Description

[Christian Stadelmann]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20170126153103

Steps to reproduce:

1. installed Nightly builds for wayland, 52.0a1, BuildID 20170215004354, downloaded from https://firefox-flatpak.mojefedora.cz/ (created with build scripts from https://github.com/xhorak/firefox-devedition-flatpak)
2. ran firefox nightly
3. opened a menu on the "Pocket" button


Actual results:

The menu was partially displayed outside the screen (see screenshot)


Expected results:

Display menu on screen completely. Works fine with stable 51.0.1 builds for X11 (running on wayland through XWayland)

Comment 1

[Christian Stadelmann]

Attachment: Screenshot showing a menu partially drawn outside firefox window

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Should not be tracked - it affects my private wayland builds for Bug 635134 and not mozilla builds which are missing wayland support.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Anway, already fixed at my personal repo by patches for better popup handling.

Comment 4

[Christian Stadelmann]

This issue is still present on Fedora's wayland-enabled builds (firefox-60.0.1-5.fc28.x86_64).

Steps to reproduce:
1. open firefox wayland
2. move window to right screen edge
3. near right screen edge, open a context menu

What happens:
Menu is partially displayed outside of screen

What should happen:
Wrap menu around and show it left of the mouse button, not right.

Comment 5

[Christian Stadelmann]

Same issue on nightly 62.0a1 (2018-05-26).

Comment 6

[Tony Houghton]

I vaguely remember having a similar problem, either with menus or tooltips <https://bugzilla.mozilla.org/show_bug.cgi?id=1466386>. Might have been with Thunderbird, and probably pre-Wayland in my case. But I think it was due to hidpi scaling. Have you checked whether that affects these two bugs?

Comment 7

[Christian Stadelmann]

(In reply to Tony Houghton from comment #6)
> I vaguely remember having a similar problem, either with menus or tooltips
> <https://bugzilla.mozilla.org/show_bug.cgi?id=1466386>. Might have been with
> Thunderbird, and probably pre-Wayland in my case. But I think it was due to
> hidpi scaling. Have you checked whether that affects these two bugs?

I don't use a hidpi monitor. These issues are present on "normal" hardware.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Yes, it's because Gtk+ does not export the popup placement code for Wayland so we can't use that.

Comment 9

[Dima Ryazanov]

Btw, Gtk 3.24 added a gdk_window_move_to_rect function; it should make it possible to fix the positioning. (That's what Gtk popup menus use internally.)

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Yes, unfortunately Gtk 3.24 is not available yet AFAIK, at least Fedora 28 still has 3.22. We may wait until Fedora 28 comes out or it's Beta at least.

Comment 11

[Christian Stadelmann]

This issue is still present.

(In reply to Martin Stránský [:stransky] from comment #10)
> Yes, unfortunately Gtk 3.24 is not available yet AFAIK, at least Fedora 28
> still has 3.22. We may wait until Fedora 28 comes out or it's Beta at least.

Gtk+ 3.24 is out now and shipped in Fedora 29.

Comment 12

[Bojan Smojver]

Still a problem with FF 64.0-4 on F29. I have bookmarks menu icon in the toolbar on the right hand side (where library usually sits) and all the second level menus are displayed outside the screen to the right. FF on X11 displays second level menus to the left, because there is obviously not enough space to the right.

Comment 13

[Bojan Smojver]

Ditto firefox-65.0-1.fc29.x86_64.

Comment 14

[Christian Stadelmann]

https://bugzilla.mozilla.org/show_bug.cgi?id=1423598 is related.

Comment 15

[Jonny Mako]

https://bugzilla.mozilla.org/show_bug.cgi?id=1528021

Comment 16

[Mattias]

This is a everyday problem for switching between spell checking languages. So, this is probably going to be quite an issue to all non native english speaking population. If the entry field is not at the absolute top of the screen, there is a big chance that the language you are trying to use is outside the screen.
After using firefox wayland as my primary browser for the last couple of months, this is the only issue I have. (So on the good side, great job!)

Comment 17

[Martin Stránský [:stransky] (ni? me)]

Closing as dupe of Bug 1423598 as the work takes place there.