The loading indicator for Compact Theme Light does not have enough contrast with the selected tab background

RESOLVED FIXED in Firefox 53

Status

()

defect
P2
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jaws, Assigned: jryans)

Tracking

Trunk
Firefox 54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53+ fixed, firefox54+ fixed)

Details

Attachments

(3 attachments)

Using the Compact Light theme:

On Windows we show a blue loading indicator against a blue selected tab background.

We should use a different color loading indicator here, because the blue-on-blue doesn't provide enough contrast.

Tested on Windows 10 Firefox Nightly 54.0a1 (2017-02-10) (64-bit).
Duplicate of this bug: 1327400
[Tracking Requested - why for this release]:
We'll be shipping this with 53, and we shouldn't ship this with the barely-visible spinners.


Stephen, do you have a replacement asset we could use here?
Flags: needinfo?(shorlander)
Priority: -- → P2
Tracking this since we're shipping the feature with 53 and want the loading indicator to be clearly visible.
Posted image loading-inverted.png
Here is a white version of the loading indicator.
Flags: needinfo?(shorlander)
Assignee: nobody → jryans
Status: NEW → ASSIGNED
These seems like an improvement to me for both Compact Light and Dark, so I'll try it for both.
Comment on attachment 8841695 [details]
Bug 1340620 - Use inverted loading icons with Compact Theme.

https://reviewboard.mozilla.org/r/115838/#review117206

r=me . Given Stephen supplied the image I assume that implies ui-r+ :-)
Attachment #8841695 - Flags: review?(gijskruitbosch+bugs) → review+
Drive-by question, did you check that it was png-crushed?
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #10)
> Drive-by question, did you check that it was png-crushed?

It's apng, so I don't know which compression tools deal with that...
(In reply to :Gijs from comment #11)
> (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #10)
> > Drive-by question, did you check that it was png-crushed?
> 
> It's apng, so I don't know which compression tools deal with that...

I compressed it. You have to compress the individual frames before you create the APNG.
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/62736acb85d0
Use inverted loading icons with Compact Theme. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/62736acb85d0
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment on attachment 8841695 [details]
Bug 1340620 - Use inverted loading icons with Compact Theme.

Approval Request Comment
[Feature/Bug causing the regression]: Compact Theme shipping in 53 have a few edges cases we want to fix up
[User impact if declined]: If declined, loading icon will be hard to see with Compact Themes
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Low, icon only for non-default theme
[String changes made/needed]: None
Attachment #8841695 - Flags: approval-mozilla-aurora?
Comment on attachment 8841695 [details]
Bug 1340620 - Use inverted loading icons with Compact Theme.

Minor fix for compact themes, let's take this for 53.
Attachment #8841695 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.