1340620 - The loading indicator for Compact Theme Light does not have enough contrast with the selected tab background

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Using the Compact Light theme:

On Windows we show a blue loading indicator against a blue selected tab background.

We should use a different color loading indicator here, because the blue-on-blue doesn't provide enough contrast.

Tested on Windows 10 Firefox Nightly 54.0a1 (2017-02-10) (64-bit).

Comment 2

[:Gijs (out for now; he/him)]

[Tracking Requested - why for this release]:
We'll be shipping this with 53, and we shouldn't ship this with the barely-visible spinners.


Stephen, do you have a replacement asset we could use here?

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking this since we're shipping the feature with 53 and want the loading indicator to be clearly visible.

Comment 4

[Stephen Horlander [:shorlander]]

Attachment: loading-inverted.png

Here is a white version of the loading indicator.

Comment 5

[Stephen Horlander [:shorlander]]

Attachment: [e-mail]

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

These seems like an improvement to me for both Compact Light and Dark, so I'll try it for both.

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1340620 - Use inverted loading icons with Compact Theme.

For selected tabs, the Compact Themes use bright blue tab background colors,
which makes the blue loading icon hard to see.  For this state, use a white
loading icon instead.

Review commit: https://reviewboard.mozilla.org/r/115838/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/115838/

Comment 8

[:Gijs (out for now; he/him)]

Comment on attachment 8841695 [details]
Bug 1340620 - Use inverted loading icons with Compact Theme.

https://reviewboard.mozilla.org/r/115838/#review117206

r=me . Given Stephen supplied the image I assume that implies ui-r+ :-)

Comment 9

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=367be05113181cdb57f99d9971dd671c85fd9093

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Drive-by question, did you check that it was png-crushed?

Comment 11

[:Gijs (out for now; he/him)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #10)
> Drive-by question, did you check that it was png-crushed?

It's apng, so I don't know which compression tools deal with that...

Comment 12

[Stephen Horlander [:shorlander]]

(In reply to :Gijs from comment #11)
> (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #10)
> > Drive-by question, did you check that it was png-crushed?
> 
> It's apng, so I don't know which compression tools deal with that...

I compressed it. You have to compress the individual frames before you create the APNG.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62736acb85d0
Use inverted loading icons with Compact Theme. r=Gijs

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/62736acb85d0

Comment 15

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8841695 [details]
Bug 1340620 - Use inverted loading icons with Compact Theme.

Approval Request Comment
[Feature/Bug causing the regression]: Compact Theme shipping in 53 have a few edges cases we want to fix up
[User impact if declined]: If declined, loading icon will be hard to see with Compact Themes
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Low, icon only for non-default theme
[String changes made/needed]: None

Comment 16

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8841695 [details]
Bug 1340620 - Use inverted loading icons with Compact Theme.

Minor fix for compact themes, let's take this for 53.

Comment 17

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c565a618690d15933c1cd3a2830bc87ca8d21e7f