Closed
Bug 1341338
Opened 7 years ago
Closed 7 years ago
feedType is undefined in FeedConverter#handleResult
Categories
(Firefox Graveyard :: RSS Discovery and Preview, defect)
Tracking
(firefox51 wontfix, firefox52 fixed, firefox-esr52 fixed, firefox53 fixed, firefox54 fixed)
RESOLVED
FIXED
Firefox 54
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Keywords: regression)
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
jaws
:
review+
jcristau
:
approval-mozilla-aurora+
jcristau
:
approval-mozilla-beta+
|
Details |
In working on no-undef eslint issues, I've discovered there's an issue in FeedConverter#handleResult. `feedType` is undefined, it should be `feed.type` from looking at the code around it. This was introduced by bug 1109714. I'm attaching a patch for it, that will also resolve a couple of other no-undef issues as well (these are comments to prompt eslint to know the globals properly).
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
Bug 1109714 landed in Firefox 46. Marking status flags accordingly.
status-firefox51:
--- → wontfix
status-firefox52:
--- → affected
status-firefox53:
--- → affected
status-firefox54:
--- → affected
Version: unspecified → 46 Branch
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8839526 [details] Bug 1341338 - feedType is undefined in FeedConverter#handleResult. https://reviewboard.mozilla.org/r/114146/#review115620 It would be nice if we had a test that hit this FeedConverter codepath. Maybe that could be a good-first-bug?
Attachment #8839526 -
Flags: review?(jaws) → review+
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a437b95a0de4 feedType is undefined in FeedConverter#handleResult. r=jaws
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a437b95a0de4
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Comment 6•7 years ago
|
||
Please request Aurora/Beta approval on this when you get a chance.
Flags: needinfo?(standard8)
Assignee | ||
Comment 7•7 years ago
|
||
Comment on attachment 8839526 [details] Bug 1341338 - feedType is undefined in FeedConverter#handleResult. Approval Request Comment [Feature/Bug causing the regression]: Bug 1109714 [User impact if declined]: If something other than our default feed viewer was the default action when encountering feeds, and a user loaded something with a feed mimetype, they'd hit it, and it would likely be handled incorrectly. [Is this code covered by automated tests?]: Not currently, see bug 1341401. [Has the fix been verified in Nightly?]: Picked up by ESLint no-undef that is soon to be enabled. I don't think this has been verified yet. [Needs manual test from QE? If yes, steps to reproduce]: See the user impact. [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Low risk, small typo fix. [String changes made/needed]: None
Flags: needinfo?(standard8)
Attachment #8839526 -
Flags: approval-mozilla-beta?
Attachment #8839526 -
Flags: approval-mozilla-aurora?
Comment 8•7 years ago
|
||
Comment on attachment 8839526 [details] Bug 1341338 - feedType is undefined in FeedConverter#handleResult. typo fix found by eslint, aurora53+, beta52+
Attachment #8839526 -
Flags: approval-mozilla-beta?
Attachment #8839526 -
Flags: approval-mozilla-beta+
Attachment #8839526 -
Flags: approval-mozilla-aurora?
Attachment #8839526 -
Flags: approval-mozilla-aurora+
Comment 9•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/432f86adc83e
Comment 10•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/08169479d28f
Comment 11•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-esr52/rev/08169479d28f
status-firefox-esr52:
--- → fixed
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•