feedType is undefined in FeedConverter#handleResult

RESOLVED FIXED in Firefox 52

Status

defect
RESOLVED FIXED
2 years ago
7 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

({regression})

46 Branch
Firefox 54
Dependency tree / graph

Firefox Tracking Flags

(firefox51 wontfix, firefox52 fixed, firefox-esr52 fixed, firefox53 fixed, firefox54 fixed)

Details

Attachments

(1 attachment)

In working on no-undef eslint issues, I've discovered there's an issue in FeedConverter#handleResult. `feedType` is undefined, it should be `feed.type` from looking at the code around it.

This was introduced by bug 1109714.

I'm attaching a patch for it, that will also resolve a couple of other no-undef issues as well (these are comments to prompt eslint to know the globals properly).
Bug 1109714 landed in Firefox 46. Marking status flags accordingly.
Version: unspecified → 46 Branch
Comment on attachment 8839526 [details]
Bug 1341338 - feedType is undefined in FeedConverter#handleResult.

https://reviewboard.mozilla.org/r/114146/#review115620

It would be nice if we had a test that hit this FeedConverter codepath. Maybe that could be a good-first-bug?
Attachment #8839526 - Flags: review?(jaws) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a437b95a0de4
feedType is undefined in FeedConverter#handleResult. r=jaws
Blocks: 1341401
https://hg.mozilla.org/mozilla-central/rev/a437b95a0de4
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Please request Aurora/Beta approval on this when you get a chance.
Flags: needinfo?(standard8)
Comment on attachment 8839526 [details]
Bug 1341338 - feedType is undefined in FeedConverter#handleResult.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1109714
[User impact if declined]: If something other than our default feed viewer was the default action when encountering feeds, and a user loaded something with a feed mimetype, they'd hit it, and it would likely be handled incorrectly.
[Is this code covered by automated tests?]: Not currently, see bug 1341401.
[Has the fix been verified in Nightly?]: Picked up by ESLint no-undef that is soon to be enabled. I don't think this has been verified yet.
[Needs manual test from QE? If yes, steps to reproduce]: See the user impact.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Low risk, small typo fix.
[String changes made/needed]: None
Flags: needinfo?(standard8)
Attachment #8839526 - Flags: approval-mozilla-beta?
Attachment #8839526 - Flags: approval-mozilla-aurora?
Comment on attachment 8839526 [details]
Bug 1341338 - feedType is undefined in FeedConverter#handleResult.

typo fix found by eslint, aurora53+, beta52+
Attachment #8839526 - Flags: approval-mozilla-beta?
Attachment #8839526 - Flags: approval-mozilla-beta+
Attachment #8839526 - Flags: approval-mozilla-aurora?
Attachment #8839526 - Flags: approval-mozilla-aurora+
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.