Closed Bug 1341338 Opened 3 years ago Closed 3 years ago
Type is undefined in Feed Converter#handle Result
In working on no-undef eslint issues, I've discovered there's an issue in FeedConverter#handleResult. `feedType` is undefined, it should be `feed.type` from looking at the code around it. This was introduced by bug 1109714. I'm attaching a patch for it, that will also resolve a couple of other no-undef issues as well (these are comments to prompt eslint to know the globals properly).
Bug 1109714 landed in Firefox 46. Marking status flags accordingly.
Comment on attachment 8839526 [details] Bug 1341338 - feedType is undefined in FeedConverter#handleResult. https://reviewboard.mozilla.org/r/114146/#review115620 It would be nice if we had a test that hit this FeedConverter codepath. Maybe that could be a good-first-bug?
Attachment #8839526 - Flags: review?(jaws) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/a437b95a0de4 feedType is undefined in FeedConverter#handleResult. r=jaws
Please request Aurora/Beta approval on this when you get a chance.
Comment on attachment 8839526 [details] Bug 1341338 - feedType is undefined in FeedConverter#handleResult. Approval Request Comment [Feature/Bug causing the regression]: Bug 1109714 [User impact if declined]: If something other than our default feed viewer was the default action when encountering feeds, and a user loaded something with a feed mimetype, they'd hit it, and it would likely be handled incorrectly. [Is this code covered by automated tests?]: Not currently, see bug 1341401. [Has the fix been verified in Nightly?]: Picked up by ESLint no-undef that is soon to be enabled. I don't think this has been verified yet. [Needs manual test from QE? If yes, steps to reproduce]: See the user impact. [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Low risk, small typo fix. [String changes made/needed]: None
Comment on attachment 8839526 [details] Bug 1341338 - feedType is undefined in FeedConverter#handleResult. typo fix found by eslint, aurora53+, beta52+
You need to log in before you can comment on or make changes to this bug.