Closed Bug 1342011 Opened 9 years ago Closed 9 years ago

Stop setting background: transparent and border: none on button.button-link

Categories

(Toolkit :: Themes, defect)

Product:
Toolkit
Component:
Themes
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID
Tracking Flags:
Tracking Status
firefox54 --- affected

People

(Reporter: dao, Unassigned, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [good first bug][lang=css])

Bug 1334429 removed the fallback border and background styling from button.css, so now we can stop removing the border and background here: https://hg.mozilla.org/mozilla-central/annotate/32dcdde1fc64fc39a9065dc4218265dbc727673f/toolkit/themes/shared/extensions/extensions.inc.css#l1001
(In reply to Dão Gottwald [:dao] from comment #0) > Bug 1334429 removed the fallback border and background styling from > button.css, so now we can stop removing the border and background here: > https://hg.mozilla.org/mozilla-central/annotate/ > 32dcdde1fc64fc39a9065dc4218265dbc727673f/toolkit/themes/shared/extensions/ > extensions.inc.css#l1001 I'd like to work on this as my first bug.
Please go ahead. Have you built Firefox yet?
Assignee: nobody → tonyhjlee
Oops, I misspoke, background: transparent and border: none are still needed to override this: https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css#182 Tony, I just filed bug 1343163 which you could work on instead.
Assignee: tonyhjlee → nobody
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
(In reply to Dão Gottwald [:dao] from comment #3) > Oops, I misspoke, background: transparent and border: none are still needed > to override this: > https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/shared/in- > content/common.inc.css#182 > > Tony, I just filed bug 1343163 which you could work on instead. I'll take that one and I do already have Firefox built.
You need to log in before you can comment on or make changes to this bug.