1334429 - Remove fallback styling from button.css

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Dão Gottwald [:dao]]

See bug 1288747 comment 10 and bug 756759 for some context and reasoning.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1334429 - Remove fallback styling from button.css.

Review commit: https://reviewboard.mozilla.org/r/107736/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107736/

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8831084 [details]
Bug 1334429 - Remove fallback styling from button.css.

https://reviewboard.mozilla.org/r/107736/#review108928

Honestly it's hard to guess if this may cause regressions or not. If we're sure all our tier-1 and 2 have a properly implemented native look, I don't see a reason to block it.
But let's keep eyes open in the next days for eventual unexpected reports.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54a7d6b48619
Remove fallback styling from button.css. r=mak

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/54a7d6b48619

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

kudos for a talos improvement:
== Change summary for alert #4958 (as of January 27 2017 17:21 UTC) ==

Improvements:

  2%  cart summary windows8-64 pgo     25.64 -> 25.07

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=4958