1342141 - Use NP_EMBED as the mode for all plugins instead of NP_FULL

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P2)

Description

[Benjamin Smedberg]

When Flash is initialized as a full-page plugin, we pass it NP_FULL as the "mode" parameter in NPAPI. This is correct per specification, but it means that Flash doesn't obey parameters such as wmode="opaque" in this case, which is causing the fix for bug 1337781 to be partially ineffective, and causing errors landing bug 1338172.

Adobe doesn't think that passing NP_EMBED instead of NP_FULL will cause problems, and will allow us to unblock the remaining fixes.

This patch does this unconditionally for all platforms; I don't know if we have any good examples of "real" full-page Flash (most full-page plugin usage were Acrobat which is no longer supported); I have been testing personally with http://benjamin.smedbergs.us/tests/ctptests/example3.swf

Comment 1

[Benjamin Smedberg]

Attachment: Bug 1342141 - Use NP_EMBED as the mode for all plugins, whether they are full-page or not,

Review commit: https://reviewboard.mozilla.org/r/114982/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/114982/

Comment 2

[Benjamin Smedberg]

Attachment: Bug 1342141 part B - The test plugin will use name="plugin" as an indicator of fullpage, rather than NP_FULL, to make test_fullpage.html green,

Review commit: https://reviewboard.mozilla.org/r/115002/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/115002/

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 8840503 [details]
Bug 1342141 - Use NP_EMBED as the mode for all plugins, whether they are full-page or not,

https://reviewboard.mozilla.org/r/114982/#review116532

I can't think of any full page swf content out there. When I'm testing, but that's it.

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 8840503 [details]
Bug 1342141 - Use NP_EMBED as the mode for all plugins, whether they are full-page or not,

https://reviewboard.mozilla.org/r/114982/#review116534

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 8840516 [details]
Bug 1342141 part B - The test plugin will use name="plugin" as an indicator of fullpage, rather than NP_FULL, to make test_fullpage.html green,

https://reviewboard.mozilla.org/r/115002/#review116538

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5de5b954317
part A - The test plugin will use name="plugin" as an indicator of fullpage, rather than NP_FULL, to make test_fullpage.html green, r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/f065c4ec4ac6
part B - Use NP_EMBED as the mode for all plugins, whether they are full-page or not, r=jimm

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e5de5b954317
https://hg.mozilla.org/mozilla-central/rev/f065c4ec4ac6