1343979 - Add webrender support for ButtonBorderBackground

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Is there a test that fails, or do we need to create one?

Comment 2

[Mason Chang [Inactive] [:mchang]]

(In reply to Milan Sreckovic [:milan] from comment #1)
> Is there a test that fails, or do we need to create one?

I think there are already reftests, it's just support to start rendering more things in WR from bug 1342343.

Comment 3

[Mason Chang [Inactive] [:mchang]]

Attachment: Add support for nsDisplayButtonBorder

Essentially breaks down nsDisplayButtonBorder into an inset box shadow + paint of a border [1]. Since lots of code for borders was done in the WebRenderBorderLayer::renderLayer / nsDisplayBoxShadowInner::CreateWebRenderCommands, I had to extract those methods out into public methods so nsDisplayButtonBorder could call into those methods. I still need to deal with the paint flags which I'll do in a follow up. 

[1] http://searchfox.org/mozilla-central/source/layout/forms/nsButtonFrameRenderer.cpp#324

Comment 4

[Mason Chang [Inactive] [:mchang]]

Depending on the outcome of https://bugzilla.mozilla.org/show_bug.cgi?id=1343450#c5, I can delete WebRenderBorderLayer in a follow up patch.

Comment 5

[Ethan Lin[:ethlin]]

Comment on attachment 8843446 [details] [diff] [review]
Add support for nsDisplayButtonBorder

Review of attachment 8843446 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/wr/WebRenderBorderLayer.cpp
@@ +82,4 @@
>  
>    Rect overflow(0, 0, relBounds.width, relBounds.height);
>  
> +  if (gfxPrefs::LayersDump() && aLayer->IsBorderLayer()) {

It's a little bit weird to just dump data for border layer, especially after deleting WebRenderBorderLayer. Maybe we can just remove this code or pass the display item name for dumping.

Comment 6

[Mason Chang [Inactive] [:mchang]]

(In reply to Ethan Lin[:ethlin] from comment #5)
> Comment on attachment 8843446 [details] [diff] [review]
> Add support for nsDisplayButtonBorder
> 
> Review of attachment 8843446 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/layers/wr/WebRenderBorderLayer.cpp
> @@ +82,4 @@
> >  
> >    Rect overflow(0, 0, relBounds.width, relBounds.height);
> >  
> > +  if (gfxPrefs::LayersDump() && aLayer->IsBorderLayer()) {
> 
> It's a little bit weird to just dump data for border layer, especially after
> deleting WebRenderBorderLayer. Maybe we can just remove this code or pass
> the display item name for dumping.

I'm going to fix this in general in a follow up bug.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/683fbabdfd8f
Add webrender support for ButtonBorderBackground. r=ethlin

Comment 8

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/683fbabdfd8f