Closed Bug 1344622 Opened 3 years ago Closed 3 years ago

Add webrender support for nsDisplayButtonForeground

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55

People

(Reporter: ethlin, Assigned: ethlin)

References

Details

Attachments

(2 files)

For the first round DisplayItem Conversion, we should add WR support for nsDisplayButtonForeground.
Depends on: 1343979
There will be some duplicated code when we create WR commands for border. So let border render create those commands.
Attachment #8844392 - Flags: review?(matt.woodrow)
Attachment #8844395 - Flags: review?(matt.woodrow)
Attachment #8844392 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8844395 [details] [diff] [review]
Add webrender support for nsDisplayButtonForeground

Review of attachment 8844395 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/forms/nsButtonFrameRenderer.cpp
@@ +270,5 @@
> +  if (gfxPrefs::LayersAllowButtonForegroundLayers()) {
> +    nsPresContext *presContext = mFrame->PresContext();
> +    const nsStyleDisplay *disp = mFrame->StyleDisplay();
> +    if (!mFrame->IsThemed(disp) ||
> +      !presContext->GetTheme()->ThemeDrawsFocusForWidget(disp->mAppearance)) {

Align this ! with the ! on the previous line.
Attachment #8844395 - Flags: review?(matt.woodrow) → review+
(In reply to Matt Woodrow (:mattwoodrow) from comment #3)
> Comment on attachment 8844395 [details] [diff] [review]
> Add webrender support for nsDisplayButtonForeground
> 
> Review of attachment 8844395 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: layout/forms/nsButtonFrameRenderer.cpp
> @@ +270,5 @@
> > +  if (gfxPrefs::LayersAllowButtonForegroundLayers()) {
> > +    nsPresContext *presContext = mFrame->PresContext();
> > +    const nsStyleDisplay *disp = mFrame->StyleDisplay();
> > +    if (!mFrame->IsThemed(disp) ||
> > +      !presContext->GetTheme()->ThemeDrawsFocusForWidget(disp->mAppearance)) {
> 
> Align this ! with the ! on the previous line.

Okay! I will fix it.
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/4c6b9024e6ec
Part1. Create WR commands in BorderRenderer. r=mattwoodrow
https://hg.mozilla.org/projects/graphics/rev/5a5fdbdd7892
Part2. Add webrender support for nsDisplayButtonForeground. r=mattwoodrow
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.