1344622 - Add webrender support for nsDisplayButtonForeground

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Ethan Lin[:ethlin]]

For the first round DisplayItem Conversion, we should add WR support for nsDisplayButtonForeground.

Comment 1

[Ethan Lin[:ethlin]]

Attachment: Part1. Create WR commands in BorderRenderer

There will be some duplicated code when we create WR commands for border. So let border render create those commands.

Comment 2

[Ethan Lin[:ethlin]]

Attachment: Add webrender support for nsDisplayButtonForeground

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8844395 [details] [diff] [review]
Add webrender support for nsDisplayButtonForeground

Review of attachment 8844395 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/forms/nsButtonFrameRenderer.cpp
@@ +270,5 @@
> +  if (gfxPrefs::LayersAllowButtonForegroundLayers()) {
> +    nsPresContext *presContext = mFrame->PresContext();
> +    const nsStyleDisplay *disp = mFrame->StyleDisplay();
> +    if (!mFrame->IsThemed(disp) ||
> +      !presContext->GetTheme()->ThemeDrawsFocusForWidget(disp->mAppearance)) {

Align this ! with the ! on the previous line.

Comment 4

[Ethan Lin[:ethlin]]

(In reply to Matt Woodrow (:mattwoodrow) from comment #3)
> Comment on attachment 8844395 [details] [diff] [review]
> Add webrender support for nsDisplayButtonForeground
> 
> Review of attachment 8844395 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: layout/forms/nsButtonFrameRenderer.cpp
> @@ +270,5 @@
> > +  if (gfxPrefs::LayersAllowButtonForegroundLayers()) {
> > +    nsPresContext *presContext = mFrame->PresContext();
> > +    const nsStyleDisplay *disp = mFrame->StyleDisplay();
> > +    if (!mFrame->IsThemed(disp) ||
> > +      !presContext->GetTheme()->ThemeDrawsFocusForWidget(disp->mAppearance)) {
> 
> Align this ! with the ! on the previous line.

Okay! I will fix it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/4c6b9024e6ec
Part1. Create WR commands in BorderRenderer. r=mattwoodrow
https://hg.mozilla.org/projects/graphics/rev/5a5fdbdd7892
Part2. Add webrender support for nsDisplayButtonForeground. r=mattwoodrow

Comment 6

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/4c6b9024e6ec
https://hg.mozilla.org/mozilla-central/rev/5a5fdbdd7892