Closed
Bug 1344622
Opened 7 years ago
Closed 7 years ago
Add webrender support for nsDisplayButtonForeground
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla55
People
(Reporter: ethlin, Assigned: ethlin)
References
Details
Attachments
(2 files)
6.65 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
10.60 KB,
patch
|
mattwoodrow
:
review+
|
Details | Diff | Splinter Review |
For the first round DisplayItem Conversion, we should add WR support for nsDisplayButtonForeground.
Assignee | ||
Comment 1•7 years ago
|
||
There will be some duplicated code when we create WR commands for border. So let border render create those commands.
Attachment #8844392 -
Flags: review?(matt.woodrow)
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8844395 -
Flags: review?(matt.woodrow)
Updated•7 years ago
|
Attachment #8844392 -
Flags: review?(matt.woodrow) → review+
Comment 3•7 years ago
|
||
Comment on attachment 8844395 [details] [diff] [review] Add webrender support for nsDisplayButtonForeground Review of attachment 8844395 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/forms/nsButtonFrameRenderer.cpp @@ +270,5 @@ > + if (gfxPrefs::LayersAllowButtonForegroundLayers()) { > + nsPresContext *presContext = mFrame->PresContext(); > + const nsStyleDisplay *disp = mFrame->StyleDisplay(); > + if (!mFrame->IsThemed(disp) || > + !presContext->GetTheme()->ThemeDrawsFocusForWidget(disp->mAppearance)) { Align this ! with the ! on the previous line.
Attachment #8844395 -
Flags: review?(matt.woodrow) → review+
Assignee | ||
Comment 4•7 years ago
|
||
(In reply to Matt Woodrow (:mattwoodrow) from comment #3) > Comment on attachment 8844395 [details] [diff] [review] > Add webrender support for nsDisplayButtonForeground > > Review of attachment 8844395 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: layout/forms/nsButtonFrameRenderer.cpp > @@ +270,5 @@ > > + if (gfxPrefs::LayersAllowButtonForegroundLayers()) { > > + nsPresContext *presContext = mFrame->PresContext(); > > + const nsStyleDisplay *disp = mFrame->StyleDisplay(); > > + if (!mFrame->IsThemed(disp) || > > + !presContext->GetTheme()->ThemeDrawsFocusForWidget(disp->mAppearance)) { > > Align this ! with the ! on the previous line. Okay! I will fix it.
Pushed by ethlin@mozilla.com: https://hg.mozilla.org/projects/graphics/rev/4c6b9024e6ec Part1. Create WR commands in BorderRenderer. r=mattwoodrow https://hg.mozilla.org/projects/graphics/rev/5a5fdbdd7892 Part2. Add webrender support for nsDisplayButtonForeground. r=mattwoodrow
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment 6•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4c6b9024e6ec https://hg.mozilla.org/mozilla-central/rev/5a5fdbdd7892
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•