[tcmigration] uptake monitoring script should handle Fennec releases as well

RESOLVED FIXED

Status

enhancement
P3
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: mtabara, Assigned: mtabara)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

More specifically, [1] needs to be altered a bit to handle the absence of partials, such as a Fennec release is. More into details, I need to:

a) make sure I can skip defining "partial_versions" in its BBB releasetasks task definition as there are no partials within Fennec.

b) within the script[1] itself, I need to alted [2] to handle empty partials and also condition the run of "partials" block from mozharness configs via [3]

Right now the script would fail because there is no "partials" whithin configs[4]

c) make sure the BB itself knows how to handle the beta vs release for Fennec under [5] and [6].

[1]: https://hg.mozilla.org/mozilla-central/file/tip/testing/mozharness/scripts/release/uptake_monitoring.py
[2]: https://hg.mozilla.org/mozilla-central/file/tip/testing/mozharness/scripts/release/uptake_monitoring.py#l80
[3]: https://hg.mozilla.org/mozilla-central/file/tip/testing/mozharness/scripts/release/uptake_monitoring.py#l139
[4]: https://hg.mozilla.org/mozilla-central/file/tip/testing/mozharness/configs/releases/bouncer_fennec.py
[5]: http://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/config.py
[6]: https://hg.mozilla.org/build/buildbotcustom/file/tip/process/release.py#l1951
Assignee

Updated

2 years ago
No longer blocks: 1343990
See Also: → 1343990

Comment 5

2 years ago
mozreview-review
Comment on attachment 8845517 [details]
Bug 1344202 - Add bb-configs dedicated uptake monitoring platforms.

https://reviewboard.mozilla.org/r/118654/#review120626
Attachment #8845517 - Flags: review?(rail) → review+

Comment 6

2 years ago
mozreview-review
Comment on attachment 8845520 [details]
Bug 1344202 - uptake monitoring platforms now have dedicated variable.

https://reviewboard.mozilla.org/r/118658/#review120630
Attachment #8845520 - Flags: review?(rail) → review+

Comment 7

2 years ago
mozreview-review
Comment on attachment 8845521 [details]
Bug 1344202 - uptake monitoring better handling absence of partials.  a=release DONTBUILD

https://reviewboard.mozilla.org/r/118662/#review120634
Attachment #8845521 - Flags: review?(rail) → review+

Updated

2 years ago
Attachment #8845515 - Flags: review?(rail) → review+
Comment on attachment 8845517 [details]
Bug 1344202 - Add bb-configs dedicated uptake monitoring platforms.

https://hg.mozilla.org/build/buildbot-configs/rev/8b3fffe1e92c
Attachment #8845517 - Flags: checked-in+

Comment 10

2 years ago
Pushed by mtabara@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0cd7b0a6547d
uptake monitoring better handling absence of partials. r=rail a=release DONTBUILD
Comment on attachment 8845521 [details]
Bug 1344202 - uptake monitoring better handling absence of partials.  a=release DONTBUILD

https://hg.mozilla.org/integration/mozilla-inbound/rev/0cd7b0a6547d
https://hg.mozilla.org/releases/mozilla-beta/rev/2bbd7a57c79b
https://hg.mozilla.org/projects/jamun/rev/aa8bd026ff4a

Need to not forget to uplift this to aurora as well once it lands on central. I'll add a NI to myself for this.
Flags: needinfo?(mtabara)
Attachment #8845521 - Flags: checked-in+
Assignee

Updated

2 years ago
Flags: needinfo?(mtabara)
Keywords: leave-open
Comment on attachment 8845520 [details]
Bug 1344202 - uptake monitoring platforms now have dedicated variable.

https://hg.mozilla.org/build/tools/rev/62d16da877aa
Attachment #8845520 - Flags: checked-in+
Updated all repos, did an end-to-end reconfig, updated both bm83 and bm85, all pieces to their corresponding place.
Once I finish the other builders as well, I'll be able to test and close this.
(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #11)
> Comment on attachment 8845521 [details]
> Bug 1344202 - uptake monitoring better handling absence of partials. 
> a=release DONTBUILD
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/0cd7b0a6547d
> https://hg.mozilla.org/releases/mozilla-beta/rev/2bbd7a57c79b
> https://hg.mozilla.org/projects/jamun/rev/aa8bd026ff4a
> 
> Need to not forget to uplift this to aurora as well once it lands on
> central. I'll add a NI to myself for this.

Reminder.
Flags: needinfo?(mtabara)
https://hg.mozilla.org/releases/mozilla-aurora/rev/eea804e64a41

Once we verify and confirm uptake monitoring works, most likely later on today, we can close this.
Flags: needinfo?(mtabara)
Assignee

Updated

2 years ago
Blocks: 1346892
Assignee

Updated

2 years ago
Depends on: 1346899
A successful uptake monitoring job for Fennec ran via BBB last week - https://tools.taskcluster.net/task-group-inspector/#/37sdAbs6TDW0vM6voulIMA/r30NX5lISuqNVIjydilugg?_k=lrdatx

I think we can close this.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.