1344202 - [tcmigration] uptake monitoring script should handle Fennec releases as well

Status: RESOLVED FIXED

Description

[Mihai Tabara [:mtabara]⌚️GMT]

More specifically, [1] needs to be altered a bit to handle the absence of partials, such as a Fennec release is. More into details, I need to:

a) make sure I can skip defining "partial_versions" in its BBB releasetasks task definition as there are no partials within Fennec.

b) within the script[1] itself, I need to alted [2] to handle empty partials and also condition the run of "partials" block from mozharness configs via [3]

Right now the script would fail because there is no "partials" whithin configs[4]

c) make sure the BB itself knows how to handle the beta vs release for Fennec under [5] and [6].

[1]: https://hg.mozilla.org/mozilla-central/file/tip/testing/mozharness/scripts/release/uptake_monitoring.py
[2]: https://hg.mozilla.org/mozilla-central/file/tip/testing/mozharness/scripts/release/uptake_monitoring.py#l80
[3]: https://hg.mozilla.org/mozilla-central/file/tip/testing/mozharness/scripts/release/uptake_monitoring.py#l139
[4]: https://hg.mozilla.org/mozilla-central/file/tip/testing/mozharness/configs/releases/bouncer_fennec.py
[5]: http://hg.mozilla.org/build/buildbot-configs/file/tip/mozilla/config.py
[6]: https://hg.mozilla.org/build/buildbotcustom/file/tip/process/release.py#l1951

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Bug 1344202 - enable uptake monitoring in Fennec graphs releasetasks.

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Bug 1344202 - Add bb-configs dedicated uptake monitoring platforms.

Review commit: https://reviewboard.mozilla.org/r/118654/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/118654/

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Bug 1344202 - uptake monitoring platforms now have dedicated variable.

Review commit: https://reviewboard.mozilla.org/r/118658/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/118658/

Comment 4

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Bug 1344202 - uptake monitoring better handling absence of partials. a=release DONTBUILD

Review commit: https://reviewboard.mozilla.org/r/118662/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/118662/

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 8845517 [details]
Bug 1344202 - Add bb-configs dedicated uptake monitoring platforms.

https://reviewboard.mozilla.org/r/118654/#review120626

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 8845520 [details]
Bug 1344202 - uptake monitoring platforms now have dedicated variable.

https://reviewboard.mozilla.org/r/118658/#review120630

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 8845521 [details]
Bug 1344202 - uptake monitoring better handling absence of partials.  a=release DONTBUILD

https://reviewboard.mozilla.org/r/118662/#review120634

Comment 8

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8845515 [details] [review]
Bug 1344202 - enable uptake monitoring in Fennec graphs releasetasks.

https://github.com/mozilla/releasetasks/commit/24ef3e7d7f5f5cc485ca3468981e0e5dbaa2d5c1

Comment 9

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8845517 [details]
Bug 1344202 - Add bb-configs dedicated uptake monitoring platforms.

https://hg.mozilla.org/build/buildbot-configs/rev/8b3fffe1e92c

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0cd7b0a6547d
uptake monitoring better handling absence of partials. r=rail a=release DONTBUILD

Comment 11

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8845521 [details]
Bug 1344202 - uptake monitoring better handling absence of partials.  a=release DONTBUILD

https://hg.mozilla.org/integration/mozilla-inbound/rev/0cd7b0a6547d
https://hg.mozilla.org/releases/mozilla-beta/rev/2bbd7a57c79b
https://hg.mozilla.org/projects/jamun/rev/aa8bd026ff4a

Need to not forget to uplift this to aurora as well once it lands on central. I'll add a NI to myself for this.

Comment 12

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8845520 [details]
Bug 1344202 - uptake monitoring platforms now have dedicated variable.

https://hg.mozilla.org/build/tools/rev/62d16da877aa

Comment 13

[Mihai Tabara [:mtabara]⌚️GMT]

Updated all repos, did an end-to-end reconfig, updated both bm83 and bm85, all pieces to their corresponding place.
Once I finish the other builders as well, I'll be able to test and close this.

Comment 14

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #11)
> Comment on attachment 8845521 [details]
> Bug 1344202 - uptake monitoring better handling absence of partials. 
> a=release DONTBUILD
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/0cd7b0a6547d
> https://hg.mozilla.org/releases/mozilla-beta/rev/2bbd7a57c79b
> https://hg.mozilla.org/projects/jamun/rev/aa8bd026ff4a
> 
> Need to not forget to uplift this to aurora as well once it lands on
> central. I'll add a NI to myself for this.

Reminder.

Comment 15

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/0cd7b0a6547d

Comment 16

[Mihai Tabara [:mtabara]⌚️GMT]

https://hg.mozilla.org/releases/mozilla-aurora/rev/eea804e64a41

Once we verify and confirm uptake monitoring works, most likely later on today, we can close this.

Comment 17

[Mihai Tabara [:mtabara]⌚️GMT]

A successful uptake monitoring job for Fennec ran via BBB last week - https://tools.taskcluster.net/task-group-inspector/#/37sdAbs6TDW0vM6voulIMA/r30NX5lISuqNVIjydilugg?_k=lrdatx

I think we can close this.

Comment 18

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.