1346103 - stylo: Enable mochitests in dom/animation/test

Status: RESOLVED DUPLICATE of bug 1383980

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Hiroyuki Ikezoe (:hiro)]

We have a bunch of test cases for animations.  Some of tests in there are totally unrelated to stylo (e.g. document timeline tests), but some of them are related to.  We should run these tests.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Initially I thought we can re-use stylo-failures.md extension, which we can use for mochitest in layout/style/test, but unfortunately it does not support testharness.js yet.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

If there are non-trivial number of tests which use testharness.js, we probably should try integrate the failure pattern into that as well. I didn't prioritize that because there weren't a lot in layout/style/test.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

We have 67 test files in dom/animation/test.  64 use testharness.js.

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

FWIW, we can always enable tests which do not fail. Also, failure pattern file can handle assertions on testharness.js tests. That means you can include those tests in the automation with failing tests marked as "skip-if = stylo".

Comment 5

[Brian Birtles (:birtles)]

(This is a separate bug, I guess, but I wonder about web-platform-tests too. We have a bunch of tests there for things like the result of getKeyframes() which we definitely need to test with Servo.)

Comment 6

[Boris Chiou [:boris]]

(In reply to Brian Birtles (:birtles) from comment #5)
> (This is a separate bug, I guess, but I wonder about web-platform-tests too.
> We have a bunch of tests there for things like the result of getKeyframes()
> which we definitely need to test with Servo.)

Yes, we should create a bug for wpt test (e.g. web-animations). I tested them before, and most of them in web-animations are passed; however, some are crashed. We can add a meta file to disable them if possible.

Comment 7

[Hiroyuki Ikezoe (:hiro)]

(In reply to Boris Chiou [:boris] from comment #6)
> (In reply to Brian Birtles (:birtles) from comment #5)
> > (This is a separate bug, I guess, but I wonder about web-platform-tests too.
> > We have a bunch of tests there for things like the result of getKeyframes()
> > which we definitely need to test with Servo.)
> 
> Yes, we should create a bug for wpt test (e.g. web-animations). I tested
> them before, and most of them in web-animations are passed; however, some
> are crashed. We can add a meta file to disable them if possible.

I just upload a patch for bug 1326131. With the patch, all wpt for animations will work without crashes (I just checked web-animations/interfaces directory though).