Closed Bug 1346129 Opened 3 years ago Closed 3 years ago

Thunderbird 52.0 source step bustage

Categories

(Thunderbird :: Build Config, defect)

52 Branch
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ewong, Assigned: ewong)

Details

Attachments

(2 files, 1 obsolete file)

CXX=/tools/gcc-4.7.3-0moz1/bin/g++
  PKG_CONFIG=/builds/slave/tb-rel-c-esr52-tb_source-00000/comm-esr52/mozilla/gtk3/usr/local/bin/pkg-config
checking for a shell... /bin/sh
checking for host system type... x86_64-pc-linux-gnu
checking for target system type... x86_64-pc-linux-gnu
checking whether cross compiling... no
checking for pkg_config... not found
DEBUG: pkg_config: Trying /builds/slave/tb-rel-c-esr52-tb_source-00000/comm-esr52/mozilla/gtk3/usr/local/bin/pkg-config
ERROR: Cannot find pkg_config
*** Fix above errors and then restart with\
               "make -f client.mk build"
make[1]: *** [configure] Error 1
make[1]: Leaving directory `/builds/slave/tb-rel-c-esr52-tb_source-00000/comm-esr52'
make: *** [configure] Error 2
State Changed: unlock buildroot
program finished with exit code 2
elapsedTime=147.909820
Attached patch [configs] proposed patch β€” β€” Splinter Review
iirc, TB's source step needs to use the source mozconfig and
not the release one.
Attachment #8845775 - Flags: review?(jlund)
Comment on attachment 8845775 [details] [diff] [review]
[configs] proposed patch

Review of attachment 8845775 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla/release-thunderbird-comm-esr52.py
@@ +124,5 @@
>      'linux64': 'mail/config/mozconfigs/linux64/release',
>      'macosx64': 'mail/config/mozconfigs/macosx-universal/release',
>      'win32': 'mail/config/mozconfigs/win32/release',
>  }
> +releaseConfig['source_mozconfig']      = 'mail/config/mozconfigs/linux64/source'

this sounds familiar. I'm surprised you are only getting bitten by this now.
Attachment #8845775 - Flags: review?(jlund) → review+
(In reply to Jordan Lund (:jlund) from comment #2)
> Comment on attachment 8845775 [details] [diff] [review]
> [configs] proposed patch
> 
> Review of attachment 8845775 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mozilla/release-thunderbird-comm-esr52.py
> @@ +124,5 @@
> >      'linux64': 'mail/config/mozconfigs/linux64/release',
> >      'macosx64': 'mail/config/mozconfigs/macosx-universal/release',
> >      'win32': 'mail/config/mozconfigs/win32/release',
> >  }
> > +releaseConfig['source_mozconfig']      = 'mail/config/mozconfigs/linux64/source'
> 
> this sounds familiar. I'm surprised you are only getting bitten by this now.

While I know that TB was bitten by this in c-b(which was fixed in
bug 1245605), ESR45 didn't have this issue (afaik) so the 'copy'
(or migration) from the ESR45 configs to 52 configs brought this
to light.
Now, we just need a second build of tb from the esr52 branch once this is commited ?
This was pushed in https://hg.mozilla.org/build/buildbot-configs/rev/09752149182ba26fd0c72598bd71545ef3a6f746 and merged to production a day later.
Assignee: nobody → ewong
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
seeing same error in build2 https://archive.mozilla.org/pub/thunderbird/candidates/52.0-candidates/build2/logs/release-comm-esr52-thunderbird_source-bm74-build1-build1.txt.gz

checking for pkg_config... not found
DEBUG: pkg_config: Trying /builds/slave/tb-rel-c-esr52-tb_source-00000/comm-esr52/mozilla/gtk3/usr/local/bin/pkg-config
ERROR: Cannot find pkg_config
*** Fix above errors and then restart with\
               "make -f client.mk build"
make[1]: *** [configure] Error 1
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Wayne Mery (:wsmwk, NI for questions) from comment #6)
> seeing same error in build2
> https://archive.mozilla.org/pub/thunderbird/candidates/52.0-candidates/
> build2/logs/release-comm-esr52-thunderbird_source-bm74-build1-build1.txt.gz
> 
> checking for pkg_config... not found
> DEBUG: pkg_config: Trying
> /builds/slave/tb-rel-c-esr52-tb_source-00000/comm-esr52/mozilla/gtk3/usr/
> local/bin/pkg-config
> ERROR: Cannot find pkg_config
> *** Fix above errors and then restart with\
>                "make -f client.mk build"
> make[1]: *** [configure] Error 1

Strange.. it's not using the source mozconfig .
(In reply to Edmund Wong (:ewong) from comment #8)
> Erm, why did https://hg.mozilla.org/build/buildbot-configs/rev/9151355abbc6
> revert the changes?

that's weird.
Attachment #8849362 - Flags: review?(jlund)
Might as well change all four files. I think it would be reasonable to push this with r+ since the general change was already r+'d. I'm leaving r? until someone else agrees with me.
Attachment #8849362 - Attachment is obsolete: true
Attachment #8849362 - Flags: review?(jlund)
Attachment #8849503 - Flags: review?(jlund)
(In reply to Philipp Kewisch [:Fallen] from comment #11)
> Created attachment 8849503 [details] [diff] [review]
> [configs] Change the source mozconfig in templates and staging - v2
> 
> Might as well change all four files. I think it would be reasonable to push
> this with r+ since the general change was already r+'d. I'm leaving r? until
> someone else agrees with me.

Looks and sounds reasonable to me. But I won't be offended if you want to wait for someone else.
Comment on attachment 8849503 [details] [diff] [review]
[configs] Change the source mozconfig in templates and staging - v2

Lets do it. carrying over r+
Attachment #8849503 - Flags: review?(jlund) → review+
https://hg.mozilla.org/build/buildbot-configs/rev/f5edf3edb95da71528d5ce6dabc6af31265f1eb6
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.