Closed Bug 1348534 Opened 3 years ago Closed 5 months ago

closing TB produces "Method not implemented" in prplIAccount::unInit

Categories

(Chat Core :: Debug, defect, minor)

x86_64
Linux
defect
Not set
minor

Tracking

(thunderbird_esr6870+ fixed, thunderbird71 fixed)

RESOLVED FIXED
Instantbird 71
Tracking Status
thunderbird_esr68 70+ fixed
thunderbird71 --- fixed

People

(Reporter: aceman, Assigned: clokep)

Details

Attachments

(1 file)

When closing Thunderbird I observe these errors in the console (terminal):

JavaScript error: file:///tbird-bin/dist/bin/components/imAccounts.js, line 668: uncaught exception: 2147500033
JavaScript error: file:///tbird-bin/dist/bin/components/imAccounts.js, line 668: NS_ERROR_NOT_IMPLEMENTED: Method not implemented'Method not implemented' when calling method: [prplIAccount::unInit]
JavaScript error: file:///tbird-bin/dist/bin/components/imAccounts.js, line 668: NS_ERROR_NOT_IMPLEMENTED: Method not implemented'Method not implemented' when calling method: [prplIAccount::unInit]
I think this was fixed by bug 1344902. Is that true freaktechnik?
Flags: needinfo?(martin)
This is a different issue, since in that bug, the assumption is, that prplIAccount is no longer set, whereas here it still exists, but redirects to the generic implementation that throws.
Flags: needinfo?(martin)

I see you fixed this for some accounts in bug 1586250, but I am still getting this after that patch. In my test profile I have many different IM accounts for testing purposes, including the Yahoo one. Clokep, can you please check if some other account type is still missing the unInit method?

Depends on: 1586250
Flags: needinfo?(clokep)

Can you please include which accounts / protocols you have?

Flags: needinfo?(clokep) → needinfo?(acelists)

Google Talk
IRC
Odnoklassniki
Twitter
XMPP
Yahoo
JS test

Flags: needinfo?(acelists)

I suspect it is the JS Test protocol. I'll look into it soon.

Does this fix the errors?

Assignee: nobody → clokep
Status: NEW → ASSIGNED
Attachment #9099969 - Flags: review?(acelists)
Comment on attachment 9099969 [details] [diff] [review]
Add unInit to jsTest protocol

Review of attachment 9099969 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, this fixes it.
Have you checked all other protocols are already covered?
Attachment #9099969 - Flags: review?(acelists) → review+

Great! Yes, I had already checked this in the other bug. I had skipped the jsTest protocol for some reason though.

Component: Instant Messaging → Debug
No longer depends on: 1586250
Keywords: checkin-needed
Product: Thunderbird → Chat Core
Version: Trunk → trunk

Thanks. I have a few patched for the M-C merge in an hour, so I'll land this in twelve hours before the Daily run.

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/54835cf69aed
Add unInit() to jsTest protocol to fix "Method not implemented" error. r=aceman

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 71
Attachment #9099969 - Flags: approval-comm-esr68+
You need to log in before you can comment on or make changes to this bug.