1348534 - closing TB produces "Method not implemented" in prplIAccount::unInit

Status: RESOLVED FIXED

(Chat Core :: Debug, defect)

Description

[:aceman]

When closing Thunderbird I observe these errors in the console (terminal):

JavaScript error: file:///tbird-bin/dist/bin/components/imAccounts.js, line 668: uncaught exception: 2147500033
JavaScript error: file:///tbird-bin/dist/bin/components/imAccounts.js, line 668: NS_ERROR_NOT_IMPLEMENTED: Method not implemented'Method not implemented' when calling method: [prplIAccount::unInit]
JavaScript error: file:///tbird-bin/dist/bin/components/imAccounts.js, line 668: NS_ERROR_NOT_IMPLEMENTED: Method not implemented'Method not implemented' when calling method: [prplIAccount::unInit]

Comment 1

[Patrick Cloke [:clokep]]

I think this was fixed by bug 1344902. Is that true freaktechnik?

Comment 2

[Martin Giger [:freaktechnik]]

This is a different issue, since in that bug, the assumption is, that prplIAccount is no longer set, whereas here it still exists, but redirects to the generic implementation that throws.

Comment 3

[:aceman]

I see you fixed this for some accounts in bug 1586250, but I am still getting this after that patch. In my test profile I have many different IM accounts for testing purposes, including the Yahoo one. Clokep, can you please check if some other account type is still missing the unInit method?

Comment 4

[Patrick Cloke [:clokep]]

Can you please include which accounts / protocols you have?

Comment 5

[:aceman]

Google Talk
IRC
Odnoklassniki
Twitter
XMPP
Yahoo
JS test

Comment 6

[Patrick Cloke [:clokep]]

I suspect it is the JS Test protocol. I'll look into it soon.

Comment 7

[Patrick Cloke [:clokep]]

Attachment: Add unInit to jsTest protocol

Does this fix the errors?

Comment 8

[:aceman]

Comment on attachment 9099969 [details] [diff] [review]
Add unInit to jsTest protocol

Review of attachment 9099969 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, this fixes it.
Have you checked all other protocols are already covered?

Comment 9

[Patrick Cloke [:clokep]]

Great! Yes, I had already checked this in the other bug. I had skipped the jsTest protocol for some reason though.

Comment 10

[Jorg K (CEST = GMT+2)]

Thanks. I have a few patched for the M-C merge in an hour, so I'll land this in twelve hours before the Daily run.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/54835cf69aed
Add unInit() to jsTest protocol to fix "Method not implemented" error. r=aceman

Comment 12

[Jorg K (CEST = GMT+2)]

Tb 68.2.0 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/6ef6516e936eb3379916171cae59aea8511be76f