Clean up the look of the new tab compact tiles

RESOLVED WONTFIX

Status

()

defect
P3
normal
RESOLVED WONTFIX
2 years ago
2 years ago

People

(Reporter: verdi, Unassigned)

Tracking

52 Branch
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Posted image placement.png
This bug is for the compact layout on the new tab. Ref: Bug 1322738

There are a few fixes/refinements wanted for the tiles:
* The box shadow for the tiles should be: box-shadow: 0px 1px 0px rgba(0,0,0,.05);
* The "Top Sites"/"You Top Sites" tile should be left aligned with the left most tile (currently it seems to be aligned to the edge of the box shadow).
* Update the placement of the pin and close icon on each tile as described in the attachment.
Posted image screenshot.png
> * The "Top Sites"/"You Top Sites" tile should be left aligned with the left
> most tile (currently it seems to be aligned to the edge of the box shadow).

Hi Verdi,

Could you explain more about this point? Cannot really understand it. And what do you mean of "Top Sites"/"You Top Sites" tile? I cannot find the item in the current m-c build. The attachment is what I see now in the m-c build.
Assignee: nobody → evan
Assignee: evan → nobody
Flags: needinfo?(mverdi)
(In reply to Evan Tseng [:evanxd] from comment #1)
> I cannot find the item in the current m-c build. The attachment is what I see now in the m-c build.
Hi Evan,
To see the new about:newTab, the browser.newtabpage.compact pref is required to be set to true.
Hi Fischer,

Thanks, it works. Let's cancel the needinfo.
Flags: needinfo?(mverdi)
Looks like this bug is a sub-issue of Bug 1351611
Blocks: 1351611
But since we wouldl like to add the OnBoarding overlay into Activity Stream (at today's meeting), I think we don't need to work on this at this stage. We can come back to work on this after we figure out (ensure) that we would like to add the overlay into Activity Stream or new tag page (about:newTab)?
Hi Verdi,

What do you think of Comment 5?
Flags: needinfo?(mverdi)
What I mean in the Comment 5 is if we decide to add the OnBoarding overlay into Activity Stream in near future we might not need to fix this at this stage. We could come back to this after we decide to add the overlay into the new tab (about:newTab) page. What do you think?
Whiteboard: [photon]
Blocks: 1322738
No longer blocks: 1351611
Blocks: 1354046
Priority: -- → P3
Whiteboard: [photon] → [photon-onboarding][triage]
keep as P3 bug for now
Whiteboard: [photon-onboarding][triage] → [photon-onboarding]
after Bug 1379860 land (shipping origin new tab page view by default), we would not fix this in onboarding scope
Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(mverdi)
Resolution: --- → WONTFIX
Whiteboard: [photon-onboarding]
You need to log in before you can comment on or make changes to this bug.