Closed Bug 1351577 Opened 4 years ago Closed 3 years ago

Integrate LeanplumPushReceiver/LeanplumPushListenerService

Categories

(Firefox for Android :: General, enhancement, P1)

All
Android
enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: sebastian, Unassigned)

References

(Blocks 2 open bugs, )

Details

(Whiteboard: [Leanplum])

To receive and process push messages we need to integrate LeanplumPushReceiver into the app. Normally that's just adding it to the manifest. But in our case we are using GCM push for implementing web push already. Instead we will need to route incoming push messages to LeanplumPushListenerService or our GcmMessageListenerService.

Additionally we need to pass the sender ID to LeanplumPushService.
yes... That's the thing I'm goiing to work on later. Since Push Notificaiton is not in the scope (55) yet... right?
Flags: needinfo?(jcheng)
Correct.
Priority: -- → P2
right not in scope for 55
Flags: needinfo?(jcheng)
This is not in scope for 56 either. Maybe we can create another meta bug and link this bug to there.
[triage] Bulk edit: product thinks leanplum is high priority: P1 rank 1.
Rank: 1
Priority: P2 → P1
Mike, can you please confirm what the status of this feature is. Has this ever landed?

Also looking at this: https://bugzilla.mozilla.org/show_bug.cgi?id=1397208
Flags: needinfo?(michael.l.comella)
Whiteboard: [Leanplum]
> Mike, can you please confirm what the status of this feature is. Has this ever landed?

I think so: there is a LeanplumPushReceiver [1] and LeanplumPushService [2] in the code but I can't be certain with digging in more to fully understand what we implement with Leanplum, which is outside the scope of my role as triage owner (i.e. whoever implements Leanplum would be a better person to do this). fwiw, these classes were added in bug 1351585 (add SDK), bug 1386151 (enable push feature), and bug 1392224 (make fennec default handler for leanplum push).

Action item for this bug: did we implement everything set out in comment 0 in these other bugs? If so, please dupe.

[1]: https://searchfox.org/mozilla-central/source/mobile/android/thirdparty/com/leanplum/LeanplumPushReceiver.java
[2]: https://searchfox.org/mozilla-central/source/mobile/android/thirdparty/com/leanplum/LeanplumPushService.java
Flags: needinfo?(michael.l.comella)
Yes, if we use push with leanplum then this has already been implemented (at least that's what I filed this bug for back then).
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.