Closed Bug 1351808 Opened 3 years ago Closed 3 years ago

Exclude custom tabs from session store

Categories

(Firefox for Android :: General, enhancement, P1)

All
Android
enhancement

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: JanH, Assigned: JanH)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

Until we can figure out further details of whether and how we're going to handle custom tabs and web app tabs in session restore, we should exclude at least the former, otherwise after a restart, they'll be restored as normal tabs.

Web app tabs could potentially even work out okay without further changes - when they're restored on startup, we notice that their URL is within the scope of a web app, so we turn the tab over to the WebAppActivity. In practice this might still require some bug fixes, but in any case that's a separate bug...
Actually web apps need to be excluded as well for now - they run in their own activity and there's no such thing as a background activity restore.

If we want anything more advanced, we can try figuring it out in bug 1346008 if there's any demand for it. Until that time, the minimal behaviour with bug 1352997 in place will be that if we can't find the tab belonging to the activity (it's been closed, or Firefox as whole has terminated), we'll relaunch it from the intent data.
Priority: -- → P1
Blocks: 1285858, 1300570
Depends on: 1352997
Comment on attachment 8856159 [details]
Bug 1351808 - Part 1 - Replace some magic numbers in session store.

https://reviewboard.mozilla.org/r/128066/#review131960
Attachment #8856159 - Flags: review?(s.kaspari) → review+
Comment on attachment 8856167 [details]
Bug 1351808 - Part 2 - Exclude non-standard tab types from session store.

https://reviewboard.mozilla.org/r/128068/#review131964
Attachment #8856167 - Flags: review?(s.kaspari) → review+
Blocks: 1355824
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/f349db3287ad
Part 1 - Replace some magic numbers in session store. r=sebastian
https://hg.mozilla.org/integration/autoland/rev/4aa74fee0d37
Part 2 - Exclude non-standard tab types from session store. r=sebastian
Backed out for bustage on Android in GeckoApp.java:

https://hg.mozilla.org/integration/autoland/rev/e8f1286bc87e54d0cee728cfd46853ae3176ad30
https://hg.mozilla.org/integration/autoland/rev/742f57fd66dd09f309940015dd0841c2b921369b

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=4aa74fee0d37fedef9d3c416f41917b09223836f&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=94917738&repo=autoland

[task 2017-04-27T18:30:37.802300Z] 18:30:37     INFO -  /home/worker/workspace/build/src/mobile/android/base/java/org/mozilla/gecko/GeckoApp.java:1866: error: cannot find symbol
[task 2017-04-27T18:30:37.802547Z] 18:30:37     INFO -                      windowObject.put("selectedTabId", parser.getStoredSelectedTabId());
[task 2017-04-27T18:30:37.802723Z] 18:30:37     INFO -                                                              ^
[task 2017-04-27T18:30:37.802886Z] 18:30:37     INFO -    symbol:   method getStoredSelectedTabId()
[task 2017-04-27T18:30:37.803086Z] 18:30:37     INFO -    location: variable parser of type LastSessionParser
[task 2017-04-27T18:30:39.031169Z] 18:30:39     INFO -  Note: Some input files use or override a deprecated API.
[task 2017-04-27T18:30:39.031421Z] 18:30:39     INFO -  Note: Recompile with -Xlint:deprecation for details.
[task 2017-04-27T18:30:39.031583Z] 18:30:39     INFO -  1 error
Flags: needinfo?(jh+bugzilla)
Ooops, yes, forgot that this bug wasn't JS only and depends on a previous bug as well (which failed to land because there are conflicting changes on autoland).
Flags: needinfo?(jh+bugzilla)
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/50de746d569e
Part 1 - Replace some magic numbers in session store. r=sebastian
https://hg.mozilla.org/integration/autoland/rev/11dceec1864b
Part 2 - Exclude non-standard tab types from session store. r=sebastian
https://hg.mozilla.org/mozilla-central/rev/50de746d569e
https://hg.mozilla.org/mozilla-central/rev/11dceec1864b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Depends on: 1379374
You need to log in before you can comment on or make changes to this bug.