135204 - Search Messages... and Search Addresses.. appear twice under Tools | Search (duplicate menu items)

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Navin Gupta]

Infact Tools menu in mail has  Search Messages ....
and then again Search | Search Messages .....

Expected : Search Messages .. should appear only once.

Comment 1

[Navin Gupta]

cc blake who worked on menus reorg.

Comment 2

[Blake Ross]

This is by design.  The one at the top are app-specific. Tools > Search > is global.

Comment 3

[jglick]

Yes, this was per pixeljockeys meeting. Since the Top level Search menu was 
being removed, the idea was to still have a way to access the other searches.

We have had a number of negative comments on this already. Options to remedy 
this would be to: (1) remove the Search flyout menu and only have search items 
in the Tools menu that are directly appliable to the current application. (2) 
Only list the search items not included in the top of the Tools menu in the 
Search flyout. I lean towards option 1.

Comment 4

[:deanis74]

I prefer 1.  Searching should be specific to the app I'm using.  If I'm browsing
the web, I have no use for searching messages nor the address book.

Comment 5

[Håkan Waara]

FWIW, I also agree with option 1.

Comment 6

[:deanis74]

So following that thought, we could toast the Search submenu entirely.  This
would be good, because then it would free up Ctrl+Shift+F (Search Messages) in
case we want to assign it to the app-specific search function (eg. bug 134614).

Comment 7

[Matthew T (active 1999-2002)]

What Dean said. Searching the Web belongs in Navigator (Shift+accel+F), 
searching messages belongs in mail/news (Shift+accel+F), searching the address 
book belongs in the Address Book (accel+F), searching bookmarks belongs in the 
Bookmarks Manager (accel+F), searching the history belongs in the History 
window (accel+F), and searching my MP3s belongs in iTunes. A single unified 
access point for all searches on my computer would be nice, but this submenu 
sure isn't it -- especially as long as it's missing the `Search My MP3s...' 
item.

(Incidentally, the same applies to the bletcherous `File' > `New' submenu.)

Comment 8

[Matthew T (active 1999-2002)]

*** Bug 135372 has been marked as a duplicate of this bug. ***

Comment 9

[jglick]

OK, here is the current proposal.

Eliminate the "Search --->" flyout for all apps except Browser commercial 
version. (move issue to bugscape as appropriate)

Mozilla - Browser - Tools 
Search the Web... 
etc. 
  

NS Commerical - Browser - Tools 
Search --->        Search the Web... 
                  ---------------------- 
                   Yellow Pages 
                   Stock Quote Lookup 
                   Maps and Directions 
                   People Finder 
                   Reference Desk 
                   Shopping Search 
                   -------------------- 
                   Internet Keywords 
  

Mozilla and NS - Mail - Tools 
Search Messages... 
Search Addresses... 
etc. 
  

Moz and NS - AB - Tools 
Search Addresses 
etc. 
  

Reason for "Search Addresses..." also available in Mail. I think users may want 
to search for Addresses while in Mail but wanting to search Mail from the AB
probably isn't very common. 

Comment 10

[:deanis74]

"I think users may want to search for Addresses while in Mail but wanting to
search Mail from the AB probably isn't very common."

Why would I want to do that?  The only time I'd want to search for an address is
when I'm composing an email.  It's standard practice in most email apps to open
the address book and either select the name you want or perform some sort of search.

Comment 11

[Ben Bucksch (:BenB)]

I agree with Jen. AB is a part of Mailnews.

Comment 12

[:deanis74]

When would you use it?

Comment 13

[Michael Buckland]

Discussed in Mail News bug meeting.  Decided to ADT2 and plus this bug.

Comment 14

[Jesse Ruderman]

Filed bug 135804, similar bug for removing the New submenu of the File menu.

Comment 15

[(not reading, please use [e-mail] instead)]

accepting.  I'll work on this today.

Comment 16

[(not reading, please use [e-mail] instead)]

Attachment: moz part of the patch

Comment 17

[(not reading, please use [e-mail] instead)]

Attachment: ns part of the patch

Comment 18

[(not reading, please use [e-mail] instead)]

not complete yet, I still have to:

1) remove the top level "Search the Web..." menuitem from the ns build (which 
comes from mozilla)
2) make it so the Search flyout only appears for browser, right now its 
appearing for all windows in ns app.
3) remove any other unused entities
4) find out about editor, current app doesn't match spec.

top of tools, in editor:

Publish As...
Export to Text 

5) find out about tool in ns aim (not convered by spec)
6) test test test.

Comment 19

[:deanis74]

-<!ENTITY searchInternetCmd.label "Search the Web">
+
+<!ENTITY searchInternetCmd.label "Search the Web...">

Any chance of leaving this change up to bug 135415?

Comment 20

[Jesse Ruderman]

Why remove "Search the Web" from the top level of the Netscape's Tools menu? 
Using a search engine is a very common action, and I like the way it's the first
item in Mozilla's tools menu.  Also, mouse users get frustrated when the first
item in a menu is a submenu, because it's easy to accidentally open the next
menu while trying to get into the submenu.

I'd prefer:

Search the Web
Search > (Netscape only)
 Yellow Pages 
 Stock Quote Lookup
 etc.
------------ (Netscape only)
Form Manager >
etc.

Comment 21

[Lori Kaplan]

This bug has nothing to do with
http://bugzilla.mozilla.org/show_bug.cgi?id=135415.  That bug has to do with the
naming style of the bug, not the placement of it in the menus. 

In terms of removing from NS top level menus, there are a minimum of 4 entry
points to searching the web visible in the chrome. It's not necessary to call
out that one separately in the menus. Better to keep it with the other items in
the search submenu. 

Comment 22

[jglick]

> 4) find out about editor, current app doesn't match spec.

Editor menus weren't covered in PJs meeting. Working with Charlie on that now. 
Don't worry about Editor for time being.

> 5) find out about tool in ns aim (not convered by spec)

Not covered in pjs either. I will get with appropriate folks. Don't worry about 
im for now.

Comment 23

[John Levon]

*** Bug 137282 has been marked as a duplicate of this bug. ***

Comment 24

[jglick]

*** Bug 135065 has been marked as a duplicate of this bug. ***

Comment 25

[Jesse Ruderman]

*** Bug 139236 has been marked as a duplicate of this bug. ***

Comment 26

[Alex Bishop]

*** Bug 139476 has been marked as a duplicate of this bug. ***

Comment 27

[Lori Kaplan]

reassigning. Seth can't code his way out of a wet paper bag. 

Comment 28

[shliang]

Attachment: finished up seth's patches

Comment 29

[shliang]

Attachment: forgot something

Comment 30

[(not reading, please use [e-mail] instead)]

Comment on attachment 82740 [details] [diff] [review]
forgot something

shuehan tells me she's test both ns and mozilla.

r=sspitzer on the mailnews parts.

you'll need someone from browser (ben? hewitt?) to review the rest.

Comment 31

[(not reading, please use [e-mail] instead)]

...or blake.

Comment 32

[Joe Hewitt (gone)]

Comment on attachment 82740 [details] [diff] [review]
forgot something

sr=hewitt

Comment 33

[shliang]

checked into trunk

Comment 34

[:deanis74]

This added an ellipsis to "Search the Web", which it shouldn't have.  See bug
135415.

Comment 35

[Olga]

Verified on trunk build at 05-21-02 on Win2K, Linux, Mac OSX.
No general Search on Mail windows, only on Browser.

Comment 36

[Lori Kaplan]

ADT-please review for check in to the branch. the fix has been verified on the
trunk. This fix brings the Mail menus up to the approved specification. 

Comment 37

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) for approval to checkin to the 1.0 branch, pending
Drivers' approval.  After, checking in, please add the fixed1.0 keyword.

Comment 38

[scottputterman]

changing to adt1.0.1+ for checkin to the 1.0 branch for the Mozilla1.0.1
milestone.  Please get drivers approval before checking in.

Comment 39

[John Levon]

*** Bug 149413 has been marked as a duplicate of this bug. ***

Comment 40

[Judson Valeski]

please checkin to the 1.0.1 branch. once there remove the "mozilla1.0.1+"
keyword and add the "fixed1.0.1" keyword.

Comment 41

[scottputterman]

changing to adt1.0.1- per ADT due to string changes.

Comment 42

[Randell Jesup [:jesup] (needinfo me)]

Removing mozilla1.0.1+ since this will not make 1.0.1.  If this is wanted for
1.0.2, please reopen the bug and target for 1.0.2.