Closed
Bug 1352942
Opened 7 years ago
Closed 7 years ago
Intermittent css-grid/grid-whitespace-handling-1b.xhtml == css-grid/grid-whitespace-handling-1b.xhtml | image comparison, max difference: 187, number of differing pixels: 501
Categories
(Core :: Layout, defect, P5)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Unassigned)
References
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell disabled])
Attachments
(1 file)
1.42 KB,
patch
|
hiro
:
review+
|
Details | Diff | Splinter Review |
Filed by: cbook [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=88219926&repo=autoland https://queue.taskcluster.net/v1/task/MgPGsT5UQ6-RMJuAaoNbcA/runs/0/artifacts/public/logs/live_backing.log https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/MgPGsT5UQ6-RMJuAaoNbcA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1
Updated•7 years ago
|
Priority: -- → P5
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 3•7 years ago
|
||
so close to our 30/week threshold. This is failing pretty regularly- on non-stylo this test is marked as fails, in bug 1352771 we removed the fails. :hiro, I see you authored the patch in bug 1352771 to expect this test to pass, should we look into this or should we put this back as fails?
Flags: needinfo?(hikezoe)
Comment 4•7 years ago
|
||
We should skip this test, css grid seems to be still something broken. For example: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/X5vquqKkT-6yJGSVEdMp3g/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1 https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/DLAGA-stT_6LpO5XJvdhCA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1 Test images in these two failure cases are rendered the same, but reference images are different. I don't know why.
Flags: needinfo?(hikezoe)
Comment 5•7 years ago
|
||
(In reply to Hiroyuki Ikezoe (:hiro) from comment #4) > We should skip this test, css grid seems to be still something broken. For > example: > > https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/ > reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/ > X5vquqKkT-6yJGSVEdMp3g/runs/0/artifacts/public/logs/live_backing. > log&only_show_unexpected=1 > https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/ > reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/DLAGA- > stT_6LpO5XJvdhCA/runs/0/artifacts/public/logs/live_backing. > log&only_show_unexpected=1 > > Test images in these two failure cases are rendered the same, but reference > images are different. I don't know why. Note that the reference image the result of rendering the test case (grid-whitespace-handling-1b.xhtml) on gecko, so the test case is something broken in the first place on gecko?
Comment 6•7 years ago
|
||
this test is marked as fails on gecko, so I was happy to see that we were enabling more passing tests on stylo until it was intermitent. Let me move it back to fails.
Comment 7•7 years ago
|
||
odd, this is just comparing the same file to itself
Comment 8•7 years ago
|
||
(In reply to Joel Maher ( :jmaher) from comment #7) > odd, this is just comparing the same file to itself Yes. On stylo reftest, we compare a result rendered on stylo and a result rendered on gecko. So, image2 (reference) is a result of image rendered on gecko. That's why I think the test case is broken on gecko in the first place.
Comment 9•7 years ago
|
||
if we feel that skipping this test is the right move, this patch will do it!
Attachment #8859527 -
Flags: review?(hikezoe)
Comment 10•7 years ago
|
||
Comment on attachment 8859527 [details] [diff] [review] skip test on stylo Review of attachment 8859527 [details] [diff] [review]: ----------------------------------------------------------------- Thank you!
Attachment #8859527 -
Flags: review?(hikezoe) → review+
Comment 11•7 years ago
|
||
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/468f7570a8b4 Intermittent css-grid/grid-whitespace-handling-1b.xhtml. marks as fails. r=hiro
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/468f7570a8b4
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Whiteboard: [stockwell disabled]
Comment 14•7 years ago
|
||
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/mozilla-inbound/rev/e6343ab01a43 Re-disable intermittent css-grid/grid-whitespace-handling-1b.xhtml which got accidentally enabled by bug 1351548. r=test-disabling
Comment 15•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e6343ab01a43
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•