Closed Bug 1355323 Opened 6 years ago Closed 6 years ago

Create action menu panel with initial "copy URL" and "email link" items

Categories

(Firefox :: Address Bar, enhancement, P1)

Product:
Firefox
Component:
Address Bar
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 55
Iteration:
55.6 - May 29
Tracking Flags:
Tracking Status
firefox55 --- verified

People

(Reporter: adw, Assigned: adw)

References

(Blocks 1 open bug)

Details

(Whiteboard: [photon-structure])

Attachments

(1 file)

Bug 1355323 - Create action menu panel with initial "copy URL" and "email link" items.
59 bytes, text/x-review-board-request
Details 
It's a menu for actions that's also a panel.
Flags: qe-verify+
Priority: -- → P2
QA Contact: gwimberly
Whiteboard: [photon] → [photon-structure]
Assignee: nobody → adw
Status: NEW → ASSIGNED
Need the UX bugs bug 1360054 and bug 1360055 for this to be finished though.
Iteration: --- → 55.4 - May 1
Priority: P2 → P1
Iteration: 55.4 - May 1 → 55.5 - May 15
Summary: Create action menu panel → Create action menu panel with initial "copy URL" and "email link" items
This includes the copy URL and email link items only.
Iteration: 55.5 - May 15 → 55.6 - May 29
Comment on attachment 8867961 [details]
Bug 1355323 - Create action menu panel with initial "copy URL" and "email link" items.

https://reviewboard.mozilla.org/r/139496/#review143034

::: browser/themes/shared/browser.inc.css:93
(Diff revision 1)
>    width: 16px;
>  }
> +
> +#page-action-copy-url-button {
> +  list-style-image: url("chrome://browser/skin/copy-url.svg");
> +  -moz-context-properties: fill;

You need to set a fill color.

::: browser/themes/shared/copy-url.svg:1
(Diff revision 1)
> +<?xml version="1.0"?>

This should probably be in browser/themes/shared/icons/, our new central place for reusable icon glyphs.
Attachment #8867961 - Flags: review?(gijskruitbosch+bugs) → review?(mdeboer)
Trying to get my queue under control, and Mike kindly suggested he could take some reviews, so this one's his now, if there's anything Dão didn't spot yet.
Comment on attachment 8867961 [details]
Bug 1355323 - Create action menu panel with initial "copy URL" and "email link" items.

https://reviewboard.mozilla.org/r/139496/#review143104

r=me with the changes Dão requested. Thanks Drew!
Attachment #8867961 - Flags: review?(mdeboer) → review+
Attachment #8867961 - Flags: review?(gijskruitbosch+bugs)
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a9ea66b0059b
Create action menu panel with initial "copy URL" and "email link" items. r=mikedeboer
https://hg.mozilla.org/mozilla-central/rev/a9ea66b0059b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Verified on Windows, Mac, and Ubuntu.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
Flags: qe-verify+
Hi!
Is there a pref in about:config to remove this action menu panel? (temporarily)
Thank you.
Flags: needinfo?(adw)
(In reply to Julien L. from comment #11)
> Hi!
> Is there a pref in about:config to remove this action menu panel?
> (temporarily)
> Thank you.

No.
Flags: needinfo?(adw)
Depends on: 1366855
No longer depends on: 1366855
Blocks: 1387512
You need to log in before you can comment on or make changes to this bug.