1355323 - Create action menu panel with initial "copy URL" and "email link" items

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement, P1)

Description

[Drew Willcoxon :adw]

It's a menu for actions that's also a panel.

Comment 1

[Drew Willcoxon :adw]

Need the UX bugs bug 1360054 and bug 1360055 for this to be finished though.

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1355323 - Create action menu panel with initial "copy URL" and "email link" items.

Review commit: https://reviewboard.mozilla.org/r/139496/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/139496/

Comment 3

[Drew Willcoxon :adw]

This includes the copy URL and email link items only.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8867961 [details]
Bug 1355323 - Create action menu panel with initial "copy URL" and "email link" items.

https://reviewboard.mozilla.org/r/139496/#review143034

::: browser/themes/shared/browser.inc.css:93
(Diff revision 1)
>    width: 16px;
>  }
> +
> +#page-action-copy-url-button {
> +  list-style-image: url("chrome://browser/skin/copy-url.svg");
> +  -moz-context-properties: fill;

You need to set a fill color.

::: browser/themes/shared/copy-url.svg:1
(Diff revision 1)
> +<?xml version="1.0"?>

This should probably be in browser/themes/shared/icons/, our new central place for reusable icon glyphs.

Comment 5

[:Gijs (he/him)]

Trying to get my queue under control, and Mike kindly suggested he could take some reviews, so this one's his now, if there's anything Dão didn't spot yet.

Comment 6

[Mike de Boer [:mikedeboer]]

Comment on attachment 8867961 [details]
Bug 1355323 - Create action menu panel with initial "copy URL" and "email link" items.

https://reviewboard.mozilla.org/r/139496/#review143104

r=me with the changes Dão requested. Thanks Drew!

Comment 7

[Drew Willcoxon :adw]

Comment on attachment 8867961 [details]
Bug 1355323 - Create action menu panel with initial "copy URL" and "email link" items.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/139496/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9ea66b0059b
Create action menu panel with initial "copy URL" and "email link" items. r=mikedeboer

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a9ea66b0059b

Comment 10

[u554753]

Verified on Windows, Mac, and Ubuntu.

Comment 11

[Julien L.]

Hi!
Is there a pref in about:config to remove this action menu panel? (temporarily)
Thank you.

Comment 12

[Dão Gottwald [:dao]]

(In reply to Julien L. from comment #11)
> Hi!
> Is there a pref in about:config to remove this action menu panel?
> (temporarily)
> Thank you.

No.