1356053 - [Firefox Android redirects][li-00138883] Firefox for Android in-product URLs

Status: RESOLVED WONTFIX

(support.mozilla.org - Lithium :: General, enhancement)

Description

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

+++ This bug was initially created as a clone of Bug #1355701 +++

+++ This bug was initially created as a clone of Bug #1350389 +++

This bug tracks Firefox for Android in-product URLs

The steps are

1. Get list of in product URLs from Joe Cheng et al
2. Generate two column spreadsheet (column A FROM, column B TO) based on 1.
3. Submit a support case with spreadsheet to Lithium and get the redirects implemented

Comment 1

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

Need info-ing :joecheng.
1. Joe please get your team to attach a document or link to a document with all the FF Android in-product URLs

2. after you have done that please needinfo [e-mail] to generate the spreadsheet!

Comment 2

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

links from nevin chen in email:
BEGIN
Below are links I search using "support.mozilla.org" in our code base

https://support.mozilla.org/kb/controlledaccess
https://support.mozilla.org/kb/firefox-android-tracking-protection
https://support.mozilla.org/kb/how-does-insecure-content-affect-safety-android
https://support.mozilla.org/kb/flash-protected-mode-settings
https://support.mozilla.org/kb/private-browsing-firefox-android
https://support.mozilla.org/kb/make-firefox-default-browser-android?utm_source=inproduct&utm_medium=settings&utm_campaign=mobileandroid
https://support.mozilla.org/kb/notifications-firefox-android?utm_source=inproduct&utm_medium=notifications&utm_campaign=mobileandroid"
https://support.mozilla.org/1/mobile/&formatS1;/&formatS2;/&formatS3;/faq
https://support.mozilla.org/1/mobile/&formatS1;/&formatS2;/&formatS3;/unsupported-version
https://support.mozilla.org/1/mobile/%VERSION%/%OS%/%LOCALE%/new-android
https://support.mozilla.org/1/mobile/55.a01/Android/en/mobile-help
https://support.mozilla.org/1/mobile/55.a01/Android/en/new-android
https://support.mozilla.org/products/mobile?utm_source=inproduct&utm_medium=default-bookmarks&utm_campaign=mobileandroid

and there are some links in feed_rss.....xxx.xml but I don't think they are considered as "in-product"

https://support.mozilla.org/t5/Protect-your-privacy/Mixed-content-blocker-in-Firefox-for-Android/ta-p/1381588
END

Comment 3

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

:joni i think we have enough to start the spreadsheet so needinfo'ing you

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Hi Roland
Please correct me if I'm wrong.
Lithium will help redirect the links to the correct page. There's no need for Fennec to change the URL in ourd code base. 
Is that correct?

Comment 5

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

:nchen, hello and sorry for mis-communicating! 

I have zero knowledge of the Fennec code base but I am 99% certain yes you will have to change Fennec code!

Currently the Fennec code uses URLs of the form

1) https://support.mozilla.org/1/mobile/%VERSION%/%OS%/%LOCALE%/slug
e.g.
https://support.mozilla.org/1/mobile/%VERSION%/%OS%/%LOCALE%/sync-faq ("sync-faq" is not a real slug, i made that up :-) !)

it will have to change to:

2) support.mozilla.org/kb/slug-<locale> <----THIS WILL BE THE CHANGE YOU MAKE TO THE FENNEC CODE (unless of course I am wrong and you can do this without Fennec code changes :-) !)

3) which lithium will redirect to
https://support.mozilla.org/t5/<category>/<slug>/ta-p/<integerid>
e.g.
https://support.mozilla.org/t5/Protect-your-privacy/Send-anonymous-usage-data-from-Firefox-on-mobile-devices/ta-p/37739

4) Once you have told SUMO what all the Fennec in-product URLs are, then the SUMO team ([e-mail] and I) will make a spreadsheet with 2 columns:
Column A - Fennec in-product link in the form of 2)
Column B - URL to redirect to in the form of 3)
e.g. sample spreadsheet for FF iOS and FF Focus for iOS can be found here:
https://docs.google.com/spreadsheets/d/1p8wdaF8Oe6Am2HeqgvY2kOhR0HZf1i77gxzniN-PCDw/edit#gid=0

5) SUMO will submit the spreadsheet to Lithium and they will get the redirects set up
I will test once Lithium says the redirects are set up
And then I will let you know so you can test your code

6) Fennec QA will test the redirects as well

I hope that clears explains everything. I am on holiday Friday April 14th, back Monday the 17th of April 2017.

If you have questions while I am away please needinfo [e-mail] or email her or contact her in slack.

Cheers!
...Roland

Comment 6

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1356053 - Update Fennec in-product sumo links.

Review commit: https://reviewboard.mozilla.org/r/131056/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131056/

Comment 7

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1356053 - Remove unused string resources.

Review commit: https://reviewboard.mozilla.org/r/131058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/131058/

Comment 8

[Nevin Chen(Not active on Bugzilla)]

Below links are updated:

help_link
https://support.mozilla.org/1/mobile/%VERSION%/%OS%/%LOCALE%/mobile-help
now is
https://support.mozilla.org/kb/mobile-help-%LOCALE%

faq_link
https://support.mozilla.org/1/mobile/%VERSION%/%OS%/%LOCALE%/faq
now is
https://support.mozilla.org/kb/faq-%LOCALE%
e.g. https://support.mozilla.org/kb/faq-zh-TW

whatsnew_notification_url
https://support.mozilla.org/1/mobile/%VERSION%/%OS%/%LOCALE%/new-android
now is
https://support.mozilla.org/kb/new-android-%LOCALE%

eol_notification_url 
now is not used and will be removed
https://support.mozilla.org/1/mobile/&formatS1;/&formatS2;/&formatS3;/unsupported-version


Below links are remained cause they are already in suggested ("kb)" pattern:
bookmarkdefaults_url_support
remains
https://support.mozilla.org/products/mobile?utm_source=inproduct&utm_medium=default-bookmarks&utm_campaign=mobileandroid

bookmarkdefaults_url_restricted_support
remains
https://support.mozilla.org/kb/controlledaccess?utm_source=inproduct&utm_medium=default-bookmarks&utm_campaign=mobileandroid


Below links are not fixed cause they share the pref "app.support.baseURL" with code outside of mobile and will need some investigation.
unsigned-addons
npapi
insecure-password

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8859035 [details]
Bug 1356053 - Update Fennec in-product sumo links.

https://reviewboard.mozilla.org/r/131056/#review133660

Oh boy, what a mess. Can we get some QA help to make sure this still works reliably in a couple of locales?

::: mobile/android/base/strings.xml.in:330
(Diff revision 1)
>    <string name="pref_default_browser_mozilla_support_tablet">&pref_default_browser_mozilla_support_tablet;</string>
>  
>    <string name="pref_about_firefox">&pref_about_firefox;</string>
>  
>    <string name="pref_vendor_faqs">&pref_vendor_faqs;</string>
> -  <!-- https://support.mozilla.org/1/mobile/%VERSION%/%OS%/%LOCALE%/faq -->
> +  <string name="faq_link">https://support.mozilla.org/kb/faq-&formatS1;</string>

nit: You removed the comment explaining what the parameter means.

::: mobile/android/base/strings.xml.in:616
(Diff revision 1)
>  
>    <string name="unsupported_sdk_version">&unsupported_sdk_version;</string>
>    <string name="eol_notification_title">&eol_notification_title2;</string>
>    <string name="eol_notification_summary">&eol_notification_summary;</string>
> -  <!-- https://support.mozilla.org/1/mobile/%VERSION%/%OS%/%LOCALE%/honeycomb -->
> +
> +  <!-- TODO: remove not used: https://support.mozilla.org/1/mobile/%VERSION%/%OS%/%LOCALE%/honeycomb -->

Todo? Is this something we can't do now?

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8859036 [details]
Bug 1356053 - Remove unused string resources.

https://reviewboard.mozilla.org/r/131058/#review133662

Please do not remove this. For some versions we enable this EOL notification for specific configurations (We first did for Honeycomb, we recently used it for non-NEON devices). It's a bit odd to have it always in there but re-adding it and re-translating it whenever we need it is also annoying.

Comment 11

[Joni Chan]

Can we get a list of locales for Android too so we can create the proper short links?

Comment 12

[Joe Cheng [:jcheng] (please needinfo)]

ni Delphine as she will likely know this better than I do.

Comment 13

[Nevin Chen(Not active on Bugzilla)]

Hi Roland
I heard that SUMO site is rolling back.
Do we still need to continue with this bug ?

Comment 14

[Erin Lancaster [:elan]]

We are rolling back to Kitsune. Please see Bug 1357606. You do not need to continue with this bug. Thank you!

Comment 15

[Roland Tanglao needinfo please :rolandtanglao, :mohnkuchen, :adobo, :sinigang, :roland]

(In reply to Erin Lancaster [:elan] from comment #14)
> We are rolling back to Kitsune. Please see Bug 1357606. You do not need to
> continue with this bug. Thank you!

:nchen, the fab :elan is correct, please STOP WORK on this bug until Firefox and SUMO teams figure out the way forward