1356865 - Port bug 1348069 and bug 1354785 to TB (IAccessible)

Status: RESOLVED WONTFIX

(Thunderbird :: General, enhancement)

Description

[Richard Marti (:Paenglab)]

Bug 1348069 - Robustness against third-party tampering with MSAA registry settings
Bug 1354785 - Changing manifest files do not update embedded manifest in binary files

Not sure if we should follow but I think this is in a row with bug 1354845.

Frank-Rainer, what do you think? This could be also something for SM.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: manifest.patch

Both FX bugs in one patch.

Comment 2

[Frank-Rainer Grahl (:frg)]

On another bug right now but looking good. Will open a bug for SM later. Did you already port bug 1354020 ? If not you might want to include it too.

Comment 3

[Jorg K (CEST = GMT+2)]

(In reply to Frank-Rainer Grahl from comment #2)
> Did you already port bug 1354020 ?
Yep. Already landed: Bug 1356841.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8858594 [details] [diff] [review]
manifest.patch

Hmm, in the review you can't that you're creating thunderbird.exe.64.manifest. That works, yes? Since the patch first renames thunderbird.exe.manifest:

diff --git a/mail/app/thunderbird.exe.manifest b/mail/app/thunderbird.exe.32.manifest
rename from mail/app/thunderbird.exe.manifest
rename to mail/app/thunderbird.exe.32.manifest

diff --git a/mail/app/thunderbird.exe.manifest b/mail/app/thunderbird.exe.64.manifest
copy from mail/app/thunderbird.exe.manifest
copy to mail/app/thunderbird.exe.64.manifest

Comment 5

[Richard Marti (:Paenglab)]

It works for me and also for FX where it's be done the same way. Have you tried it in your tree? It looks HG is smart enough to remove thunderbird.exe.manifest after the processing. Also when you look at https://hg.mozilla.org/mozilla-central/rev/d4e6fb6fb40a firefox.exe.manifest is there as deleted (also TortoiseHG shows it as deleted).

Comment 6

[Frank-Rainer Grahl (:frg)]

>> It works for me and also for FX where it's be done the same way

Looking at the firefox.exe.64.manifest with TortoiseHG it also retains the full history this way. That is good but also bad because you can't see easily that its a newly created file. Not sure what I would prefer here but will do it your way for SM so that it matches TB.

Comment 7

[Richard Marti (:Paenglab)]

It's a new file, yes. But the code in it has a history and when you want to know why the code is that way, it's easier to have this history. Without history, you are the creator of all that code and have to know all about what and why he does it.

Comment 8

[Jorg K (CEST = GMT+2)]

OK, I looked at this for a bit. The voodoo part comes from here:
https://hg.mozilla.org/mozilla-central/rev/d4e6fb6fb40a#l2.14

Did you ever build this on try?

Comment 9

[Richard Marti (:Paenglab)]

Yes, with https://hg.mozilla.org/try-comm-central/rev/5603d3ec0821. Build is in http://archive.mozilla.org/pub/thunderbird/try-builds/[e-mail]-c17f30f8f2634c6ae32514cc0ae8bc340d8c0741/try-comm-central-win32/

Comment 10

[Richard Marti (:Paenglab)]

Bug 1360371 reverted these changes in m-c -> this port is no more needed.

Comment 11

[Jorg K (CEST = GMT+2)]

Comment on attachment 8858594 [details] [diff] [review]
manifest.patch

Just when I was going to review this ;-)