1356960 - Avoid to allocate WebRenderTextureHost for TextureHost of VideoBridgeParent and VRManagerParent

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

WebRenderTextureHost is created for TextureHosts of VideoBridgeParent and VRManagerParent. It is not necessary.

Comment 1

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #0)
> WebRenderTextureHost is created for TextureHosts of VideoBridgeParent and
> VRManagerParent. It is not necessary.

We need to wrap only TextureHosts of ImageBridgeParent and CompositorBridgeParentBase.

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Avoid to allocate WebRenderTextureHost for TextureHost of VideoBridgeParent and VRManagerParent

Comment 3

[Sotaro Ikeda [:sotaro]]

VideoBridgeParent is used like in the following diagram.
  https://github.com/sotaroikeda/firefox-diagrams/blob/master/media/dom_media_VideoDecoderManager_54.pdf

Comment 4

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Comment on attachment 8858724 [details] [diff] [review]
patch - Avoid to allocate WebRenderTextureHost for TextureHost of VideoBridgeParent and VRManagerParent

Review of attachment 8858724 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/composite/TextureHost.cpp
@@ +96,5 @@
>  {
>    if (!gfxVars::UseWebRender() ||
>        (aFlags & TextureFlags::SNAPSHOT) ||
> +      (aBackend != LayersBackend::LAYERS_WR) ||
> +      (!aDeallocator->UsesImageBridge() && !aDeallocator->AsCompositorBridgeParentBase())) {

VRManagerParent:
UseImageBridge(): false
AsCompositorBridgeParentBase(): nullptr

VideoBridgeParent:
UseImageBridge(): false
AsCompositorBridgeParentBase(): nullptr

CompositorBridgeParent:
UseImageBridge(): false
AsCompositorBridgeParentBase(): this

ImageBridgeParent:
UseImageBridge(): true
AsCompositorBridgeParentBase(): nullptr

Comment 5

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe2358bea17d4bf1a9f37641570af5af65641b15

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/f3878c1cd4d9
Avoid to allocate WebRenderTextureHost for TextureHost of VideoBridgeParent and VRManagerParent r=jerry

Comment 7

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/f3878c1cd4d943c3aef34056adf507e4908b3076