1356944 - Fix external image id allocation of WebRenderTextureHost

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Sotaro Ikeda [:sotaro]]

Current external image id allocation of WebRenderTextureHost is allocated locally. It seems better to be consistent to client side.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix external image id allocation of WebRenderTextureHost

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix external image id allocation of WebRenderTextureHost

Comment 3

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0ae3efc2dd4875dceb09aba43343337f1c88dad

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix external image id allocation of WebRenderTextureHost

Comment 5

[Nicolas Silva [:nical]]

Comment on attachment 8858822 [details] [diff] [review]
patch - Fix external image id allocation of WebRenderTextureHost

Review of attachment 8858822 [details] [diff] [review]:
-----------------------------------------------------------------

It would be great if external image ids were wrapped in a struct like we do for ImageKeys and other id types. Especially since it tends to be passed next to another 64bit integer serial in a number of places. In places where we pass around an optional external id, I would prefer if we pass a Maybe<wr::ExternalImageKey> instead of using zero as a magic value. The overhead is negligible and the intent will be easier to understand.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8858822 [details] [diff] [review]
patch - Fix external image id allocation of WebRenderTextureHost

Review of attachment 8858822 [details] [diff] [review]:
-----------------------------------------------------------------

With nical's suggested changes this seems fine.

Comment 7

[Sotaro Ikeda [:sotaro]]

WrExternalImageId is added by Bug 1356371, I am going to use it.

Comment 8

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #7)
> WrExternalImageId is added by Bug 1356371, I am going to use it.

Bug 1357644 is created for it.

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix external image id allocation of WebRenderTextureHost

Comment 10

[Sotaro Ikeda [:sotaro]]

attachment 8859478 [details] [diff] [review] is based on Bug 1357644.

Comment 11

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix external image id allocation of WebRenderTextureHost

Comment 12

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a28cb88925218b1812e61a1dc166e8f45f9f77a

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/e1e65f91a190
Fix external image id allocation of WebRenderTextureHost r=nical

Comment 14

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/e1e65f91a190