Closed Bug 1356944 Opened 3 years ago Closed 3 years ago

Fix external image id allocation of WebRenderTextureHost

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file, 4 obsolete files)

Current external image id allocation of WebRenderTextureHost is allocated locally. It seems better to be consistent to client side.
Assignee: nobody → sotaro.ikeda.g
Blocks: 1345054
Depends on: 1356960
Attachment #8858735 - Attachment is obsolete: true
Attachment #8858795 - Attachment is obsolete: true
Attachment #8858822 - Flags: review?(jmuizelaar)
Attachment #8858822 - Flags: review?(nical.bugzilla)
Comment on attachment 8858822 [details] [diff] [review]
patch - Fix external image id allocation of WebRenderTextureHost

Review of attachment 8858822 [details] [diff] [review]:
-----------------------------------------------------------------

It would be great if external image ids were wrapped in a struct like we do for ImageKeys and other id types. Especially since it tends to be passed next to another 64bit integer serial in a number of places. In places where we pass around an optional external id, I would prefer if we pass a Maybe<wr::ExternalImageKey> instead of using zero as a magic value. The overhead is negligible and the intent will be easier to understand.
Comment on attachment 8858822 [details] [diff] [review]
patch - Fix external image id allocation of WebRenderTextureHost

Review of attachment 8858822 [details] [diff] [review]:
-----------------------------------------------------------------

With nical's suggested changes this seems fine.
Attachment #8858822 - Flags: review?(jmuizelaar) → review+
WrExternalImageId is added by Bug 1356371, I am going to use it.
(In reply to Sotaro Ikeda [:sotaro] from comment #7)
> WrExternalImageId is added by Bug 1356371, I am going to use it.

Bug 1357644 is created for it.
Depends on: 1357644
Attachment #8858822 - Attachment is obsolete: true
Attachment #8858822 - Flags: review?(nical.bugzilla)
Attachment #8859491 - Flags: review?(nical.bugzilla)
Attachment #8859491 - Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/e1e65f91a190
Fix external image id allocation of WebRenderTextureHost r=nical
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.