Closed Bug 1357392 Opened 3 years ago Closed 3 years ago

Update webrender to f3fa3481aac63ac93c6ccbe805379875e24e5b77.


(Core :: Graphics: WebRender, enhancement)

Not set



Tracking Status
firefox55 --- fixed


(Reporter: kats, Assigned: kats)



(Whiteboard: [gfx-noted])


(7 files)

+++ This bug was initially created as a clone of Bug #1355475 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

WR @ f687ff6c3df63a6846f7f96c71c4d76b34f7198e

Orange across the board. The last good rev is 07b6c6a1f93b5d8af1dd9ae825906dcf5c310810, so the regression range is:

*   f687ff6 Auto merge of #1123 - Gankro:profipc, r=kvark
| * cb0bc28 Add profiling for IPC overhead
* 1c59cd6 Auto merge of #1127 - MortimerGoro:get_shader_precision, r=kvark
* 112af22 Implement GetShaderPrecisionFormat WebGL command
WR @ 1c59cd6 is green [1]. Therefore the regression is coming from cb0bc28.

Gankro provided me with the fixes for the failures - we needed to regenerate the FFI header and update the IPC code for the new fields. With that the try push is green:
Summary: Update webrender to 07b6c6a1f93b5d8af1dd9ae825906dcf5c310810 → Future webrender update bug
WR @ dc0e7487d54377aadd43678b3ad6e2aade2d2e71

Green with compile fixes.
Blocks: 1357644
WR @ 04eeee4593c11a0d9c934722896c67aa5ddd9554

Bustage from add_raw_font changes. Looks like I need to add some zeros.
WR @ 04eeee4593c11a0d9c934722896c67aa5ddd9554 with the aforementioned zeros.

Blocks: 1357952
In particular Lee wants 21f2946 for the add_raw_font API changes.
Summary: Future webrender update bug → Update webrender to f3fa3481aac63ac93c6ccbe805379875e24e5b77.
Attachment #8860056 - Flags: review?(hshih)
Attachment #8860057 - Flags: review?(hshih)
Assignee: nobody → bugmail
Comment on attachment 8860055 [details]
Bug 1357392 - Update IPC code for new fields in struct added in cb0bc28.
Attachment #8860055 - Flags: review?(bugmail) → review+
Comment on attachment 8860058 [details]
Bug 1357392 - Update calls to add_raw_font for API change in 21f2946.

This one's fine for now. Lee has a patch to plumb things through properly that can go on top.
Attachment #8860058 - Flags: review+
Comment on attachment 8860052 [details]
Bug 1357392 - Update webrender to f3fa3481aac63ac93c6ccbe805379875e24e5b77.
Attachment #8860052 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8860053 [details]
Bug 1357392 - Update Cargo.lock/Cargo.toml files and re-generate FFI header.
Attachment #8860053 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8860054 [details]
Bug 1357392 - Re-vendor third-party rust dependencies.
Attachment #8860054 - Flags: review?(jmuizelaar) → review+
Attachment #8860058 - Flags: review?(lsalzman) → review+
Comment on attachment 8860056 [details]
Bug 1357392 - Update for removal of release callback function in 86d4255.
Attachment #8860056 - Flags: review?(hshih) → review+
Comment on attachment 8860057 [details]
Bug 1357392 - Update callback functions for new parameter added in d733af2.

::: gfx/webrender_bindings/src/
(Diff revision 1)
>  }
>  impl ExternalImageHandler for WrExternalImageHandler {
>      fn lock(&mut self,
> -            id: ExternalImageId)
> +            id: ExternalImageId,
> +            _channel_index: u8)

Thanks, I will use the channel_index to select the correct data plane in yuv textureHost.
Attachment #8860057 - Flags: review?(hshih) → review+
Pushed by
Update webrender to f3fa3481aac63ac93c6ccbe805379875e24e5b77. r=jrmuizel,jerry,lsalzman
Update IPC code for new fields in struct added in cb0bc28. r=kats
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.