1357976 - When importing an address book, selecting text file(LDIF, .tab, .csv, .txt) causes the action buttons to disappear from view. (Thunderbird 52.0.1 - Japanese/Italian/German version)

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[victorlieng]

Attachment: AddressBookImportWindow.PNG

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; Trident/7.0; .NET4.0E; .NET4.0C; .NET CLR 3.5.30729; .NET CLR 2.0.50727; .NET CLR 3.0.30729; rv:11.0) like Gecko

Steps to reproduce:

(In Japanese version of Thunderbird 52.0.1)

Open Address Book
Tools -> Import -> Choose "Address Book(A)" -> Next
Choose Text File(LDIF, .tab, .csv, .txt) 



Actual results:

The Go Back, Next and Cancel buttons cannot be seen in the Windows.


Expected results:

The Go Back, Next and Cancel buttons should be visible to allow the user to click on them.

Comment 1

[Jorg K (CEST = GMT+2)]

Does it work in an en-US version?

Comment 2

[victorlieng]

(In reply to Jorg K (GMT+2) from comment #1)
> Does it work in an en-US version?

Seems to be fine in the en-US version.
  
In Japanese, the other options besides "Text File(LDIF, .tab, .csv, .txt)" are fine.  However, the description text for the "Text File" option is takes up two rows and it seems to be pushing the action buttons down and out of view.

Comment 3

[Jorg K (CEST = GMT+2)]

Richard, should we make the panel bigger or refer this to the Japanese localisers (Mozilla Localizations :: ja)?

Comment 4

[Richard Marti (:Paenglab)]

This is a issue I've seen multiple times. The height is calculated with one line text and then is uses two lines and everything below is shifted down. Let me look this evening if I can find a solution.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: importDialog.patch

I installed the Japanese importer dtd and properties files and can confirm the issue. But I can't say why this happens, maybe because of other font sizes with Japanese. en-US has two line descriptions too.

I added a min-height to the containing box and now there is no jumping anymore. With 28em it stopped jumping and I gave 2em more to be on the secure side.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 8861131 [details] [diff] [review]
importDialog.patch

I didn't try it but I'm sure you know what you're doing ;-)

Comment 7

[Richard Marti (:Paenglab)]

https://hg.mozilla.org/comm-central/rev/3757d3096b68317300bcd08290977a06ef9cdf91

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 8861131 [details] [diff] [review]
importDialog.patch

I wanted to wait for a Japanese Daily but Windows was busted yesterday. Jörg wants to do some uplifts, so asking now.

[Approval Request Comment]
User impact if declined: Not usable buttons on some locales
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 9

[Jorg K (CEST = GMT+2)]

Comment on attachment 8861131 [details] [diff] [review]
importDialog.patch

Unrelated: Waiting for uplift of bug 1358840 before uplift.

Comment 10

[Richard Marti (:Paenglab)]

Tested today ja-JP-mac Daily build and nothing jumped.

Comment 11

[Jorg K (CEST = GMT+2)]

Beta (TB 54):
https://hg.mozilla.org/releases/comm-beta/rev/56e9ca0a5e80fdb0beb425126e55b9023bf5b28a

Comment 13

[Jorg K (CEST = GMT+2)]

TB 52 ESR:
https://hg.mozilla.org/releases/comm-esr52/rev/5fe06d2905db481ff7ec2482297100c6acdaaa1f

Comment 14

[Remy Mentasti]

I don't know if the patch solve the problem for Japanese locale only or for all languages.
In the first case, italian locale is affected too.

Comment 15

[Remy Mentasti]

Attachment: italian locale - Import address book from text file - Buttons are not shown or only partially shown

Comment 16

[Richard Marti (:Paenglab)]

(In reply to Remy Mentasti from comment #15)
> Created attachment 8870443 [details]
> italian locale - Import address book from text file - Buttons are not shown
> or only partially shown

If this is TB 52, wait for the next TB 52 version to check. It landed today in this channel.

Comment 17

[Jorg K (CEST = GMT+2)]

In general the panel will be larger, so the Italian version will also be fixed. The fix will be in TB 52.2 in a few weeks.

Comment 18

[Remy Mentasti]

(In reply to Jorg K (GMT+2) from comment #17)
> In general the panel will be larger, so the Italian version will also be
> fixed. The fix will be in TB 52.2 in a few weeks.

Thanks for the clarification.