Closed
Bug 1358877
Opened 8 years ago
Closed 8 years ago
Remove aurora channel from TB/Calendar source
Categories
(Thunderbird :: Build Config, enhancement)
Thunderbird
Build Config
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 55.0
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(1 file, 1 obsolete file)
|
9.60 KB,
patch
|
Paenglab
:
review+
Fallen
:
review+
|
Details | Diff | Splinter Review |
This bug is to remove the aurora channel from the tree. I think we leave the branding/aurora files as we don't know what we want to do with the artwork etc. Or we could rename it to earlybird to be neutral on naming.
|
Assignee | |
Comment 1•8 years ago
|
||
I added Philipp for r? because I'm not sure if I changed the calendar/lightning/Makefile.in logic correctly.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8860733 -
Flags: review?(philipp)
Attachment #8860733 -
Flags: review?(jorgk)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8860733 [details] [diff] [review]
noAurora.patch
Review of attachment 8860733 [details] [diff] [review]:
-----------------------------------------------------------------
Yes, this is OK, thanks.
::: calendar/lightning/Makefile.in
@@ +14,5 @@
> DEFINES += -DLIGHTNING_PRERELEASE_VERSION=1
> endif
>
> +# Enable nightly updates on nightly channel
> +ifeq (nightly,$(MOZ_UPDATE_CHANNEL))
This is correct.
ifeq (nightly,$(subst aurora,nightly,$(MOZ_UPDATE_CHANNEL)))
would substitute the string "aurora" with "nightly" if found in $(MOZ_UPDATE_CHANNEL), see:
https://www.gnu.org/software/make/manual/html_node/Text-Functions.html
Attachment #8860733 -
Flags: review?(philipp)
Attachment #8860733 -
Flags: review?(jorgk)
Attachment #8860733 -
Flags: review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
Fixed the reviewer.
Attachment #8860733 -
Attachment is obsolete: true
Attachment #8860742 -
Flags: review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8860742 [details] [diff] [review]
noAurora.patch
r=philipp for the calendar part.
Attachment #8860742 -
Flags: review+
|
|
||
Comment 5•8 years ago
|
||
No need for a new patch just to change the reviewers, I can do that at checkin.
|
|
||
Comment 6•8 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
You need to log in
before you can comment on or make changes to this bug.
Description
•