Closed Bug 1358947 Opened 4 years ago Closed 4 years ago

Make eslint "max-nested-callbacks" rule an error

Categories

(Firefox Build System :: Lint and Formatting, defect)

3 Branch
defect
Not set
normal

Tracking

(firefox53 wontfix, firefox54 wontfix, firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox53 --- wontfix
firefox54 --- wontfix
firefox55 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

In bug 1358041 comment 8, standard8 suggested moving the `"max-nested-callbacks": ["error", 8]` rule from browser/.eslintrc.js to the mozilla/recommended rules.
Comment on attachment 8860789 [details]
Bug 1358947 - Make eslint "max-nested-callbacks" rule an error.

https://reviewboard.mozilla.org/r/132748/#review135690

Looks good, one minor issue. Also remember the version issues I mentioned in bug 1358949.

::: tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js:163
(Diff revision 1)
>  
>      // No single if block inside an else block
>      "no-lonely-if": "error",
>  
> +    // Maximum depth callbacks can be nested.
> +    "max-nested-callbacks": ["error", 10],

Please can you add this in alphabetical order, just under "max-depth" (I know, its not perfect atm, I'll get a mentored bug filed on it)
Attachment #8860789 - Flags: review?(standard8) → review+
(In reply to Mark Banner (:standard8) from comment #2)
> Please can you add this in alphabetical order, just under "max-depth" (I
> know, its not perfect atm, I'll get a mentored bug filed on it)

Thanks! I'll move "max-nested-callbacks" to the right position when I land the patch.
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b8241081386
Make eslint "max-nested-callbacks" rule an error. r=standard8
https://hg.mozilla.org/mozilla-central/rev/2b8241081386
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Testing → Firefox Build System
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.