1358947 - Make eslint "max-nested-callbacks" rule an error

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Chris Peterson [:cpeterson]]

In bug 1358041 comment 8, standard8 suggested moving the `"max-nested-callbacks": ["error", 8]` rule from browser/.eslintrc.js to the mozilla/recommended rules.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1358947 - Make eslint "max-nested-callbacks" rule an error.

eslint's default max-nested-callbacks threshold is 10, but now we make it an error. We could further lower the max-nested-callbacks threshold globally to 8, like browser/.eslintrc.js, but that would require adding suppression comments in (two) more .js test files. 10 seems good enough for now since it's the eslint default.

We need to specify max-nested-callbacks in accessible/.eslintrc because it doesn't inherit the mozilla/recommended rules.

Also bump the eslint-plugin-mozilla version because we modified the mozilla/recommended rules.

Review commit: https://reviewboard.mozilla.org/r/132748/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132748/

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8860789 [details]
Bug 1358947 - Make eslint "max-nested-callbacks" rule an error.

https://reviewboard.mozilla.org/r/132748/#review135690

Looks good, one minor issue. Also remember the version issues I mentioned in bug 1358949.

::: tools/lint/eslint/eslint-plugin-mozilla/lib/configs/recommended.js:163
(Diff revision 1)
>  
>      // No single if block inside an else block
>      "no-lonely-if": "error",
>  
> +    // Maximum depth callbacks can be nested.
> +    "max-nested-callbacks": ["error", 10],

Please can you add this in alphabetical order, just under "max-depth" (I know, its not perfect atm, I'll get a mentored bug filed on it)

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Mark Banner (:standard8) from comment #2)
> Please can you add this in alphabetical order, just under "max-depth" (I
> know, its not perfect atm, I'll get a mentored bug filed on it)

Thanks! I'll move "max-nested-callbacks" to the right position when I land the patch.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b8241081386
Make eslint "max-nested-callbacks" rule an error. r=standard8

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2b8241081386