Closed Bug 1359989 Opened 7 years ago Closed 5 years ago

uninterruptible reflow at _openPanel@resource:///modules/UrlbarView.jsm

Categories

(Firefox :: General, defect, P4)

Product:
Firefox
Component:
General
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 70
Project Flags:
Performance Impact medium

People

(Reporter: marco, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: perf, Whiteboard: [ohnoreflow][reserve-photon-performance]) 

Here's the stack:

openPopupAtScreen@chrome://global/content/bindings/popup.xml:70:15
openContextMenu@chrome://browser/content/nsContextMenu.js:58:3
receiveMessage@chrome://browser/content/tabbrowser.xml:5010:15
Flags: qe-verify?
Priority: -- → P2
Component: Untriaged → General
Whiteboard: [ohnoreflow][qf][photon-performance] → [ohnoreflow][qf:p1][photon-performance]
Priority: P2 → P3
Whiteboard: [ohnoreflow][qf:p1][photon-performance] → [ohnoreflow][qf:p1][reserve-photon-performance]
Flags: qe-verify? → qe-verify-
Whiteboard: [ohnoreflow][qf:p1][reserve-photon-performance] → [ohnoreflow][qf:p2][reserve-photon-performance]
I think this one is actually caused by platform code. Around http://searchfox.org/mozilla-central/rev/3a3af33f513071ea829debdfbc628caebcdf6996/layout/xul/nsXULPopupManager.cpp#778 all the nsXULPopupManager::ShowPopup* methods call GetPopupFrameForContent with true as the aShouldFlush parameter.

We also hit this with a different stack when opening the awesomebar panel:

	"openPopup@chrome://global/content/bindings/popup.xml:66:15",
	"_openAutocompletePopup@chrome://browser/content/urlbarBindings.xml:1889:11",
	"openAutocompletePopup@chrome://browser/content/urlbarBindings.xml:1803:11",
	"openPopup@chrome://global/content/bindings/autocomplete.xml:393:13",
	"set_popupOpen@chrome://global/content/bindings/autocomplete.xml:103:10",
	"notifyResults@file:///<appdir>/components/UnifiedComplete.js:2193:5",
Priority: P3 → P4
Keywords: perf
I cannot reproduce this one anymore.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WORKSFORME

(In reply to Mike Conley (:mconley) (:⚙️) from comment #3)

I cannot reproduce this one anymore.

browser/base/content/test/performance/browser_urlbar_search.js has two stacks referring to this bug.

Status: RESOLVED → REOPENED
Flags: needinfo?(mconley)
Resolution: WORKSFORME → ---

So it does! Back into the queue it goes.

Flags: needinfo?(mconley)
Summary: 1.00ms uninterruptible reflow at openPopupAtScreen@chrome://global/content/bindings/popup.xml:70:15 → uninterruptible reflow at _openAutocompletePopup@chrome://browser/content/urlbarBindings.xml
Depends on: 1551598
Summary: uninterruptible reflow at _openAutocompletePopup@chrome://browser/content/urlbarBindings.xml → uninterruptible reflow at _openPanel@resource:///modules/UrlbarView.jsm

Should be fixed by 1551598

Status: REOPENED → RESOLVED
Closed: 7 years ago → 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Performance Impact: --- → P2
Whiteboard: [ohnoreflow][qf:p2][reserve-photon-performance] → [ohnoreflow][reserve-photon-performance]
You need to log in before you can comment on or make changes to this bug.