1360435 - Update webrender to b9f7e2926731f0ed831108456c219cae30a7e4c8..

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Jerry Shih[:jerry] (UTC+8) (inactive)]

+++ This bug was initially created as a clone of Bug #1357392 +++

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #0)
> I'm filing this as a placeholder bug for the next webrender update. I may be
> running a cron script [1] that does try pushes with webrender update
> attempts, so that we can track build/test breakages introduced by webrender
> on a rolling basis. This bug will hold the try push links as well as
> dependencies filed for those breakages, so that we have a better idea going
> into the update of what needs fixing. I might abort the cron job because
> once things get too far out of sync it's hard to fully automate fixing all
> the breakages.
> 
> When we are ready to actually land the update, we can rename this bug and
> use it for the update, and then file a new bug for the next "future update".
> 
> [1]
> https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=24e286cb9fe97ddad39c54a897411646bbc487db

Comment 2

[Jerry Shih[:jerry] (UTC+8) (inactive)]

The WR 384e508e64b8aa73ec7c55d91e985bd596379b82 contains some yuv image and blob image changes.

Comment 3

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: update WR to 384e508e64b8aa73ec7c55d91e985bd596379b82.

MozReview-Commit-ID: LW4PTjCFMlr

Comment 4

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: update WR bindings for 384e508e64b8aa73ec7c55d91e985bd596379b82.

Update for blob image and yuv image interface changes.
There is no change for |./mach vendor rust|.

Hi nical, the ImageStore is not used now. I just use "_" prefix for that.

Comment 5

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Comment on attachment 8862728 [details] [diff] [review]
update WR to 384e508e64b8aa73ec7c55d91e985bd596379b82.

I would like to add more commits for WR.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Note that I already filed bug 1359744 for tracking the next WR update. I'm happy to do it there if you know what version of WR you would like to update to.

Comment 7

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Hi kats,
At least, I need this https://github.com/servo/webrender/pull/1176 pull request. Our code-gen needs this info to generate the enum class in c++. But it's waiting for reviewing.

I will also attach the binding and WebrenderAPI updating code here. Maybe your merging works need these changes.

Comment 8

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: update WR bindings for 384e508e64b8aa73ec7c55d91e985bd596379b82. v2

Hi nical, this commit also try to add the yuv* functions in WebRenderAPI.

Update for blob image and yuv image interface changes.
Add wr_dp_push_yuv_*_image() functions in WebRenderAPI.

Comment 9

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: update WR to b9f7e2926731f0ed831108456c219cae30a7e4c8.

Comment 10

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: update WR bindings for b9f7e2926731f0ed831108456c219cae30a7e4c8.

Hi nical,
The implementation of the blob image renderer is empty now. I haven't caught up
the new blob interface. So, I just remove the old blob image code in bindings.

----
Update for blob image and yuv image interface changes.
Add wr_dp_push_yuv_*_image() functions in WebRenderAPI.

There is no change for |./mach vendor rust|.

Comment 11

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Hi kats,
This is the WR version I need now. I will continue my works base on this update.
You could pick up the binding changes bug 1359744 and make this bug duplicated.

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Ok. I'll probably split your patches so that bug 1359744 has the minimum amount of changes needed to pull the WR update and still compile/pass the tests. And then we can use this patch for the extra stuff that builds on top of that. Does that sound reasonable?

Comment 13

[Kartikaya Gupta (email:[e-mail])]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #12)
> Ok. I'll probably split your patches so that bug 1359744 has the minimum
> amount of changes needed to pull the WR update and still compile/pass the
> tests. And then we can use this patch for the extra stuff that builds on top
> of that. Does that sound reasonable?

I changed my mind. Since you already have the patches I'm happy to just land these. We can leave bug 1359744 to track the next WR update.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/efda56c9cb28
Update WR to b9f7e2926731f0ed831108456c219cae30a7e4c8. r=kats
https://hg.mozilla.org/projects/graphics/rev/14b78eff0a90
Update WR bindings for b9f7e2926731f0ed831108456c219cae30a7e4c8. r=kats

Comment 15

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/efda56c9cb28
https://hg.mozilla.org/mozilla-central/rev/14b78eff0a90