Closed Bug 1360532 Opened 2 years ago Closed 2 years ago

Hover state should apply to all textbox fields

Categories

(Firefox :: Preferences, defect, P2)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1377021
Firefox 57

People

(Reporter: hani.yacoub, Unassigned)

References

()

Details

Attachments

(1 file)

[Affected versions]: 
Nightly 55.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Ubuntu 16.10 and Mac OS X 10.12

[Steps to reproduce]:
1. Launch firefox, go to about:config and search for "browser.preferences.search" and set it value to true.
2. Go to "about:preferences" and hover on the "Search" field.

[Expected result]:
Hover state should be applied on the "Search" field and the border should become darker according to the documentation.

[Actual result]:
Hover state isn't applied on the "Search" field.
Blocks: 1357285
Whiteboard: [photon-preference]
Assignee: nobody → rchien
Status: NEW → ASSIGNED
Flags: qe-verify+
QA Contact: hani.yacoub
According spec https://mozilla.invisionapp.com/share/ZDAGPK3AF#/screens/218928188, we're going to introduce a new hover state color (dark gray). At the time I found that the checkbox-check color has defined in common.css which is used widely by entire Firefox browser. Can we accept to have a preference specific style override in preferences.inc.css?
Flags: needinfo?(mconley)
Pushed patch for asking first round review.

Note that I only apply the new hover state highlight for search input (a.k.a textbox[type="search"]) but not for other textbook in preferences panel. I think it would be safe if we apply all textbox in pref panel (it should be in the scope in visual refresh but it's good to go in this bug IMO).
Comment on attachment 8864061 [details]
Bug 1360532 - Hover state is not applied on the "Search" field

https://reviewboard.mozilla.org/r/135778/#review138902

::: browser/themes/shared/incontentprefs/preferences.inc.css:57
(Diff revision 1)
> +.main-content textbox[type="search"]:hover {
> +  border-color: #6a6868;
> +}

This should probably be consistent throughout all textboxes, so I would probably add it here:
https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css#475

::: browser/themes/shared/incontentprefs/preferences.inc.css:61
(Diff revision 1)
> +.main-content textbox[type="search"][focused="true"] {
> +  border-color: var(--in-content-border-focus);
> +}

This is already covered by: https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/shared/in-content/common.inc.css#481
Priority: -- → P1
Per offline discussion with Helen, this feature will be moved to visual refresh scope. The hover state should apply to all input fields in about:preferences page but not only apply to a single search input field.

I'm going to unassign myself and postpone this work until visual refresh spec is more clear for all hover state.
Assignee: rchien → nobody
Blocks: 1357306
No longer blocks: 1357285
Status: ASSIGNED → NEW
Priority: P1 → P2
Summary: Hover state is not applied on the "Search" field → Hover state should apply to all textbox fields
Target Milestone: --- → Firefox 57
Sounds like comment 5 answered the question in comment 1.
Flags: needinfo?(mconley)
Comment on attachment 8864061 [details]
Bug 1360532 - Hover state is not applied on the "Search" field

https://reviewboard.mozilla.org/r/135778/#review139332

Apparently, this is a more general change that we want in about:preferences, so clearing review request.
Attachment #8864061 - Flags: review?(mconley)
We are targetting 56 for search.
Target Milestone: Firefox 57 → Firefox 56
Target Milestone: Firefox 56 → Firefox 57
Version: 55 Branch → unspecified
No longer blocks: 1357306
Status: NEW → RESOLVED
Closed: 2 years ago
Flags: qe-verify+
QA Contact: hani.yacoub
Resolution: --- → DUPLICATE
Whiteboard: [photon-preference]
Duplicate of bug: 1377021
You need to log in before you can comment on or make changes to this bug.