|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
- FreeBSD has no default LLVM version downstream atm but folks try to reap old unused. - OpenBSD has only one, unfortunately, affected by bug 1357889. - Bug 1356991 is unclear whether the new default would be limited to automation (a la --enable-rust days before 53.0) or for every build on mozilla-central. $ ./mach bootstrap [...] Stylo is an experimental rewrite of the Gecko style system in Rust to be faster and make better use of modern computer hardware. Would you like to download packages for working on Stylo? If you're not sure, select "No". 1. Yes 2. No Your choice: 1 Error running mach: ['bootstrap'] The error occurred in code that was called by the mach command. This is either a bug in the called code itself or in the way that mach is calling it. You should consider filing a bug for this issue. If filing a bug, please include the full output of mach, including this error message. The details of the failure are as follows: NotImplementedError: mozboot.base does not yet implement ensure_stylo_packages() File "python/mozboot/mozboot/mach_commands.py", line 26, in bootstrap bootstrapper.bootstrap() File "python/mozboot/mozboot/bootstrap.py", line 296, in bootstrap self.instance.ensure_stylo_packages(state_dir) File "python/mozboot/mozboot/base.py", line 272, in ensure_stylo_packages % __name__)
Comment on attachment 8863095 [details] Bug 1360781 - Add Stylo dependencies for ./mach bootstrap on FreeBSD. https://reviewboard.mozilla.org/r/134926/#review138080 r=me, I guess, but see below. ::: python/mozboot/mozboot/openbsd.py:58 (Diff revision 1) > # TODO: Figure out what not to install for artifact mode > # we use -z because there's no other way to say "any autoconf-2.13" > self.run_as_root(['pkg_add', '-z'] + self.browser_packages) > + > + def ensure_stylo_packages(self, state_dir): > + self.run_as_root(['pkg_add', 'llvm']) I am just going to trust that this will install the version of LLVM that we need, and not some random, potentially incompatible, version based on the whims of the LLVM packager. Is that trust justified?
Comment on attachment 8863095 [details] Bug 1360781 - Add Stylo dependencies for ./mach bootstrap on FreeBSD. https://reviewboard.mozilla.org/r/134926/#review138080 > I am just going to trust that this will install the version of LLVM that we need, and not some random, potentially incompatible, version based on the whims of the LLVM packager. Is that trust justified? No, it assumes with enough dogfooding Stylo would build against future LLVM releases (e.g., 5.0.0 or even 4.0.1). Let's drop OpenBSD bits for now.
Llvm is already installed by https://dxr.mozilla.org/mozilla-central/source/python/mozboot/mozboot/openbsd.py#25 anyway.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/956a9f0d5b7c Add Stylo dependencies for ./mach bootstrap on FreeBSD. r=froydnj