1360964 - Either promote the taskcluster Mac debug build to tier-1 or revert having the tier-1 Mac debug tests run on the tier-2 build

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P1)

Description

[Phil Ringnalda (:philor)]

Apparently we now (and perhaps for two months, if bug 1330310 was the one that made this change) run our Mac debug tests on the Taskcluster Mac debug build.

The Taskcluster Mac debug build is marked as being tier-2, which means that any developer is 100% free to break it at any time, and sheriffs may not back out the patch that broke it.

Having tier-1 tests depend on a tier-2 build is thus totally unacceptable. Please either promote the build to tier-1, or go back to running the tests on the tier-1 buildbot build.

Comment 1

[Phil Ringnalda (:philor)]

Since bug 1330310 landed during the 54 cycle, if that was the one then we are probably also running Mac debug tests on mozilla-beta on the Taskcluster build, *which does not exist on mozilla-beta* so we just aren't running any Mac debug tests at all.

Comment 2

[Chris Cooper [:coop] (he/him)]

AFAIK there's no reason the TC debug build should not simply replace the buildbot version at tier 1.

Kim: can you confirm, please?

Comment 3

[Kim Moir [:kmoir] ET]

Yes, I agree.  This work is going to be done as part of bug 1353376, bug 1350413 and bug 1358188

Comment 4

[Ryan VanderMeulen [:RyanVM]]

What's the timeframe on that work, Kim?

Comment 5

[Kim Moir [:kmoir] ET]

I'm looking at this current bug as a separate issue now, determining why macosx64 cross compile builds aren't enabled on m-b and promoting to tier 1

Comment 6

[Kim Moir [:kmoir] ET]

Attachment: bug1360964m-i.patch

patch for m-i

Comment 7

[Kim Moir [:kmoir] ET]

Attachment: bug1360964m-b.patch

pat for m-b to enable macosx tc debug builds and mark as tier1

Comment 8

[Justin Wood (:Callek)]

Comment on attachment 8863378 [details] [diff] [review]
bug1360964m-i.patch

Review of attachment 8863378 [details] [diff] [review]:
-----------------------------------------------------------------

VERY close.

Need to add 'macosx64' to that linux if right below that in target_tasks. Otherwise we're enabling the opt cross compile stuff too, which we don't need on beta.

Comment 9

[Justin Wood (:Callek)]

Comment on attachment 8863380 [details] [diff] [review]
bug1360964m-b.patch

Review of attachment 8863380 [details] [diff] [review]:
-----------------------------------------------------------------

Same issue as the m-i patch

Comment 10

[Kim Moir [:kmoir] ET]

Attachment: bug1360964m-i-2.patch

Comment 11

[Kim Moir [:kmoir] ET]

Attachment: bug1360964m-b-2.patch

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Thanks for jumping on this, Kim.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6dc5a55d2f0e
Promote Taskcluster Mac debug builds to Tier 1 and make sure that tests are scheduled off them. r=Callek

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2adccdb8d0de

Comment 15

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/6dc5a55d2f0e