Closed
Bug 1361009
Opened 8 years ago
Closed 8 years ago
Remove MOZ_WIDGET_GONK from the profiler
Categories
(Core :: Gecko Profiler, enhancement)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
20.02 KB,
patch
|
jseward
:
review+
|
Details | Diff | Splinter Review |
B2G is dead, and MOZ_WIDGET_GONK code is being excised elsewhere, e.g. bug 1355752, bug 1357323.
|
Assignee | |
Comment 1•8 years ago
|
||
This removes the need for PROFILER_LIKELY_MEMORY_CONSTRAINED.
The patch also removes PROFILE_JAVA, USE_FAULTY_LIB, CONFIG_CASE_1,
CONFIG_CASE_2 and replaces all their uses with GP_OS_linux or GP_OS_android.
Finally, the patch removes a bogus |defined(GP_OS_darwin)| condition in
platform-linux-lul.cpp.
Attachment #8863315 -
Flags: review?(jseward)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•8 years ago
|
||
jseward: review ping!
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8863315 [details] [diff] [review]
Remove MOZ_WIDGET_GONK from the profiler
Review of attachment 8863315 [details] [diff] [review]:
-----------------------------------------------------------------
Looks fine.
Attachment #8863315 -
Flags: review?(jseward) → review+
|
|
Assignee | |
Comment 4•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bad6738692f172157834017ef0215a6b8f5c444b
Bug 1361009 - Remove MOZ_WIDGET_GONK from the profiler. r=jseward.
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•