Closed Bug 1361009 Opened 4 years ago Closed 4 years ago

Remove MOZ_WIDGET_GONK from the profiler

Categories

(Core :: Gecko Profiler, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

B2G is dead, and MOZ_WIDGET_GONK code is being excised elsewhere, e.g. bug 1355752, bug 1357323.
This removes the need for PROFILER_LIKELY_MEMORY_CONSTRAINED.

The patch also removes PROFILE_JAVA, USE_FAULTY_LIB, CONFIG_CASE_1,
CONFIG_CASE_2 and replaces all their uses with GP_OS_linux or GP_OS_android.

Finally, the patch removes a bogus |defined(GP_OS_darwin)| condition in
platform-linux-lul.cpp.
Attachment #8863315 - Flags: review?(jseward)
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
jseward: review ping!
Comment on attachment 8863315 [details] [diff] [review]
Remove MOZ_WIDGET_GONK from the profiler

Review of attachment 8863315 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine.
Attachment #8863315 - Flags: review?(jseward) → review+
https://hg.mozilla.org/mozilla-central/rev/bad6738692f1
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
No longer blocks: 1369194
You need to log in before you can comment on or make changes to this bug.