Closed
Bug 1361287
Opened 9 years ago
Closed 3 years ago
Show automigration description on the activity stream page
Categories
(Firefox :: New Tab Page, enhancement, P5)
Firefox
New Tab Page
Tracking
()
RESOLVED
INVALID
Firefox 56
People
(Reporter: gasolin, Unassigned)
References
()
Details
(Whiteboard: [photon-onboarding])
Based on UX spec bug 1360109, we need show the migration description on new tab page instead of on the door hanger(notification).
| Reporter | ||
Comment 1•9 years ago
|
||
Things need to do in this bug
- show with image & description
- gray the top sites container
- do nothing when user select `keep` button
- trigger undo action when user select `undo` button
Depends on: 1361286
| Reporter | ||
Updated•9 years ago
|
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Priority: -- → P1
Updated•9 years ago
|
Whiteboard: [photon-onboarding]
Updated•9 years ago
|
Flags: qe-verify+
QA Contact: jwilliams
| Reporter | ||
Comment 2•9 years ago
|
||
Here's what the sample UI in HTML looks like http://codepen.io/gasolin/pen/aWLVYL
Updated•9 years ago
|
Target Milestone: --- → Firefox 56
| Reporter | ||
Comment 3•9 years ago
|
||
The flow (defined in bug 1361286) includes
* Send message in `page.js` to remotepage `aboutNewTab.jsm`(NewTab:MaybeShowUndoMessage)
* `page.js` show the migrated description while receive `NewTab:Automigrated` message from `aboutNewTab.jsm`
* trigger keep action (NewTab:MigrationIsDone) when user select the `Keep It` button
* hide all messages while receive `NewTab:HideMigrationMessage` message from `aboutNewTab.jsm`
* show manual import message while receive `NewTab:MigrationIsReverted` message
* trigger undo action (NewTab:UndoAutoMigration) when user select undo button
* trigger manual import action (NewTab:ManualMigration) when user select manual import link
The newtab page structure Need mapping to redux structure
Here's the workflow-correct screencast from bug 1361286
http://g.recordit.co/DdA6RDBlrF.gif
Summary: Show migration description on new tab page → Show automigration description on the activity stream page
| Reporter | ||
Comment 4•9 years ago
|
||
correspondent bug is opened on github https://github.com/mozilla/activity-stream/issues/2616
| Reporter | ||
Comment 5•9 years ago
|
||
patch is attached on github, found way to test. adding tests now
| Reporter | ||
Updated•9 years ago
|
Updated•9 years ago
|
Priority: P3 → P5
Updated•4 years ago
|
Severity: normal → S3
Comment 6•3 years ago
|
||
I don't think there's anything left to do here.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•