Closed Bug 1361370 Opened 3 years ago Closed 3 years ago

It is not possible to override the values of MOZ_SOURCE_CHANGESET and MOZ_SOURCE-REPO in Seamonkey builds

Categories

(SeaMonkey :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.52

People

(Reporter: wgianopoulos, Assigned: wgianopoulos)

References

Details

(Keywords: regression)

Attachments

(1 file, 3 obsolete files)

For a Frefox build it si possible to override the values for MOZ_SOURCE_CHANGESET and MOZ_SOURCE_REPO for a custom build by defining these vaues in system environment variables.  In fact the Seamonkey build makes use of this feature to ensure that about:buildconfig reflects the Seamonkey repository and changeset rather than the gecko ones.  Unfortunately, it does this in an unconditional manner.  It should only be defining these environment variables if they are not already defined, to permit the builder to override these values.
Blocks: 1267270
Keywords: regression
Ooops had wrong reviewer and not really a checkin ready comment.
Attachment #8863763 - Flags: review?(mh+mozilla)
Attachment #8863752 - Attachment is obsolete: true
Attachment #8863752 - Flags: review?(aleth)
To make it clear why I do that, with this fix I can make about:buildconfig show the comm-central changeset my build was based from and also have a link to my build page which documents the additional patches I includue in my builds.
I accomplish this by including the following in my build script:

export MOZ_INCLUDE_SOURCE_INFO=1
export MOZ_SOURCE_CHANGESET=`cat .changeset`
export MOZ_SOURCE_REPO=https://hg.mozilla.org/comm-central

the .changset file contains the changset from before my patches were applied.
I suppose maybe is should have also updated the comment but looking for a rview first.

I was thinking perhaps changing the comment to:

# Ensure the comm-* values are used unless overridden via environment variables.].
I suppose maybe is should have also updated the comment but looking for a rview first.

I was thinking perhaps changing the comment to:
# Ensure the comm-* values are used unless overridden via environment variables.(In reply to Bill Gianopoulos [:WG9s] from comment #5)
> I suppose maybe is should have also updated the comment but looking for a
> rview first.
> 
> I was thinking perhaps changing the comment to:
> 
> # Ensure the comm-* values are used unless overridden via environment
> variables.].
Attachment #8863763 - Attachment is obsolete: true
Attachment #8863763 - Flags: review?(mh+mozilla)
Attachment #8863917 - Flags: review?(mh+mozilla)
I decided to fix the comments before review.
Same patch just a typo in the comment corrected.
Attachment #8863917 - Attachment is obsolete: true
Attachment #8863917 - Flags: review?(mh+mozilla)
Attachment #8864811 - Flags: review?(mh+mozilla)
Comment on attachment 8864811 [details] [diff] [review]
Allow overrride of MOZ_SOURCE_CHANGESET and MOZ_SOURCE_REPO.

Review of attachment 8864811 [details] [diff] [review]:
-----------------------------------------------------------------

Beware that as of bug 1279048, those variables are used for debug symbol files.
Attachment #8864811 - Flags: review?(mh+mozilla) → review+
Assignee: nobody → wgianopoulos
Status: NEW → ASSIGNED
Keywords: checkin-needed
OK so I don;t know, does adding checkin-needed as a keyword here help to get it checked in, or do I need to find my own friend with check-in privs to do this for me?
Jorg, the patch got r+ from Mike. Should I just check it in or do you want to do it?
Flags: needinfo?(jorgk)
I'll check it in when I next need a patch, so within the next 24 hours. I'll leave the NI to remind me.
(In reply to Jorg K (GMT+2) from comment #13)
> I'll check it in when I next need a patch, so within the next 24 hours. I'll
> leave the NI to remind me.

Thanks!
https://hg.mozilla.org/comm-central/rev/bd34d80df5ff4929617aaede1ec44230f54d65f7

I quite aggressively manage C-C these days, that means, I do an C-C push after every M-C merge to detect bustage. Small patches like this one help me with that. However, at times a small patch has to wait until I need to do a push again and don't have more important patches.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Flags: needinfo?(jorgk)
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.52
You need to log in before you can comment on or make changes to this bug.