1361617 - Coverity report: ​nsFlexContainerFrame::mChildrenHaveBeenReordered is not initialized in this constructor nor in any functions that it calls

Status: RESOLVED FIXED

(Core :: Layout, defect, P4)

Description

[Mats Palmgren (inactive)]

Coverity CID 1221327 Uninitialized scalar field

The field will contain an arbitrary value left over from earlier computations.

In nsFlexContainerFrame::​nsFlexContainerFrame(nsStyleContext *): A scalar field is not initialized by the constructor

135  explicit nsFlexContainerFrame(nsStyleContext* aContext)
136    : nsContainerFrame(aContext, mozilla::FrameType::FlexContainer)
137    , mBaselineFromLastReflow(NS_INTRINSIC_WIDTH_UNKNOWN)
138    , mLastBaselineFromLastReflow(NS_INTRINSIC_WIDTH_UNKNOWN)
   CID 1221327 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)2. uninit_member: Non-static class member mChildrenHaveBeenReordered is not initialized in this constructor nor in any functions that it calls.
139  {}


===============================

AFAICT, nsFlexContainerFrame::mChildrenHaveBeenReordered is unused and can be removed:
http://searchfox.org/mozilla-central/search?q=mChildrenHaveBeenReordered&case=false&regexp=false&path=

Comment 5

[Mats Palmgren (inactive)]

Better link to show there's only one matching line:
http://searchfox.org/mozilla-central/search?q=symbol:F_%3CT_nsFlexContainerFrame%3E_0&redirect=false

Comment 6

[Daniel Holbert [:dholbert]]

Yup -- looks like we removed the variable's usages in bug 981116, but didn't remove the variable itself.  Thanks for catching this!

Comment 7

[Daniel Holbert [:dholbert]]

Attachment: Bug 1361617: Remove unused member var nsFlexContainerFrame::mChildrenHaveBeenReordered.

Review commit: https://reviewboard.mozilla.org/r/138674/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138674/

Comment 8

[Daniel Holbert [:dholbert]]

(oops; I didn't notice you'd tagged this as "good-first-bug" until after I pushed the patch. Ah well.)

Comment 9

[Mats Palmgren (inactive)]

Comment on attachment 8867056 [details]
Bug 1361617: Remove unused member var nsFlexContainerFrame::mChildrenHaveBeenReordered.

https://reviewboard.mozilla.org/r/138674/#review141936

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25e130b9fb74
Remove unused member var nsFlexContainerFrame::mChildrenHaveBeenReordered. r=mats

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/25e130b9fb74