1361664 - Create MVP Triggers and Deeplinks for Mobile Marketing Automation

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement, P1)

Description

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

P1 Triggers:
(P1) Loads articles (reader mode ready)
(P1) Visiting a website (with match to past history) x times 
(P1) Download videos or any other media (x times) 
(P1) SavePassword (Save password and login) (x times) 
(P1) SaveBookmark (x times) 
(P1) LoadBookmark (x times) (loading the bookmark URL) 
(P1) Interact with search url area
(P1) When user take a screenshot  X times

P1 Deep links:
(P1) Link to Set Default Browser settings 
(P1) Link to specific Add-on page 
(P1) Link to sync signup/sign in 
(P1) Link to “Add to Home screen” feature 
(P1) Link to default search engine settings 
(P1) Link into Homepage settings  
(P1) Link to “Save as PDF” feature 
(P1) Link to “turn reader mode on” 
(P1) Take user directly to a Sign up for a newsletter (can we get users to sign up on slide instead of pointing them to a landing page?)
(P1) Link to Focus app 



Be noted that this P1 list is subject to change.

Comment 1

[Jean Collings]

Looks great, would add that we need the "When user clears private data within the settings/clear private data page" on exit trigger. That would trigger the Focus promotion.

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

then these 2 will need to be added to P1
(P1) When user “Clear Private Data”
(P1) FocusInstalledState - to know if user has Focus for Android installed or not

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

(In reply to Joe Cheng [:jcheng] (please needinfo) from comment #2)
> then these 2 will need to be added to P1
> (P1) When user “Clear Private Data”
> (P1) FocusInstalledState - to know if user has Focus for Android installed
> or not

Given the current aggressive releasing plan, can we descope this "focus promotion" experiment for the first MVP?

Comment 5

[Nevin Chen(Not active on Bugzilla)]

I've done all triggers in my local build.
Will submit the patch after the SDK landed.
But I didn't implements all the deep links
Cause in Bug 1356517 we only target the simple implementation.

So below are not implemented
(P1) Link to “Add to Home screen” feature
(P1) Link into Homepage settings  
(P1) Link to “turn reader mode on”
(P1) Link to Focus app

Below are done
(P1) Link to Set Default Browser settings
(P1) Link to specific Add-on page
(P1) Link to sync signup/sign in
(P1) Link to default search engine settings
(P1) Link into Homepage settings  
(P1) Link to “Save as PDF” feature
(P1) Take user directly to a Sign up for a newsletter

And some extra deep links:
firefox://bookmark_list
firefox://history_list
firefox://preferences
firefox://preferences_privacy
firefox://preferences_notifications
firefox://preferences_accessibility

Comment 6

[Jean Collings]

(In reply to Wesley Huang [:wesley_huang] (EPM) (NI me) from comment #4)
> (In reply to Joe Cheng [:jcheng] (please needinfo) from comment #2)
> > then these 2 will need to be added to P1
> > (P1) When user “Clear Private Data”
> > (P1) FocusInstalledState - to know if user has Focus for Android installed
> > or not
> 
> Given the current aggressive releasing plan, can we descope this "focus
> promotion" experiment for the first MVP?

Works for me, thanks all. Can you let me know when the others will get added?

Comment 7

[Andreas Bovens [:abovens]]

For my understanding, how do some of these deep links exactly work? E.g. "Link to “Save as PDF” feature". Does it open the overflow menu and highlight the feature in question? Or does it perform the "Save as PDF" download action straight away?

Comment 8

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

 
> So below are not implemented
> (P1) Link to “Add to Home screen” feature
> (P1) Link into Homepage settings  
> (P1) Link to “turn reader mode on”
> (P1) Link to Focus app
> 
> Below are done
> (P1) Link to Set Default Browser settings
> (P1) Link to specific Add-on page
> (P1) Link to sync signup/sign in
> (P1) Link to default search engine settings
> (P1) Link into Homepage settings  
// confirmed with Nevin that this is typo. "Link into homepage settings" is NOT implemented.

> (P1) Link to “Save as PDF” feature
> (P1) Take user directly to a Sign up for a newsletter
>

Comment 9

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

(In reply to Andreas Bovens from comment #7)
> For my understanding, how do some of these deep links exactly work? E.g.
> "Link to “Save as PDF” feature". Does it open the overflow menu and
> highlight the feature in question? Or does it perform the "Save as PDF"
> download action straight away?

It depends. For "Save as PDF", it performs the save action directly.
Others such as preference setting and SUMO pages, it takes user to that specific page.
But within that page I don't think we have a plan yet to _HIGHLIGHT_ in a visual way.

Comment 10

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1361664 - Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin.

This bug will fix/build all the triggers / deep links needed in phase 1~2

Todo:
1. Extract Leanplum event String
2. Add check before sending 'Set Default Borwser' Check
3. Add deeplink for user attribute for delay messaging
4. Add user attribute for focus before Leanplum.init
5. Set back the user attribute after set default browser deep link triggers

Review commit: https://reviewboard.mozilla.org/r/141030/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141030/

Comment 11

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Latest update here:

P0 trigger:  open Firefox 2 times during the last 7 days (this is actually predefined in LeanPlum SDK)
P0 deeplink: push the dialog when user open Firefox, (TBD: additional checking, only push to those not setting Firefox as default browser )

P1 Triggers:
(P1) Loads articles (reader mode ready)
(P1) Visiting a website (with match to past history) x times 
(P1) Download videos or any other media (x times) 
(P1) SavePassword (Save password and login) (x times) 
(P1) SaveBookmark (x times) 
(P1) LoadBookmark (x times) (loading the bookmark URL) 
(P1) Interact with search url area
(P1) When user take a screenshot  X times

P1 Deep links:
(P1) Link to Set Default Browser settings 
(P1) Link to specific Add-on page 
(P1) Link to sync signup/sign in 
(P1) Link to default search engine settings 
(P1) Link to “Save as PDF” feature 
(P1) Take user directly to a Sign up for a newsletter 

(P2) deep links:
firefox://bookmark_list
firefox://history_list
firefox://preferences
firefox://preferences_privacy
firefox://preferences_notifications
firefox://preferences_accessibility

Comment 12

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1361664 - Part1. Udate MMA API, make init() accept activity.

Review commit: https://reviewboard.mozilla.org/r/142200/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142200/

Comment 13

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8869376 [details]
Bug 1361664 - Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141030/diff/1-2/

Comment 14

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8869376 [details]
Bug 1361664 - Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141030/diff/2-3/

Comment 15

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8870726 [details]
Bug 1361664 - Part1. Udate MMA API, make init() accept activity.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/142200/diff/1-2/

Comment 16

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8869376 [details]
Bug 1361664 - Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141030/diff/3-4/

Comment 17

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8870726 [details]
Bug 1361664 - Part1. Udate MMA API, make init() accept activity.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/142200/diff/2-3/

Comment 18

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8869376 [details]
Bug 1361664 - Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141030/diff/4-5/

Comment 19

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8869376 [details]
Bug 1361664 - Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141030/diff/5-6/

Comment 20

[Max Liu [:maliu]]

Comment on attachment 8869376 [details]
Bug 1361664 - Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin.

https://reviewboard.mozilla.org/r/141030/#review146826

::: mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java:87
(Diff revision 6)
>          }
>      }
> +
> +    private static boolean isMmaEnabled() {
> +        if (applicationContext != null && applicationContext.get() != null) {
> +            Context context = applicationContext.get();

get instance first before if block checking

::: mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java:54
(Diff revision 6)
>          if (installedFocus || installedKlar) {
>              attributes.put("focus", "installed");
>          }
>          Leanplum.start(activity, attributes);
> -        Leanplum.track("Launch");
> +        if (isDefaultBrowser(activity, Intent.ACTION_VIEW)) {
> +            Leanplum.track(LAUNCH_BUT_NOT_DEFAULT_BROWSER);

isDefaultBrowser return true and enter the block, why track LAUNCH_"""BUT_NOT_DEFAULT"""_BROWSER??

::: mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java:98
(Diff revision 6)
>      @Override
>      public void stop() {
>          Leanplum.stop();
>      }
> +
> +    private boolean isDefaultBrowser(Context context, String action) {

If this method only checks "Browser", the action probably is limited to Intent.ACTION_VIEW only. Why is action a parameter allow caller pass other action? Is there other action triggers browser app?

Comment 21

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8870726 [details]
Bug 1361664 - Part1. Udate MMA API, make init() accept activity.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/142200/diff/3-4/

Comment 22

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8869376 [details]
Bug 1361664 - Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141030/diff/6-7/

Comment 23

[Max Liu [:maliu]]

Comment on attachment 8870726 [details]
Bug 1361664 - Part1. Udate MMA API, make init() accept activity.

https://reviewboard.mozilla.org/r/142200/#review146878

::: mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java:40
(Diff revision 4)
> +        Map<String, Object> attributes = new HashMap<>();
> +        boolean installedFocus = ContextUtils.isPackageInstalled(activity, "org.mozilla.focus");
> +        boolean installedKlar = ContextUtils.isPackageInstalled(activity, "org.mozilla.klar");

nit: final

Comment 24

[Max Liu [:maliu]]

Comment on attachment 8869376 [details]
Bug 1361664 - Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin.

https://reviewboard.mozilla.org/r/141030/#review146904

Comment 25

[Max Liu [:maliu]]

Comment on attachment 8870726 [details]
Bug 1361664 - Part1. Udate MMA API, make init() accept activity.

https://reviewboard.mozilla.org/r/142200/#review146906

Comment 26

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8869376 [details]
Bug 1361664 - Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141030/diff/7-8/

Comment 27

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s a39cecaecd4c -d bdd2b6377f1d: rebasing 398439:a39cecaecd4c "Bug 1361664 - Part1. Udate MMA API, make init() accept activity. r=maliu"
merging mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
merging mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java
merging mobile/android/base/java/org/mozilla/gecko/mma/MmaInterface.java
merging mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java
merging mobile/android/base/java/org/mozilla/gecko/mma/MmaStubImp.java
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 28

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8870726 [details]
Bug 1361664 - Part1. Udate MMA API, make init() accept activity.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/142200/diff/4-5/

Comment 29

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8869376 [details]
Bug 1361664 - Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141030/diff/8-9/

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f54fb8956671
Part1. Udate MMA API, make init() accept activity. r=maliu
https://hg.mozilla.org/integration/autoland/rev/59dc8710d768
Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin. r=maliu

Comment 31

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for bustage at mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java:25: symbol not found and linting failures:

https://hg.mozilla.org/integration/autoland/rev/5a8db189930cedc0ec845ced1970837c187b9003

Also had to back out bug 1361664 to get this out:

https://hg.mozilla.org/integration/autoland/rev/11de121a061f10049f0c4bb63498722d237efe1e
https://hg.mozilla.org/integration/autoland/rev/48b319f9d3f25088d45ba7b3bfdda0e57eb6ea8b


Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=fba7b035a4f98e9b74aa1e21916822593cc0c39d&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=102305960&repo=autoland

[task 2017-05-26T11:29:56.756655Z] 11:29:56     INFO -    Copying resources from program jar [/home/worker/workspace/build/src/obj-firefox/dist/exploded-aar/play-services-measurement-8.4.0/play-services-measurement-8.4.0-classes.jar]
[task 2017-05-26T11:29:59.855502Z] 11:29:59     INFO -  /home/worker/workspace/build/src/mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java:25: error: cannot find symbol
[task 2017-05-26T11:29:59.856485Z] 11:29:59     INFO -          setupPrefHandler(application);
[task 2017-05-26T11:29:59.856551Z] 11:29:59     INFO -          ^
[task 2017-05-26T11:29:59.856634Z] 11:29:59     INFO -    symbol:   method setupPrefHandler(Application)
[task 2017-05-26T11:29:59.856674Z] 11:29:59     INFO -    location: class MmaDelegate

Comment 32

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8870726 [details]
Bug 1361664 - Part1. Udate MMA API, make init() accept activity.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/142200/diff/5-6/

Comment 33

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8869376 [details]
Bug 1361664 - Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141030/diff/9-10/

Comment 34

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44e144a782e1
Part1. Udate MMA API, make init() accept activity. r=maliu
https://hg.mozilla.org/integration/autoland/rev/d289ee2c794d
Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin. r=maliu

Comment 35

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s fc000e03cfed -d 9494a5b0b185: rebasing 398577:fc000e03cfed "Bug 1361664 - Part1. Udate MMA API, make init() accept activity. r=maliu"
merging mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
merging mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java
merging mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java! (edit, then use 'hg resolve --mark')
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 36

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s fc000e03cfed -d 40d98a26598e: rebasing 398580:fc000e03cfed "Bug 1361664 - Part1. Udate MMA API, make init() accept activity. r=maliu"
merging mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
merging mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java
merging mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java! (edit, then use 'hg resolve --mark')
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 37

[Nevin Chen(Not active on Bugzilla)]

Hi! Sebastian !
Although Bug 1358117 is landed 12 hours ago, I still can't find the code in m-c now (fetching the latest central). That's why these two patches can't be autoloand. This patch depends on some update in that patch. I'll try again tomorrow and see if it works. 
Please correct me if I'm wrong

Comment 38

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/44e144a782e1
https://hg.mozilla.org/mozilla-central/rev/d289ee2c794d

Comment 39

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Hi Nevin, the patch for bug 1358117 has been merged to mozilla-central now.

Comment 40

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed bug 1358117 and bug 1361664 out for Android Nightly bustage:

Bug 1358117
https://hg.mozilla.org/mozilla-central/rev/66c73b65bf2d02c59f361b89135dc56553c3e4eb

Bug 1361664
https://hg.mozilla.org/mozilla-central/rev/590a85b31999a060e30bbf31352216860ba081a9
https://hg.mozilla.org/mozilla-central/rev/fa869ff5ecf6259451b656d879dde8371a6a4483

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=ebad93e117700d8e2d65573b824beb18a8cc2030&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-searchStr=android
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=102554687&repo=mozilla-central

[task 2017-05-27T10:32:16.942194Z] 10:32:16     INFO -  Note: com.google.android.gms.common.internal.DowngradeableSafeParcel accesses a field 'NULL' dynamically
[task 2017-05-27T10:32:16.943430Z] 10:32:16     INFO -        Maybe this is program field 'com.google.android.gms.common.internal.safeparcel.SafeParcelable { java.lang.String NULL; }'
[task 2017-05-27T10:32:16.959109Z] 10:32:16     INFO -        Maybe this is library field 'android.util.JsonToken { android.util.JsonToken NULL; }'
[task 2017-05-27T10:32:16.959746Z] 10:32:16     INFO -        Maybe this is library field 'java.sql.Types { int NULL; }'
[task 2017-05-27T10:32:16.959815Z] 10:32:16     INFO -        Maybe this is library field 'org.json.JSONObject { java.lang.Object NULL; }'
[task 2017-05-27T10:32:16.974939Z] 10:32:16     INFO -  Note: com.google.android.gms.measurement.internal.zzab accesses a declared method 'initialize(android.content.Context)' dynamically
[task 2017-05-27T10:32:17.204721Z] 10:32:17     INFO -  Note: there were 2 accesses to class members by means of introspection.
[task 2017-05-27T10:32:17.204960Z] 10:32:17     INFO -        You should consider explicitly keeping the mentioned class members
[task 2017-05-27T10:32:17.205210Z] 10:32:17     INFO -        (using '-keep' or '-keepclassmembers').
[task 2017-05-27T10:32:17.205280Z] 10:32:17     INFO -  Ignoring unused library classes...
[task 2017-05-27T10:32:17.205921Z] 10:32:17     INFO -    Original number of library classes: 3633
[task 2017-05-27T10:32:17.205975Z] 10:32:17     INFO -    Final number of library classes:    1101
[task 2017-05-27T10:32:17.206000Z] 10:32:17     INFO -  Obfuscating...
[task 2017-05-27T10:32:17.325260Z] 10:32:17     INFO -  /home/worker/workspace/build/src/mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java:22: error: package org.mozilla.gecko.util does not exist
[task 2017-05-27T10:32:17.325532Z] 10:32:17     INFO -  import org.mozilla.gecko.util.ContextUtils;
[task 2017-05-27T10:32:17.325595Z] 10:32:17     INFO -                               ^
[task 2017-05-27T10:32:17.325754Z] 10:32:17     INFO -  /home/worker/workspace/build/src/mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java:27: error: cannot find symbol
[task 2017-05-27T10:32:17.325849Z] 10:32:17     INFO -  import static org.mozilla.gecko.mma.MmaDelegate.LAUNCH_BUT_NOT_DEFAULT_BROWSER;
[task 2017-05-27T10:32:17.326209Z] 10:32:17     INFO -                                     ^
[task 2017-05-27T10:32:17.326279Z] 10:32:17     INFO -    symbol:   class MmaDelegate
[task 2017-05-27T10:32:17.326430Z] 10:32:17     INFO -    location: package org.mozilla.gecko.mma
[task 2017-05-27T10:32:17.326535Z] 10:32:17     INFO -  /home/worker/workspace/build/src/mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java:27: error: static import only from classes and interfaces
[task 2017-05-27T10:32:17.326752Z] 10:32:17     INFO -  import static org.mozilla.gecko.mma.MmaDelegate.LAUNCH_BUT_NOT_DEFAULT_BROWSER;
[task 2017-05-27T10:32:17.326884Z] 10:32:17     INFO -  ^
[task 2017-05-27T10:32:17.433549Z] 10:32:17     INFO -  /home/worker/workspace/build/src/mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java:47: error: cannot find symbol
[task 2017-05-27T10:32:17.433647Z] 10:32:17     INFO -          boolean installedFocus = ContextUtils.isPackageInstalled(activity, "org.mozilla.focus");
[task 2017-05-27T10:32:17.433688Z] 10:32:17     INFO -                                   ^
[task 2017-05-27T10:32:17.433723Z] 10:32:17     INFO -    symbol:   variable ContextUtils
[task 2017-05-27T10:32:17.433756Z] 10:32:17     INFO -    location: class MmaLeanplumImp
[task 2017-05-27T10:32:17.433819Z] 10:32:17     INFO -  /home/worker/workspace/build/src/mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java:48: error: cannot find symbol
[task 2017-05-27T10:32:17.433881Z] 10:32:17     INFO -          boolean installedKlar = ContextUtils.isPackageInstalled(activity, "org.mozilla.klar");
[task 2017-05-27T10:32:17.434880Z] 10:32:17     INFO -                                  ^
[task 2017-05-27T10:32:17.435330Z] 10:32:17     INFO -    symbol:   variable ContextUtils
[task 2017-05-27T10:32:17.435851Z] 10:32:17     INFO -    location: class MmaLeanplumImp
[task 2017-05-27T10:32:17.436692Z] 10:32:17     INFO -  /home/worker/workspace/build/src/mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java:54: error: cannot find symbol
[task 2017-05-27T10:32:17.436974Z] 10:32:17     INFO -              Leanplum.track(LAUNCH_BUT_NOT_DEFAULT_BROWSER);
[task 2017-05-27T10:32:17.437753Z] 10:32:17     INFO -                             ^
[task 2017-05-27T10:32:17.438106Z] 10:32:17     INFO -    symbol:   variable LAUNCH_BUT_NOT_DEFAULT_BROWSER
[task 2017-05-27T10:32:17.438427Z] 10:32:17     INFO -    location: class MmaLeanplumImp
[task 2017-05-27T10:32:17.453721Z] 10:32:17     INFO -  Note: /home/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/gecko/SysInfo.java uses or overrides a deprecated API.
[task 2017-05-27T10:32:17.454007Z] 10:32:17     INFO -  Note: Recompile with -Xlint:deprecation for details.
[task 2017-05-27T10:32:17.454388Z] 10:32:17     INFO -  6 errors
[task 2017-05-27T10:32:17.489685Z] 10:32:17     INFO -  /home/worker/workspace/build/src/config/makefiles/java-build.mk:149: recipe for target 'constants.jar' failed
[task 2017-05-27T10:32:17.489946Z] 10:32:17     INFO -  gmake[5]: *** [constants.jar] Error 1

Comment 41

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8870726 [details]
Bug 1361664 - Part1. Udate MMA API, make init() accept activity.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/142200/diff/6-7/

Comment 42

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8869376 [details]
Bug 1361664 - Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141030/diff/10-11/

Comment 43

[Nevin Chen(Not active on Bugzilla)]

just did the rebase and updated patch. Will submit a try job and re-land later

Comment 44

[Nevin Chen(Not active on Bugzilla)]

Turns out that after Bug 1365089 landed, build server will use the real implementation (MOZ_ANDROID_MMA=1). That's why my previous rebase didn't work. 

There's something in the real impl I haven't rebase yet. And landing Bug 1365089 made my patch backed out :P. Hope the new patch will work.

Comment 45

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/645836bfad25
Part1. Udate MMA API, make init() accept activity. r=maliu
https://hg.mozilla.org/integration/autoland/rev/49714b590d48
Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin. r=maliu

Comment 46

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out because bug 1365089 got backed out and this depends on it:

https://hg.mozilla.org/integration/autoland/rev/afde8a5603f84c4e3536f407b9715dcb32cbd04e
https://hg.mozilla.org/integration/autoland/rev/01476dee058410a5a14e4ff55d9959243782d869

Comment 47

[Nevin Chen(Not active on Bugzilla)]

Thanks. I'll wait for how https://bugzilla.mozilla.org/show_bug.cgi?id=1365089#c46 goes and try later.

Comment 48

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s b3e80c4d9066 -d 99de7cf38c12: rebasing 398728:b3e80c4d9066 "Bug 1361664 - Part1. Udate MMA API, make init() accept activity. r=maliu"
merging mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
merging mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java
merging mobile/android/base/java/org/mozilla/gecko/mma/MmaInterface.java
merging mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java
merging mobile/android/base/java/org/mozilla/gecko/mma/MmaStubImp.java
merging mobile/android/thirdparty/com/leanplum/LeanplumActivityHelper.java
rebasing 398729:eeea2ba90a49 "Bug 1361664 - Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin. r=maliu" (tip)
merging mobile/android/base/generate_build_config.py
merging mobile/android/base/java/org/mozilla/gecko/GeckoApp.java
merging mobile/android/base/java/org/mozilla/gecko/Tabs.java
merging mobile/android/base/java/org/mozilla/gecko/Telemetry.java
merging mobile/android/base/java/org/mozilla/gecko/mma/MmaDelegate.java
merging mobile/android/base/java/org/mozilla/gecko/mma/MmaLeanplumImp.java
merging mobile/android/base/java/org/mozilla/gecko/preferences/PrivateDataPreference.java
merging mobile/android/base/java/org/mozilla/gecko/promotion/AddToHomeScreenPromotion.java
merging mobile/android/chrome/content/Reader.js
merging mobile/android/chrome/content/browser.js
merging mobile/android/config/proguard/proguard-leanplum.cfg
warning: conflicts while merging mobile/android/base/generate_build_config.py! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 49

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8870726 [details]
Bug 1361664 - Part1. Udate MMA API, make init() accept activity.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/142200/diff/7-8/

Comment 50

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8869376 [details]
Bug 1361664 - Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141030/diff/11-12/

Comment 51

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s b0dac74567d5 -d 6597f70ef534: rebasing 398796:b0dac74567d5 "Bug 1361664 - Part1. Udate MMA API, make init() accept activity. r=maliu"
rebasing 398797:94c2ff00fdb3 "Bug 1361664 - Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin. r=maliu" (tip)
merging mobile/android/base/generate_build_config.py
warning: conflicts while merging mobile/android/base/generate_build_config.py! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 52

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s b0dac74567d5 -d 7ad409d79405: rebasing 398798:b0dac74567d5 "Bug 1361664 - Part1. Udate MMA API, make init() accept activity. r=maliu"
rebasing 398799:94c2ff00fdb3 "Bug 1361664 - Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin. r=maliu" (tip)
merging mobile/android/base/generate_build_config.py
warning: conflicts while merging mobile/android/base/generate_build_config.py! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 53

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8870726 [details]
Bug 1361664 - Part1. Udate MMA API, make init() accept activity.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/142200/diff/8-9/

Comment 54

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8869376 [details]
Bug 1361664 - Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141030/diff/12-13/

Comment 55

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f72b42111934
Part1. Udate MMA API, make init() accept activity. r=maliu
https://hg.mozilla.org/integration/autoland/rev/936b94812913
Part2. Create MVP Triggers and Deeplinks for Mobile Marketing Automatin. r=maliu

Comment 56

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f72b42111934
https://hg.mozilla.org/mozilla-central/rev/936b94812913

Comment 57

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

(Commenting on User Story)
> Latest update here:
> 
> P0 trigger:  open Firefox 2 times during the last 7 days (this is canfigured
> in LeanPlum dashboard)
> P0 deeplink: push the dialog when user open Firefox, (TBD: additional
> checking, only push to those not setting Firefox as default browser )
> 
> P1 Triggers:
> (P1) Loads articles (reader mode ready)
> (P1) Visiting a website (with match to past history) x times 
> (P1) Download videos or any other media (x times) 
> (P1) SavePassword (Save password and login) (x times) 
> (P1) SaveBookmark (x times) 
> (P1) LoadBookmark (x times) (loading the bookmark URL) 
> (P1) Interact with search url area
> (P1) When user take a screenshot  X times
> 
> P1 Deep links:
> (P1) Link to Set Default Browser settings 
> (P1) Link to specific Add-on page 
> (P1) Link to sync signup/sign in 
> (P1) Link to default search engine settings 
> (P1) Link to “Save as PDF” feature 
> (P1) Take user directly to a Sign up for a newsletter 
> 
> (P2) deep links:
> firefox://bookmark_list
> firefox://history_list
> firefox://preferences
> firefox://preferences_privacy
> firefox://preferences_notifications
> firefox://preferences_accessibility

(Commenting on User Story)
> Latest update here:
> 
> P0 trigger:  open Firefox 2 times during the last 7 days (this is configured
> in LeanPlum dashboard)
> P0 deeplink: push the dialog when user open Firefox, (TBD: additional
> checking, only push to those not setting Firefox as default browser )
> 
> P1 Triggers:
> (P1) Loads articles (reader mode ready)
> (P1) Visiting a website (with match to past history) x times 
> (P1) Download videos or any other media (x times) 
> (P1) SavePassword (Save password and login) (x times) 
> (P1) SaveBookmark (x times) 
> (P1) LoadBookmark (x times) (loading the bookmark URL) 
> (P1) Interact with search url area
> (P1) When user take a screenshot  X times
> 
> P1 Deep links:
> (P1) Link to Set Default Browser settings 
> (P1) Link to specific Add-on page 
> (P1) Link to sync signup/sign in 
> (P1) Link to default search engine settings 
> (P1) Link to “Save as PDF” feature 
> (P1) Take user directly to a Sign up for a newsletter 
> 
> (P2) deep links:
> firefox://bookmark_list
> firefox://history_list
> firefox://preferences
> firefox://preferences_privacy
> firefox://preferences_notifications
> firefox://preferences_accessibility