Update about:license page title

VERIFIED FIXED in Firefox 55

Status

()

defect
P1
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: dao, Assigned: shashwat.jolly)

Tracking

(Blocks 1 bug, {good-first-bug})

Trunk
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 verified)

Details

(Whiteboard: [reserve-photon-visual][p2][good first bug][lang=html])

Attachments

(1 attachment, 1 obsolete attachment)

The about:license page title (in <title> and <h1>) should say "Licenses" rather than "about:license".
Flags: qe-verify?
Priority: -- → P2
This needs to be fixed in toolkit/content/license.html
Keywords: good-first-bug
Whiteboard: [photon-visual][p2] → [photon-visual][p2][good first bug][lang=html]
Putting on reserve backlog for now.
Priority: P2 → P3
Whiteboard: [photon-visual][p2][good first bug][lang=html] → [reserve-photon-visual][p2][good first bug][lang=html]
Hi! I am new to open source. I would like to know how I could create and submit a patch for this bug. Thanks!
(In reply to Shashwat Jolly from comment #3)
> Hi! I am new to open source. I would like to know how I could create and
> submit a patch for this bug. Thanks!

Hi! Do you have the source code and have you built Firefox yet? If not, here are some instructions:

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build

Do you know how to create a patch in general? Using 'hg diff > ~/mypatch.diff' is the simplest way.

Let me know if you have questions.
(In reply to Dão Gottwald [::dao] from comment #4)
> (In reply to Shashwat Jolly from comment #3)
> > Hi! I am new to open source. I would like to know how I could create and
> > submit a patch for this bug. Thanks!
> 
> Hi! Do you have the source code and have you built Firefox yet? If not, here
> are some instructions:
> 
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> Build_Instructions/Simple_Firefox_build
> 
> Do you know how to create a patch in general? Using 'hg diff >
> ~/mypatch.diff' is the simplest way.
> 
> Let me know if you have questions.

Yes, I have the source code and have built Firefox. I also found the license.html file you were referring to in toolkit/content and have modified its <title> and <h1> tags as required. I am confused about what to do next.
The next step would be to create a patch file using hg diff. Once you have that, attach it here (see the "Attach File" link on this page).
(In reply to Dão Gottwald [::dao] from comment #6)
> The next step would be to create a patch file using hg diff. Once you have
> that, attach it here (see the "Attach File" link on this page).

OK! Also, do I have to use hg diff on the entire mozilla-central directory or just the toolkit/content folder? Sorry to ask so many questions, I am quite new at this. Thanks in advance!
You can do hg diff on the entire directory, but 'hg diff toolkit/content/' will work too.
Something went wrong there. The patch seems to contain loads of unrelated file additions. The toolkit/content/license.html change should result in a patch of just a couple of KB in size rather than 3 MB :/
Comment on attachment 8867333 [details] [diff] [review]
Changed about:license to Licenses in <title> and <h1> tags of toolkit/content/license.html

Much better, thanks!
Attachment #8867333 - Flags: review+
Assignee: nobody → shashwat.jolly
Status: NEW → ASSIGNED
Flags: qe-verify? → qe-verify+
Attachment #8867279 - Attachment is obsolete: true
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a69cbcf4cf42
Changed about:license page title from "about:license" to "Licenses". r=dao
Priority: P3 → P1
QA Contact: brindusa.tot
https://hg.mozilla.org/mozilla-central/rev/a69cbcf4cf42
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Iteration: --- → 55.5 - May 15
I have reproduce this bug with Nightly 55.0a1 (2017-05-03) (64-bit) in Windows 10.

This bug's fix is verified with latest Nightly 55.0a1 (64-bit).
 
Build ID   :    20170516122050
User Agent :	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0


[bugday-20170517]
Thanks!
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.