1361693 - Update about:license page title

Status: VERIFIED FIXED

(Firefox :: General, defect, P1)

Description

[Dão Gottwald [:dao]]

The about:license page title (in <title> and <h1>) should say "Licenses" rather than "about:license".

Comment 1

[Dão Gottwald [:dao]]

This needs to be fixed in toolkit/content/license.html

Comment 2

[Justin Dolske [:Dolske]]

Putting on reserve backlog for now.

Comment 3

[Shashwat Jolly]

Hi! I am new to open source. I would like to know how I could create and submit a patch for this bug. Thanks!

Comment 4

[Dão Gottwald [:dao]]

(In reply to Shashwat Jolly from comment #3)
> Hi! I am new to open source. I would like to know how I could create and
> submit a patch for this bug. Thanks!

Hi! Do you have the source code and have you built Firefox yet? If not, here are some instructions:

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build

Do you know how to create a patch in general? Using 'hg diff > ~/mypatch.diff' is the simplest way.

Let me know if you have questions.

Comment 5

[Shashwat Jolly]

(In reply to Dão Gottwald [::dao] from comment #4)
> (In reply to Shashwat Jolly from comment #3)
> > Hi! I am new to open source. I would like to know how I could create and
> > submit a patch for this bug. Thanks!
> 
> Hi! Do you have the source code and have you built Firefox yet? If not, here
> are some instructions:
> 
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> Build_Instructions/Simple_Firefox_build
> 
> Do you know how to create a patch in general? Using 'hg diff >
> ~/mypatch.diff' is the simplest way.
> 
> Let me know if you have questions.

Yes, I have the source code and have built Firefox. I also found the license.html file you were referring to in toolkit/content and have modified its <title> and <h1> tags as required. I am confused about what to do next.

Comment 6

[Dão Gottwald [:dao]]

The next step would be to create a patch file using hg diff. Once you have that, attach it here (see the "Attach File" link on this page).

Comment 7

[Shashwat Jolly]

(In reply to Dão Gottwald [::dao] from comment #6)
> The next step would be to create a patch file using hg diff. Once you have
> that, attach it here (see the "Attach File" link on this page).

OK! Also, do I have to use hg diff on the entire mozilla-central directory or just the toolkit/content folder? Sorry to ask so many questions, I am quite new at this. Thanks in advance!

Comment 8

[Dão Gottwald [:dao]]

You can do hg diff on the entire directory, but 'hg diff toolkit/content/' will work too.

Comment 9

[Shashwat Jolly]

Attachment: Changed about:license to Licenses in <title> and <h1> tags of toolkit/content/license.html

Comment 10

[Dão Gottwald [:dao]]

Something went wrong there. The patch seems to contain loads of unrelated file additions. The toolkit/content/license.html change should result in a patch of just a couple of KB in size rather than 3 MB :/

Comment 11

[Shashwat Jolly]

Attachment: Changed about:license to Licenses in <title> and <h1> tags of toolkit/content/license.html

Comment 12

[Dão Gottwald [:dao]]

Comment on attachment 8867333 [details] [diff] [review]
Changed about:license to Licenses in <title> and <h1> tags of toolkit/content/license.html

Much better, thanks!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a69cbcf4cf42
Changed about:license page title from "about:license" to "Licenses". r=dao

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/a69cbcf4cf42

Comment 15

[Almas Hossain[:mAlmas]]

I have reproduce this bug with Nightly 55.0a1 (2017-05-03) (64-bit) in Windows 10.

This bug's fix is verified with latest Nightly 55.0a1 (64-bit).
 
Build ID   :    20170516122050
User Agent :	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0


[bugday-20170517]

Comment 16

[Dão Gottwald [:dao]]

Thanks!