1361969 - Update the URL of "Firefox Support" Link at the bottom-left side on the Preferences page

Status: VERIFIED FIXED

(Firefox :: Settings UI, enhancement, P1)

Description

[Evan Tseng [:evanxd]]

Update the URL of "Firefox Support" Link at the bottom-left side on the Preferences page. Currently, the URL is
> https://support.mozilla.org/en-US/kb/startup-home-page-tabs-download-settings?redirectlocale=en-US&as=u&redirectslug=Options+window+-+General+panel&utm_source=inproduct

We would like to change to
> https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/preferences

Comment 1

[Evan Tseng [:evanxd]]

Received an email from Joni Savage. We want to change the URL to `https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/preferences`.

Comment 2

[Evan Tseng [:evanxd]]

Attachment: Bug 1361969 - Update the URL of "Firefox Support" Link

Review commit: https://reviewboard.mozilla.org/r/136222/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136222/

Comment 3

[Evan Tseng [:evanxd]]

Mike's review queue maxed out, and Jared is on PTO. We might need to wait for some time and continue to review the patch.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8864554 [details]
Bug 1361969 - Update the URL of "Firefox Support" Link

https://reviewboard.mozilla.org/r/136222/#review139222

::: browser/components/preferences/in-content/preferences.js:147
(Diff revision 1)
>  
>  function onHashChange() {
>    gotoPref();
>  }
>  
>  function gotoPref(aCategory) {

Given that the link no longer change w/ helpTopic, do you want to move it to somewhere else so we don't set it again whenever user switch pane?

Comment 5

[Evan Tseng [:evanxd]]

Comment on attachment 8864554 [details]
Bug 1361969 - Update the URL of "Firefox Support" Link

https://reviewboard.mozilla.org/r/136222/#review139222

> Given that the link no longer change w/ helpTopic, do you want to move it to somewhere else so we don't set it again whenever user switch pane?

Good point. Let's do it.

Comment 6

[Evan Tseng [:evanxd]]

Comment on attachment 8864554 [details]
Bug 1361969 - Update the URL of "Firefox Support" Link

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/136222/diff/1-2/

Comment 7

[Evan Tseng [:evanxd]]

Pushed try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf893ec5e5d2

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8864554 [details]
Bug 1361969 - Update the URL of "Firefox Support" Link

https://reviewboard.mozilla.org/r/136222/#review140128

::: browser/components/preferences/in-content/preferences.js
(Diff revision 2)
>      category = kDefaultCategoryInternalName;
>      item = categories.querySelector(".category[value=" + category + "]");
>    }
>  
> -  let helpButton = document.querySelector(".help-button");
> -  helpButton.setAttribute("href", getHelpLinkURL(item.getAttribute("helpTopic")));

Sorry for not spotting that earlier; do you want to remove this property also?

http://searchfox.org/mozilla-central/rev/8b70b0a5038ef9472fe7c53e04a70c978bb06aed/toolkit/content/widgets/preferences.xml#1193

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8864554 [details]
Bug 1361969 - Update the URL of "Firefox Support" Link

https://reviewboard.mozilla.org/r/136222/#review140128

> Sorry for not spotting that earlier; do you want to remove this property also?
> 
> http://searchfox.org/mozilla-central/rev/8b70b0a5038ef9472fe7c53e04a70c978bb06aed/toolkit/content/widgets/preferences.xml#1193

I think SeaMonkey still uses helpTopic. If there's no pressing reason to remove it, we should leave it.

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8864554 [details]
Bug 1361969 - Update the URL of "Firefox Support" Link

https://reviewboard.mozilla.org/r/136222/#review140368

Thanks!

Comment 11

[Evan Tseng [:evanxd]]

Thanks Mike for reviewing.

Let's land the patch after the treeherder task[1] is good.

[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf893ec5e5d2&selectedJob=97341610

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09259740487b
Update the URL of "Firefox Support" Link r=mconley

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/09259740487b

Comment 14

[Hani Yacoub, Desktop QA]

Build ID: 20170524030204
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

Verified as fixed on Firefox Nightly 55.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.