Toolbarbutton icons should be 16x16 rather than 18x18

RESOLVED FIXED in Firefox 55

Status

()

defect
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 55
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [photon-visual][p1])

Attachments

(2 attachments)

No description provided.
Flags: qe-verify?
Priority: -- → P2
No longer blocks: photon-visual
Needinfo shorlander to provide the modified icons.
Flags: needinfo?(shorlander)
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Iteration: --- → 55.5 - May 15
Priority: P2 → P1
Comment on attachment 8865653 [details]
Bug 1362083 - Change toolbarbutton icon size from 18x18 to 16x16.

https://reviewboard.mozilla.org/r/137270/#review140616

This seems good to me but there's an issue with the downloads indicator that I just mentioned to you (it gets larger on click), not sure if that's trivial to fix or not, so cancelling review for now.
Attachment #8865653 - Flags: review?(jhofmann)
Comment on attachment 8865653 [details]
Bug 1362083 - Change toolbarbutton icon size from 18x18 to 16x16.

https://reviewboard.mozilla.org/r/137270/#review140626

Looks good now, thanks.
Attachment #8865653 - Flags: review?(jhofmann) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d3c404886f0f
Change toolbarbutton icon size from 18x18 to 16x16. r=johannh
Blocks: 1363477
https://hg.mozilla.org/mozilla-central/rev/d3c404886f0f
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Depends on: 1363732
Flags: qe-verify? → qe-verify-
Mozscreenshots found that this patch (at least I think it was this patch from looking at the pushlog) slightly stretched the back-button icon.

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=4b8939ed128172fcd3433ee25f336a8c1ba77ab0&newProject=mozilla-central&newRev=2b6f6881a24a726364054aa69031927e2f3fc5fa

I guess it doesn't make a big difference visually and compact theme seems to be fine, I just wanted to note this. I'm not really sure how to follow up to this.
(In reply to Johann Hofmann [:johannh] from comment #10)
> Mozscreenshots found that this patch (at least I think it was this patch
> from looking at the pushlog) slightly stretched the back-button icon.
> 
> https://screenshots.mattn.ca/compare/?oldProject=mozilla-
> central&oldRev=4b8939ed128172fcd3433ee25f336a8c1ba77ab0&newProject=mozilla-
> central&newRev=2b6f6881a24a726364054aa69031927e2f3fc5fa
> 
> I guess it doesn't make a big difference visually and compact theme seems to
> be fine, I just wanted to note this. I'm not really sure how to follow up to
> this.

Icons generally shouldn't be stretched. Can you please file a new bug?
Flags: needinfo?(jhofmann)
Depends on: 1367015
Done :)
Flags: needinfo?(jhofmann)
No longer depends on: 1367015
Depends on: 1373299
You need to log in before you can comment on or make changes to this bug.