1362083 - Toolbarbutton icons should be 16x16 rather than 18x18

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P1)

Comment 1

[Dão Gottwald [:dao]]

Needinfo shorlander to provide the modified icons.

Comment 2

[Stephen Horlander [:shorlander]]

Attachment: change-icons-to-16x16.patch

Change icons to 16 x 16

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1362083 - Change toolbarbutton icon size from 18x18 to 16x16.

Review commit: https://reviewboard.mozilla.org/r/137270/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137270/

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8865653 [details]
Bug 1362083 - Change toolbarbutton icon size from 18x18 to 16x16.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137270/diff/1-2/

Comment 5

[Johann Hofmann [:johannh]]

Comment on attachment 8865653 [details]
Bug 1362083 - Change toolbarbutton icon size from 18x18 to 16x16.

https://reviewboard.mozilla.org/r/137270/#review140616

This seems good to me but there's an issue with the downloads indicator that I just mentioned to you (it gets larger on click), not sure if that's trivial to fix or not, so cancelling review for now.

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8865653 [details]
Bug 1362083 - Change toolbarbutton icon size from 18x18 to 16x16.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137270/diff/2-3/

Comment 7

[Johann Hofmann [:johannh]]

Comment on attachment 8865653 [details]
Bug 1362083 - Change toolbarbutton icon size from 18x18 to 16x16.

https://reviewboard.mozilla.org/r/137270/#review140626

Looks good now, thanks.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3c404886f0f
Change toolbarbutton icon size from 18x18 to 16x16. r=johannh

Comment 9

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/d3c404886f0f

Comment 10

[Johann Hofmann [:johannh]]

Mozscreenshots found that this patch (at least I think it was this patch from looking at the pushlog) slightly stretched the back-button icon.

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=4b8939ed128172fcd3433ee25f336a8c1ba77ab0&newProject=mozilla-central&newRev=2b6f6881a24a726364054aa69031927e2f3fc5fa

I guess it doesn't make a big difference visually and compact theme seems to be fine, I just wanted to note this. I'm not really sure how to follow up to this.

Comment 11

[Dão Gottwald [:dao]]

(In reply to Johann Hofmann [:johannh] from comment #10)
> Mozscreenshots found that this patch (at least I think it was this patch
> from looking at the pushlog) slightly stretched the back-button icon.
> 
> https://screenshots.mattn.ca/compare/?oldProject=mozilla-
> central&oldRev=4b8939ed128172fcd3433ee25f336a8c1ba77ab0&newProject=mozilla-
> central&newRev=2b6f6881a24a726364054aa69031927e2f3fc5fa
> 
> I guess it doesn't make a big difference visually and compact theme seems to
> be fine, I just wanted to note this. I'm not really sure how to follow up to
> this.

Icons generally shouldn't be stretched. Can you please file a new bug?

Comment 12

[Johann Hofmann [:johannh]]

Done :)