1362407 - Buildbot + TaskCluster scheduling changes for quantum/mitmproxy job

Status: RESOLVED FIXED

(Release Engineering :: General, enhancement)

Description

[Armen [:armenzg]]

We can probably already start with changes for Windows 7 machines even if don't land it right away.

We need TC scheduling changes as we need to use the BBB.

For now, I will track bug 1358307 for the Win10 pool, however, that bug is only for 4 machines while we need a whole pool.

Comment 1

[Robert Wood [:rwood]]

FYI Bug 1354296 can be used as a reference for how to add TC/BB configs for a new talos test suite

Comment 2

[Robert Wood [:rwood]]

Attachment: bug1362407_bb.patch

Buildbot configs, preparing for when we land the test (Bug 1357382). Want to enable it on e10s only, no point having it on NON-e10s.

Comment 3

[Robert Wood [:rwood]]

Attachment: Bug 1362407 - TC configs for new quantum-pageload-e10s test;

Review commit: https://reviewboard.mozilla.org/r/138074/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138074/

Comment 4

[Wander Lairson Costa]

Comment on attachment 8866449 [details]
Bug 1362407 - TC configs for new quantum-pageload-e10s test;

https://reviewboard.mozilla.org/r/138074/#review141254

Comment 5

[Kim Moir [:kmoir] ET]

Comment on attachment 8866441 [details] [diff] [review]
bug1362407_bb.patch

Looks good to me, I assume you want this on all talos platforms? It's confusing because it depends on bug 1358307 for w10 machines.

As a side note with respect to the tc patch, I just landed another patch in bug 1363420 which may require the tc patch on this bug to be updated to include linux64-stylo-sequential.

Comment 6

[Robert Wood [:rwood]]

Attachments bitrotted, creating new ones. The new Quantum_1 talos pageload test has landed in central, now we need BB and TC configs to have it run on Windows.

Comment 7

[Robert Wood [:rwood]]

Comment on attachment 8866449 [details]
Bug 1362407 - TC configs for new quantum-pageload-e10s test;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/138074/diff/1-2/

Comment 8

[Robert Wood [:rwood]]

Attachment: bug1362407-buildbot.patch

BB configs for quantum-pageload-e10s (this test is only for Windows, for now). Thanks!

Comment 9

[Robert Wood [:rwood]]

Thanks Kim! Landed the BB configs:

https://hg.mozilla.org/build/buildbot-configs/rev/59a3dd1f136c0135b20e39c97ad282f2af5fbd17

Comment 10

[Wander Lairson Costa]

Comment on attachment 8866449 [details]
Bug 1362407 - TC configs for new quantum-pageload-e10s test;

https://reviewboard.mozilla.org/r/138074/#review147690

::: taskcluster/ci/test/test-sets.yml:69
(Diff revision 2)
>      - talos-g5
>      - talos-other
>      - talos-svgr
>      - talos-tp5o
>      - talos-perf-reftest
> +    - talos-quantum-pageload

Notice there is a specific section if you want to run it in Mac too

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

as this runs on windows only right now, lets not add it to taskcluster since taskcluster schedules linux/osx.

Comment 12

[Robert Wood [:rwood]]

(In reply to Joel Maher ( :jmaher) from comment #11)
> as this runs on windows only right now, lets not add it to taskcluster since
> taskcluster schedules linux/osx.

Ok. How will it show up on treeherder then if the group symbol and name etc. aren't specified?

Comment 13

[Joel Maher ( :jmaher ) (UTC -8)]

good question, it will show up by hacking on treeherder to display the job properly.  By default this will show up as a '?' and we can match the buildername in treeherder to the symbol we want.

Comment 14

[GitHub Autolander Bot]

Attachment: [treeherder] rwood-moz:bug1362407 > mozilla:master

Comment 15

[Robert Wood [:rwood]]

Comment on attachment 8872759 [details] [review]
[treeherder] rwood-moz:bug1362407 > mozilla:master

I don't know how to finish this - feedback would be awesome thanks :)

Comment 16

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8872759 [details] [review]
[treeherder] rwood-moz:bug1362407 > mozilla:master

this looks pretty good

Comment 17

[Robert Wood [:rwood]]

Thanks :jmaher, I was thinking I was missing something. I'll add unit tests and update the PR.

Comment 18

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/5e7a78cbbd129b21164609a3d96353dc114ecde8
Bug 1362407 - Treeherder config for new talos quantum-pageload-e10s test (#2516)