[lint] Write custom lint check to enfore SafeIntent usage

NEW
Unassigned

Status

()

P5
normal
a year ago
2 months ago

People

(Reporter: ahunt, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

a year ago
Other apps can put garbage in Intents, causing crashes. This usually gets discovered when apps like Facebook start crashing us:
Bug 1147992
Bug 1299939
Bug 1077645 (this might be the "original", has some dupes)

We occasionally notice and fix this before the crashes flood in:
Bug 1152873

A lint check would be nice to make sure we catch these issues early.

It would be nice to add this to Focus too (of course we hit that there too, fortunately discovered during beta: https://github.com/mozilla-mobile/focus-android/issues/569 ). Even nicer would be a shared lint-suite for all Mozilla products, so perhaps it would be worth writing these customs lint checks as a project on github or similar, which we can then perhaps include using gradle (is that even feasible? I don't know).

And we should probably share our SafeIntent implementation (and other Browser Utils) in a library somewhere. That will be easier once we only need to support gradle builds.
(Reporter)

Comment 1

a year ago
IIRC maliu originally suggested doing this!
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.