1362846 - Going back from a custom tab/web app can end up on our "new tab page" instead of the original previous activity

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Jan Henning [:JanH]]

(In reply to smartfon.reddit from bug 1360699 comment #8)
> Is this new problem related to this bug, or should I open a new one? It
> started few days ago.
> 
> Custom Tab closes and opens Firefox's Nightly Home page instead of
> navigating to original app, after pressing Android back button.
> 
> 1. Open Nightly. Enable Custom Tabs. Swipe and close all items from tab
> manager, including Firefox Nightly tab. You'll have a new active instance of
> Firefox Nightly.
> 
> 2. Swipe and close Nightly from Android recents memory.
> 
> 3. Open a 3rd party app and tap on a website link. Custom Tabs opens the
> site.
> 
> 4. Press the Android back button to go back to 3rd party app. It closes the
> Custom Tab and opens Android Nightly's Nightly Home tab (where bookmarks and
> history are).

What happens is that if we start for a custom tab/web app and don't have any previous session to restore in background we just open the tab powering the custom tab/web app.
When we exit that activity, we also close the tab, but because it's the last tab, we have to provide a replacement for it, so we open about:home (or the home page), which triggers the activity switch that brings the browser activity into the foreground.

In any case this seems to be fixed by my patches for bug 1359531.

Comment 2

[Jan Henning [:JanH]]

Fixed indeed by bug 1359531, part 5 I think:
https://hg.mozilla.org/mozilla-central/rev/bd4d35fd55f4